From 21c40c74af823980cfa1cda8d2782dbc109bfb7d Mon Sep 17 00:00:00 2001
From: Alex Baker <alex@tasks.org>
Date: Fri, 19 Apr 2019 11:24:00 -0500
Subject: [PATCH] Add contact developer link to preferences

---
 .../injection/InjectingPreferenceActivity.java | 18 ++++++++++--------
 .../tasks/preferences/BasicPreferences.java    |  7 +++++++
 app/src/main/res/xml/preferences.xml           |  4 ++++
 3 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/app/src/main/java/org/tasks/injection/InjectingPreferenceActivity.java b/app/src/main/java/org/tasks/injection/InjectingPreferenceActivity.java
index 6f5b413a2..f4925ae07 100644
--- a/app/src/main/java/org/tasks/injection/InjectingPreferenceActivity.java
+++ b/app/src/main/java/org/tasks/injection/InjectingPreferenceActivity.java
@@ -138,16 +138,9 @@ public abstract class InjectingPreferenceActivity extends AppCompatPreferenceAct
 
   @Override
   public boolean onMenuItemClick(MenuItem item) {
-    String email = getString(R.string.support_email);
     switch (item.getItemId()) {
       case R.id.menu_contact:
-        Intent mailto =
-            new Intent(
-                Intent.ACTION_SENDTO,
-                Uri.fromParts("mailto", "Alex <" + email + ">", null));
-        mailto.putExtra(Intent.EXTRA_SUBJECT, "Tasks Feedback");
-        mailto.putExtra(Intent.EXTRA_TEXT, device.getDebugInfo());
-        startActivity(mailto);
+        emailSupport();
         return true;
       case R.id.menu_help:
         startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse(getHelpUrl())));
@@ -157,6 +150,15 @@ public abstract class InjectingPreferenceActivity extends AppCompatPreferenceAct
     }
   }
 
+  protected void emailSupport() {
+    startActivity(
+        new Intent(
+                Intent.ACTION_SENDTO,
+                Uri.fromParts("mailto", "Alex <" + getString(R.string.support_email) + ">", null))
+            .putExtra(Intent.EXTRA_SUBJECT, "Tasks Feedback")
+            .putExtra(Intent.EXTRA_TEXT, device.getDebugInfo()));
+  }
+
   protected String getHelpUrl() {
     return "http://tasks.org/help";
   }
diff --git a/app/src/main/java/org/tasks/preferences/BasicPreferences.java b/app/src/main/java/org/tasks/preferences/BasicPreferences.java
index dc0d5ff62..e4ac0d087 100644
--- a/app/src/main/java/org/tasks/preferences/BasicPreferences.java
+++ b/app/src/main/java/org/tasks/preferences/BasicPreferences.java
@@ -198,6 +198,13 @@ public class BasicPreferences extends InjectingPreferenceActivity
           }
         });
 
+    findPreference(R.string.contact_developer)
+        .setOnPreferenceClickListener(
+            preference -> {
+              emailSupport();
+              return false;
+            });
+
     findPreference(R.string.third_party_licenses)
         .setOnPreferenceClickListener(
             preference -> {
diff --git a/app/src/main/res/xml/preferences.xml b/app/src/main/res/xml/preferences.xml
index bb0c6f60e..43f398a1e 100644
--- a/app/src/main/res/xml/preferences.xml
+++ b/app/src/main/res/xml/preferences.xml
@@ -152,6 +152,10 @@
       android:key="@string/third_party_licenses"
       android:title="@string/third_party_licenses"/>
 
+    <Preference
+      android:key="@string/contact_developer"
+      android:title="@string/contact_developer"/>
+
     <Preference
       android:key="@string/rate_tasks"
       android:title="@string/rate_tasks"/>