diff --git a/lint.xml b/lint.xml index afe368674..65405bb9e 100644 --- a/lint.xml +++ b/lint.xml @@ -3,8 +3,5 @@ - - - diff --git a/src/main/AndroidManifest.xml b/src/main/AndroidManifest.xml index a1b029efb..4a55135a4 100644 --- a/src/main/AndroidManifest.xml +++ b/src/main/AndroidManifest.xml @@ -89,6 +89,7 @@ android:required="false" /> { TYPE instance; try { instance = modelClass.newInstance(); - } catch (InstantiationException | IllegalAccessException e) { + } catch (InstantiationException e) { + throw new RuntimeException(e); + } catch (IllegalAccessException e) { throw new RuntimeException(e); } instance.readPropertiesFromCursor(cursor); diff --git a/src/main/java/com/todoroo/astrid/dao/Database.java b/src/main/java/com/todoroo/astrid/dao/Database.java index a119f2d4a..a080f1182 100644 --- a/src/main/java/com/todoroo/astrid/dao/Database.java +++ b/src/main/java/com/todoroo/astrid/dao/Database.java @@ -134,7 +134,7 @@ public class Database { try { database.execSQL(sql); } catch (SQLiteException e) { - Timber.e(e, "SQL Error: " + sql); + Timber.e(e, "SQL Error: %s", sql); } } diff --git a/src/main/java/com/todoroo/astrid/files/FilesControlSet.java b/src/main/java/com/todoroo/astrid/files/FilesControlSet.java index c61fcc86d..fd2edb000 100644 --- a/src/main/java/com/todoroo/astrid/files/FilesControlSet.java +++ b/src/main/java/com/todoroo/astrid/files/FilesControlSet.java @@ -5,6 +5,7 @@ */ package com.todoroo.astrid.files; +import android.annotation.SuppressLint; import android.app.Activity; import android.content.ActivityNotFoundException; import android.content.ClipData; @@ -202,6 +203,7 @@ public class FilesControlSet extends TaskEditControlFragment { } } + @SuppressLint("NewApi") private void showFile(final TaskAttachment m) { final String fileType = m.containsNonNullValue(TaskAttachment.CONTENT_TYPE) ? m.getContentType() : TaskAttachment.FILE_TYPE_OTHER; final String filePath = m.getFilePath(); diff --git a/src/main/java/com/todoroo/astrid/tags/TagsControlSet.java b/src/main/java/com/todoroo/astrid/tags/TagsControlSet.java index c98dd4da6..b659e008d 100644 --- a/src/main/java/com/todoroo/astrid/tags/TagsControlSet.java +++ b/src/main/java/com/todoroo/astrid/tags/TagsControlSet.java @@ -5,6 +5,7 @@ */ package com.todoroo.astrid.tags; +import android.annotation.SuppressLint; import android.graphics.drawable.Drawable; import android.os.Bundle; import android.support.annotation.Nullable; @@ -151,6 +152,7 @@ public final class TagsControlSet extends TaskEditControlFragment { newTagLayout = (LinearLayout) dialogView.findViewById(R.id.newTags); tagListView = (ListView) dialogView.findViewById(R.id.existingTags); tagListView.setAdapter(new ArrayAdapter(getActivity(), R.layout.simple_list_item_multiple_choice_themed, allTags) { + @SuppressLint("NewApi") @Override public View getView(int position, View convertView, ViewGroup parent) { CheckedTextView view = (CheckedTextView) super.getView(position, convertView, parent); diff --git a/src/main/java/org/tasks/Notifier.java b/src/main/java/org/tasks/Notifier.java index 1cee65d63..345f53a46 100644 --- a/src/main/java/org/tasks/Notifier.java +++ b/src/main/java/org/tasks/Notifier.java @@ -1,5 +1,6 @@ package org.tasks; +import android.annotation.SuppressLint; import android.app.Notification; import android.app.PendingIntent; import android.content.ContentUris; @@ -298,6 +299,7 @@ public class Notifier { return true; } + @SuppressLint("NewApi") private void activateNotification(int ringTimes, int notificationId, Notification notification, String text) { if (preferences.getBoolean(R.string.p_rmd_persistent, true)) { notification.flags |= Notification.FLAG_NO_CLEAR; diff --git a/src/main/java/org/tasks/activities/CameraActivity.java b/src/main/java/org/tasks/activities/CameraActivity.java index 30c61cbff..eac1e20b5 100644 --- a/src/main/java/org/tasks/activities/CameraActivity.java +++ b/src/main/java/org/tasks/activities/CameraActivity.java @@ -1,5 +1,6 @@ package org.tasks.activities; +import android.annotation.SuppressLint; import android.content.ClipData; import android.content.Intent; import android.net.Uri; @@ -33,6 +34,7 @@ public class CameraActivity extends InjectingAppCompatActivity { private File output; + @SuppressLint("NewApi") @Override protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); diff --git a/src/main/java/org/tasks/dialogs/ColorPickerDialog.java b/src/main/java/org/tasks/dialogs/ColorPickerDialog.java index 3056778c2..cda6e2ad9 100644 --- a/src/main/java/org/tasks/dialogs/ColorPickerDialog.java +++ b/src/main/java/org/tasks/dialogs/ColorPickerDialog.java @@ -1,5 +1,6 @@ package org.tasks.dialogs; +import android.annotation.SuppressLint; import android.app.Activity; import android.app.Dialog; import android.content.Context; @@ -68,6 +69,7 @@ public class ColorPickerDialog extends InjectingDialogFragment { final LayoutInflater inflater = theme.getLayoutInflater(context); adapter = new ArrayAdapter(context, R.layout.color_selection_row, themes) { + @SuppressLint("NewApi") @Override public View getView(int position, View convertView, ViewGroup parent) { TextView textView = (TextView) (convertView == null diff --git a/src/main/java/org/tasks/locale/Locale.java b/src/main/java/org/tasks/locale/Locale.java index b44c14106..330aa56ce 100644 --- a/src/main/java/org/tasks/locale/Locale.java +++ b/src/main/java/org/tasks/locale/Locale.java @@ -1,5 +1,6 @@ package org.tasks.locale; +import android.annotation.SuppressLint; import android.app.Dialog; import android.content.Context; import android.content.SharedPreferences; @@ -101,6 +102,7 @@ public class Locale { return languageOverride; } + @SuppressLint("NewApi") public Context createConfigurationContext(Context context) { return hasUserOverrides ? context.createConfigurationContext(getLocaleConfiguration()) @@ -116,6 +118,7 @@ public class Locale { return configuration; } + @SuppressLint("NewApi") public void applyOverrideConfiguration(ContextThemeWrapper wrapper) { if (hasUserOverrides) { wrapper.applyOverrideConfiguration(getLocaleConfiguration()); @@ -162,6 +165,7 @@ public class Locale { '}'; } + @SuppressLint("NewApi") public void applyDirectionality(Dialog dialog) { if (hasUserOverrides) { dialog.findViewById(android.R.id.content).setLayoutDirection(appDirectionality); diff --git a/src/main/java/org/tasks/scheduling/AlarmManager.java b/src/main/java/org/tasks/scheduling/AlarmManager.java index d5a424bc4..356929442 100644 --- a/src/main/java/org/tasks/scheduling/AlarmManager.java +++ b/src/main/java/org/tasks/scheduling/AlarmManager.java @@ -1,5 +1,6 @@ package org.tasks.scheduling; +import android.annotation.SuppressLint; import android.app.PendingIntent; import android.content.Context; @@ -31,6 +32,7 @@ public class AlarmManager { wakeup(adjustForQuietHours(time), pendingIntent); } + @SuppressLint("NewApi") public void wakeup(long time, PendingIntent pendingIntent) { if (preferences.isDozeNotificationEnabled()) { alarmManager.setExactAndAllowWhileIdle(android.app.AlarmManager.RTC_WAKEUP, time, pendingIntent); @@ -41,6 +43,7 @@ public class AlarmManager { } } + @SuppressLint("NewApi") public void noWakeup(long time, PendingIntent pendingIntent) { if (preferences.isDozeNotificationEnabled()) { alarmManager.setExactAndAllowWhileIdle(android.app.AlarmManager.RTC, time, pendingIntent); diff --git a/src/main/java/org/tasks/themes/ThemeColor.java b/src/main/java/org/tasks/themes/ThemeColor.java index 246ce2d34..5c65095db 100644 --- a/src/main/java/org/tasks/themes/ThemeColor.java +++ b/src/main/java/org/tasks/themes/ThemeColor.java @@ -1,5 +1,6 @@ package org.tasks.themes; +import android.annotation.SuppressLint; import android.app.Activity; import android.app.ActivityManager; import android.content.res.Resources; @@ -54,6 +55,7 @@ public class ThemeColor { this.isDark = isDark; } + @SuppressLint("NewApi") public void applyStatusBarColor(Activity activity) { if (atLeastLollipop()) { activity.getWindow().setStatusBarColor(getColorPrimaryDark()); @@ -65,6 +67,7 @@ public class ThemeColor { } } + @SuppressLint("NewApi") public void applyStatusBarColor(DrawerLayout drawerLayout) { if (atLeastLollipop()) { drawerLayout.setStatusBarBackgroundColor(getColorPrimaryDark()); @@ -85,6 +88,7 @@ public class ThemeColor { theme.applyStyle(style, true); } + @SuppressLint("NewApi") public void applyTaskDescription(Activity activity, String description) { if (atLeastLollipop()) { activity.setTaskDescription(new ActivityManager.TaskDescription(description, null, getPrimaryColor())); diff --git a/src/main/res/layout-w820dp/task_list_activity.xml b/src/main/res/layout-w820dp/task_list_activity.xml index 9c9ae5161..f4af8af9e 100644 --- a/src/main/res/layout-w820dp/task_list_activity.xml +++ b/src/main/res/layout-w820dp/task_list_activity.xml @@ -1,4 +1,5 @@ + android:layout_weight="60" + tools:ignore="InconsistentLayout" /> + android:layout_weight="40" + tools:ignore="InconsistentLayout" /> diff --git a/src/main/res/layout/aac_record_activity.xml b/src/main/res/layout/aac_record_activity.xml index 955687092..88217cea3 100644 --- a/src/main/res/layout/aac_record_activity.xml +++ b/src/main/res/layout/aac_record_activity.xml @@ -30,7 +30,7 @@ + android:layout_height="match_parent" + tools:ignore="InconsistentLayout" /> diff --git a/src/main/res/values-bg-rBG/strings.xml b/src/main/res/values-bg-rBG/strings.xml index c585620ea..82b4e2836 100644 --- a/src/main/res/values-bg-rBG/strings.xml +++ b/src/main/res/values-bg-rBG/strings.xml @@ -339,7 +339,6 @@ Покажи скрити Покажи завършени Обратно - %s Задачи Покупки в приложението Не е намерено приложение за отваряне на прикачения файл Добавяне на прикачен файл diff --git a/src/main/res/values-de/strings.xml b/src/main/res/values-de/strings.xml index 5ab6df060..c48d7d82f 100644 --- a/src/main/res/values-de/strings.xml +++ b/src/main/res/values-de/strings.xml @@ -327,7 +327,6 @@ Ausgeblendet anzeigen Erledigt anzeigen Rückgangig - %s Aufgaben In-App Käufe Keine Anwendung zum Öffnen des Anhangs gefunden Anhang hinzufügen diff --git a/src/main/res/values-es/strings.xml b/src/main/res/values-es/strings.xml index b1279d83c..b44e29ce2 100644 --- a/src/main/res/values-es/strings.xml +++ b/src/main/res/values-es/strings.xml @@ -335,7 +335,6 @@ Mostrar oculto Mostrar completado Invertir - %s Tareas Compras en la aplicación No se ha encontrado una aplicación para abrir el archivo adjunto Adjuntar archivo diff --git a/src/main/res/values-fr/strings.xml b/src/main/res/values-fr/strings.xml index 764e5dbe5..22c4c11a2 100644 --- a/src/main/res/values-fr/strings.xml +++ b/src/main/res/values-fr/strings.xml @@ -329,7 +329,6 @@ Afficher les tâches cachées Afficher les tâches terminées Inverser - %s Tâches Achats intégrés à l\'application Aucune application trouvée pour ouvrir la pièce jointe Ajouter une pièce jointe diff --git a/src/main/res/values-hu/strings.xml b/src/main/res/values-hu/strings.xml index 755564b5e..d3e4c471f 100644 --- a/src/main/res/values-hu/strings.xml +++ b/src/main/res/values-hu/strings.xml @@ -124,5 +124,4 @@ Szűrő beállítások Rejtettek mutatása Befejezettek mutatása - %s feladatok \ No newline at end of file diff --git a/src/main/res/values-it/strings.xml b/src/main/res/values-it/strings.xml index b76162cd8..adaf67a87 100644 --- a/src/main/res/values-it/strings.xml +++ b/src/main/res/values-it/strings.xml @@ -332,7 +332,6 @@ Mostra nascoste Mostra completate Contrario - %s Attività Acquisti nell\'app. Nessuna applicazione in grado di aprire l\'allegato Aggiungi allegato diff --git a/src/main/res/values-iw/strings.xml b/src/main/res/values-iw/strings.xml index 69c09e97b..1ace7baca 100644 --- a/src/main/res/values-iw/strings.xml +++ b/src/main/res/values-iw/strings.xml @@ -337,7 +337,6 @@ הצגת משימות נסתרות הצגת משימות שבוצעו אחורה - %s משימות רכישות בתוך הישום לא נמצאה אפליקצה לפתיחת הקובץ הוספ/י קובץ diff --git a/src/main/res/values-ja/strings.xml b/src/main/res/values-ja/strings.xml index d6452dcc6..5162d9eed 100644 --- a/src/main/res/values-ja/strings.xml +++ b/src/main/res/values-ja/strings.xml @@ -337,7 +337,6 @@ 非表示を表示 完了を表示 逆順 - %s タスク アプリ内課金 添付ファイルを開くアプリケーションが見つかりません 添付ファイルを追加 diff --git a/src/main/res/values-ko/strings.xml b/src/main/res/values-ko/strings.xml index c8b5161fc..d87ecf4d4 100644 --- a/src/main/res/values-ko/strings.xml +++ b/src/main/res/values-ko/strings.xml @@ -334,7 +334,6 @@ 숨겨진 일정 표시 완료된 일정 표시 반전 - %s 일정 인앱 결제 첨부 파일을 열 수 있는 앱이 발견되지 않았습니다 첨부파일 추가 diff --git a/src/main/res/values-nl/strings.xml b/src/main/res/values-nl/strings.xml index 5c4053b25..e6fed569e 100644 --- a/src/main/res/values-nl/strings.xml +++ b/src/main/res/values-nl/strings.xml @@ -332,7 +332,6 @@ Toon verborgen Toon voltooide Omgekeerde - %s Taken In-app aankopen Geen applicatie gevonden om de bijlage te openen Bijlage toevoegen diff --git a/src/main/res/values-pt/strings.xml b/src/main/res/values-pt/strings.xml index b2e513a80..fc676051d 100644 --- a/src/main/res/values-pt/strings.xml +++ b/src/main/res/values-pt/strings.xml @@ -311,7 +311,6 @@ Mostrar ocultas Mostrar terminadas Reverter - %s tarefas desativar cada hora cada 3 horas diff --git a/src/main/res/values-ru/strings.xml b/src/main/res/values-ru/strings.xml index b8d05a410..e12015099 100644 --- a/src/main/res/values-ru/strings.xml +++ b/src/main/res/values-ru/strings.xml @@ -336,7 +336,6 @@ Показать скрытые Показать выполненные Реверс - %s задач Покупки в приложении Не найдено приложение, позволяющее открыть прикреплённый файл Прикрепить файл diff --git a/src/main/res/values-sk/strings.xml b/src/main/res/values-sk/strings.xml index a40cabcec..f3f398991 100644 --- a/src/main/res/values-sk/strings.xml +++ b/src/main/res/values-sk/strings.xml @@ -293,7 +293,6 @@ Nastavenie filtra Zobraziť skryté Zobraziť dokončené - %s úlohy zakázať každú hodinu každé tri hodiny diff --git a/src/main/res/values-sv/strings.xml b/src/main/res/values-sv/strings.xml index f95f1aa91..4cf43bed9 100644 --- a/src/main/res/values-sv/strings.xml +++ b/src/main/res/values-sv/strings.xml @@ -336,7 +336,6 @@ Visa dolda Visa slutförda Omvänt - %s Uppgifter Köp i app Ingen applikation hittades för att öppna bilagan Bifoga filer diff --git a/src/main/res/values-uk/strings.xml b/src/main/res/values-uk/strings.xml index 1cb4a3369..b65bb9d6d 100644 --- a/src/main/res/values-uk/strings.xml +++ b/src/main/res/values-uk/strings.xml @@ -335,7 +335,6 @@ Показати приховані Показати завершені Реверс - %s Завдань Покупки в застосунку Не знайдено програми для відкриття вкладення Додати вкладення diff --git a/src/main/res/values-w820dp/styles.xml b/src/main/res/values-w820dp/styles.xml index 5cb976671..3cf23f5bc 100644 --- a/src/main/res/values-w820dp/styles.xml +++ b/src/main/res/values-w820dp/styles.xml @@ -1,10 +1,10 @@ - + \ No newline at end of file diff --git a/src/main/res/values/strings.xml b/src/main/res/values/strings.xml index 143c58bae..3a6c1fa7e 100644 --- a/src/main/res/values/strings.xml +++ b/src/main/res/values/strings.xml @@ -798,7 +798,7 @@ File %1$s contained %2$s.\n\n Show hidden Show completed Reverse - %s Tasks + %d tasks In-app purchases No application found to open attachment Add attachment diff --git a/src/main/res/values/styles.xml b/src/main/res/values/styles.xml index 1c3792eb5..e979c1c3b 100644 --- a/src/main/res/values/styles.xml +++ b/src/main/res/values/styles.xml @@ -1,4 +1,4 @@ - + @@ -104,7 +104,7 @@