diff --git a/src/main/java/com/todoroo/astrid/files/FilesControlSet.java b/src/main/java/com/todoroo/astrid/files/FilesControlSet.java index 527e9d37d..11e324d97 100644 --- a/src/main/java/com/todoroo/astrid/files/FilesControlSet.java +++ b/src/main/java/com/todoroo/astrid/files/FilesControlSet.java @@ -11,6 +11,7 @@ import android.content.DialogInterface; import android.content.Intent; import android.media.MediaPlayer; import android.net.Uri; +import android.support.v4.app.FragmentActivity; import android.text.TextUtils; import android.view.LayoutInflater; import android.view.View; @@ -51,7 +52,7 @@ public class FilesControlSet extends PopupControlSet { private final DialogBuilder dialogBuilder; public FilesControlSet(ActivityPreferences preferences, TaskAttachmentDao taskAttachmentDao, - Activity activity, DialogBuilder dialogBuilder) { + FragmentActivity activity, DialogBuilder dialogBuilder) { super(preferences, activity, R.layout.control_set_files_dialog, R.layout.control_set_files, R.string.TEA_control_files, dialogBuilder); this.taskAttachmentDao = taskAttachmentDao; this.dialogBuilder = new DialogBuilder(activity, preferences); diff --git a/src/main/java/com/todoroo/astrid/gcal/GCalControlSet.java b/src/main/java/com/todoroo/astrid/gcal/GCalControlSet.java index 4383fb874..5feec4c3f 100644 --- a/src/main/java/com/todoroo/astrid/gcal/GCalControlSet.java +++ b/src/main/java/com/todoroo/astrid/gcal/GCalControlSet.java @@ -5,12 +5,12 @@ */ package com.todoroo.astrid.gcal; -import android.app.Activity; import android.content.ContentResolver; import android.content.ContentValues; import android.content.Intent; import android.database.Cursor; import android.net.Uri; +import android.support.v4.app.FragmentActivity; import android.text.TextUtils; import android.view.View; import android.view.View.OnClickListener; @@ -53,7 +53,7 @@ public class GCalControlSet extends TaskEditControlSetBase { private Spinner calendarSelector; private TextView calendar; - public GCalControlSet(GCalHelper gcal, final Activity activity) { + public GCalControlSet(GCalHelper gcal, final FragmentActivity activity) { super(activity, R.layout.control_set_gcal_display); this.gcal = gcal; this.calendars = gcal.getCalendars(); diff --git a/src/main/java/com/todoroo/astrid/helper/TaskEditControlSetBase.java b/src/main/java/com/todoroo/astrid/helper/TaskEditControlSetBase.java index 3aa01b073..ce25d7e49 100644 --- a/src/main/java/com/todoroo/astrid/helper/TaskEditControlSetBase.java +++ b/src/main/java/com/todoroo/astrid/helper/TaskEditControlSetBase.java @@ -5,17 +5,12 @@ */ package com.todoroo.astrid.helper; -import android.app.Activity; -import android.content.res.ColorStateList; -import android.content.res.Resources.Theme; -import android.util.TypedValue; +import android.support.v4.app.FragmentActivity; import android.view.LayoutInflater; import android.view.View; -import android.widget.Button; import android.widget.LinearLayout; import com.todoroo.astrid.data.Task; -import com.todoroo.astrid.ui.EditDialogOkBackground; import org.tasks.R; @@ -28,7 +23,7 @@ import static org.tasks.preferences.ResourceResolver.getData; */ public abstract class TaskEditControlSetBase implements TaskEditControlSet { - protected final Activity activity; + protected final FragmentActivity activity; private final int viewLayout; private boolean useTemplate; private View view; @@ -37,11 +32,11 @@ public abstract class TaskEditControlSetBase implements TaskEditControlSet { protected final int themeColor; protected final int unsetColor; - public TaskEditControlSetBase(Activity activity, int viewLayout) { + public TaskEditControlSetBase(FragmentActivity activity, int viewLayout) { this(activity, viewLayout, true); } - public TaskEditControlSetBase(Activity activity, int viewLayout, boolean useTemplate) { + public TaskEditControlSetBase(FragmentActivity activity, int viewLayout, boolean useTemplate) { this.activity = activity; this.viewLayout = viewLayout; this.useTemplate = useTemplate; diff --git a/src/main/java/com/todoroo/astrid/repeats/RepeatControlSet.java b/src/main/java/com/todoroo/astrid/repeats/RepeatControlSet.java index d87b908b6..94da08844 100644 --- a/src/main/java/com/todoroo/astrid/repeats/RepeatControlSet.java +++ b/src/main/java/com/todoroo/astrid/repeats/RepeatControlSet.java @@ -5,12 +5,13 @@ */ package com.todoroo.astrid.repeats; -import android.app.Activity; import android.app.Dialog; import android.content.DialogInterface; +import android.support.v4.app.FragmentActivity; import android.support.v7.app.AlertDialog; import android.text.TextUtils; import android.view.View; +import android.view.ViewGroup; import android.view.ViewGroup.LayoutParams; import android.widget.AdapterView; import android.widget.AdapterView.OnItemSelectedListener; @@ -22,23 +23,23 @@ import android.widget.LinearLayout; import android.widget.Spinner; import android.widget.TextView; +import com.fourmob.datetimepicker.date.DatePickerDialog; import com.google.ical.values.Frequency; import com.google.ical.values.RRule; import com.google.ical.values.Weekday; import com.google.ical.values.WeekdayNum; -import com.todoroo.andlib.utility.DialogUtilities; import com.todoroo.astrid.data.Task; -import com.todoroo.astrid.ui.DateAndTimeDialog; -import com.todoroo.astrid.ui.DateAndTimeDialog.DateAndTimeDialogListener; import com.todoroo.astrid.ui.DateAndTimePicker; import com.todoroo.astrid.ui.NumberPickerDialog; import com.todoroo.astrid.ui.NumberPickerDialog.OnNumberPickedListener; import com.todoroo.astrid.ui.PopupControlSet; +import org.joda.time.DateTime; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.tasks.R; import org.tasks.dialogs.DialogBuilder; +import org.tasks.dialogs.MyDatePickerDialog; import org.tasks.preferences.ActivityPreferences; import java.text.DateFormatSymbols; @@ -49,6 +50,7 @@ import java.util.LinkedList; import java.util.List; import static org.tasks.date.DateTimeUtils.newDate; +import static org.tasks.date.DateTimeUtils.newDateTime; /** * Control Set for managing repeats @@ -60,6 +62,8 @@ public class RepeatControlSet extends PopupControlSet { private static final Logger log = LoggerFactory.getLogger(RepeatControlSet.class); + private static final String FRAG_TAG_REPEAT_UNTIL = "frag_tag_repeat_until"; + // --- spinner constants public static final int INTERVAL_DAYS = 0; @@ -77,7 +81,9 @@ public class RepeatControlSet extends PopupControlSet { private Button value; private Spinner interval; private Spinner type; - private Button repeatUntil; + private Spinner repeatUntil; + private ArrayAdapter repeatUntilAdapter; + private final List repeatUntilOptions = new ArrayList<>(); private LinearLayout daysOfWeekContainer; private final CompoundButton[] daysOfWeek = new CompoundButton[7]; @@ -95,7 +101,7 @@ public class RepeatControlSet extends PopupControlSet { // --- implementation - public RepeatControlSet(ActivityPreferences preferences, Activity activity, DialogBuilder dialogBuilder) { + public RepeatControlSet(ActivityPreferences preferences, FragmentActivity activity, DialogBuilder dialogBuilder) { super(preferences, activity, R.layout.control_set_repeat, R.layout.control_set_repeat_display, R.string.repeat_enabled, dialogBuilder); } @@ -107,12 +113,7 @@ public class RepeatControlSet extends PopupControlSet { private void setRepeatUntilValue(long newValue) { repeatUntilValue = newValue; - - if (newValue == 0) { - repeatUntil.setText(activity.getString(R.string.repeat_forever)); - } else { - repeatUntil.setText(activity.getString(R.string.repeat_until, DateAndTimePicker.getDisplayString(activity, newValue, false, false))); - } + updateRepeatUntilOptions(); } protected void repeatValueClick() { @@ -131,15 +132,21 @@ public class RepeatControlSet extends PopupControlSet { } private void repeatUntilClick() { - DateAndTimeDialog d = new DateAndTimeDialog(preferences, activity, repeatUntilValue, - R.layout.repeat_until_dialog, R.string.repeat_until_title); - d.setDateAndTimeDialogListener(new DateAndTimeDialogListener() { + MyDatePickerDialog dialog = new MyDatePickerDialog(); + DateTime initial = newDateTime(); + dialog.initialize(new DatePickerDialog.OnDateSetListener() { + @Override + public void onDateSet(DatePickerDialog datePickerDialog, int year, int month, int day) { + setRepeatUntilValue(new DateTime(year, month + 1, day, 0, 0, 0, 0).getMillis()); + } + }, initial.getYear(), initial.getMonthOfYear() - 1, initial.getDayOfMonth(), false); + dialog.setOnCancelListener(new DialogInterface.OnCancelListener() { @Override - public void onDateAndTimeSelected(long date) { - setRepeatUntilValue(date); + public void onCancel(DialogInterface dialog) { + setRepeatUntilValue(repeatUntilValue); } }); - d.show(); + dialog.show(activity.getSupportFragmentManager(), FRAG_TAG_REPEAT_UNTIL); } public void addListener(RepeatChangedListener listener) { @@ -251,17 +258,21 @@ public class RepeatControlSet extends PopupControlSet { @Override protected void afterInflate() { - value = (Button) getDialogView().findViewById(R.id.repeatValue); - interval = (Spinner) getDialogView().findViewById(R.id.repeatInterval); - interval.setAdapter(new ArrayAdapter(activity, R.layout.simple_spinner_item, activity.getResources().getStringArray(R.array.repeat_interval)) {{ + View dialogView = getDialogView(); + value = (Button) dialogView.findViewById(R.id.repeatValue); + interval = (Spinner) dialogView.findViewById(R.id.repeatInterval); + interval.setAdapter(new ArrayAdapter(activity, android.R.layout.simple_spinner_item, activity.getResources().getStringArray(R.array.repeat_interval)) {{ setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item); }}); - type = (Spinner) getDialogView().findViewById(R.id.repeatType); - type.setAdapter(new ArrayAdapter(activity, R.layout.simple_spinner_item, activity.getResources().getStringArray(R.array.repeat_type)) {{ + type = (Spinner) dialogView.findViewById(R.id.repeatType); + type.setAdapter(new ArrayAdapter(activity, android.R.layout.simple_spinner_item, activity.getResources().getStringArray(R.array.repeat_type)) {{ setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item); }}); - daysOfWeekContainer = (LinearLayout) getDialogView().findViewById(R.id.repeatDayOfWeekContainer); - repeatUntil = (Button) getDialogView().findViewById(R.id.repeatUntil); + daysOfWeekContainer = (LinearLayout) dialogView.findViewById(R.id.repeatDayOfWeekContainer); + repeatUntil = (Spinner) dialogView.findViewById(R.id.repeat_until); + repeatUntilAdapter = new ArrayAdapter<>(activity, android.R.layout.simple_spinner_item, repeatUntilOptions); + repeatUntilAdapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item); + repeatUntil.setAdapter(repeatUntilAdapter); setRepeatValue(1); setRepeatUntilValue(0); @@ -312,12 +323,30 @@ public class RepeatControlSet extends PopupControlSet { } }); - repeatUntil.setOnClickListener(new View.OnClickListener() { + repeatUntil.setOnItemSelectedListener(new OnItemSelectedListener() { @Override - public void onClick(View v) { - repeatUntilClick(); + public void onItemSelected(AdapterView adapterView, View view, int i, long l) { + if (repeatUntilOptions.size() == 2) { + if (i == 0) { + setRepeatUntilValue(0); + } else { + repeatUntilClick(); + } + } else { + if (i == 1) { + setRepeatUntilValue(0); + } else if (i == 2) { + repeatUntilClick(); + } + } + } + + @Override + public void onNothingSelected(AdapterView adapterView) { + // } }); + daysOfWeekContainer.setVisibility(View.GONE); } @@ -433,4 +462,15 @@ public class RepeatControlSet extends PopupControlSet { } }); } + + private void updateRepeatUntilOptions() { + repeatUntilOptions.clear(); + if (repeatUntilValue > 0) { + repeatUntilOptions.add(activity.getString(R.string.repeat_until, DateAndTimePicker.getDisplayString(activity, repeatUntilValue, false, false))); + } + repeatUntilOptions.add(activity.getString(R.string.repeat_forever)); + repeatUntilOptions.add(activity.getString(R.string.repeat_until, "").trim()); + repeatUntilAdapter.notifyDataSetChanged(); + repeatUntil.setSelection(0); + } } diff --git a/src/main/java/com/todoroo/astrid/repeats/RepeatTaskCompleteListener.java b/src/main/java/com/todoroo/astrid/repeats/RepeatTaskCompleteListener.java index 6a9d81b71..2e5d1cabd 100644 --- a/src/main/java/com/todoroo/astrid/repeats/RepeatTaskCompleteListener.java +++ b/src/main/java/com/todoroo/astrid/repeats/RepeatTaskCompleteListener.java @@ -24,6 +24,7 @@ import com.todoroo.astrid.gcal.GCalHelper; import com.todoroo.astrid.service.TaskService; import com.todoroo.astrid.utility.Flags; +import org.joda.time.DateTime; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.tasks.injection.InjectingBroadcastReceiver; @@ -39,6 +40,7 @@ import java.util.TimeZone; import javax.inject.Inject; import static org.tasks.date.DateTimeUtils.newDate; +import static org.tasks.date.DateTimeUtils.newDateTime; import static org.tasks.date.DateTimeUtils.newDateUtc; public class RepeatTaskCompleteListener extends InjectingBroadcastReceiver { @@ -80,8 +82,7 @@ public class RepeatTaskCompleteListener extends InjectingBroadcastReceiver { long oldDueDate = task.getDueDate(); long repeatUntil = task.getRepeatUntil(); - boolean repeatFinished = repeatUntil > 0 && newDueDate >= repeatUntil; - if (repeatFinished) { + if (repeatFinished(newDueDate, repeatUntil)) { return; } @@ -97,6 +98,12 @@ public class RepeatTaskCompleteListener extends InjectingBroadcastReceiver { } } + static boolean repeatFinished(long newDueDate, long repeatUntil) { + return repeatUntil > 0 && newDateTime(repeatUntil).getMillisOfDay() == 0 + ? newDateTime(newDueDate).withMillisOfDay(0).isAfter(repeatUntil) + : newDueDate >= repeatUntil; + } + public static void rescheduleTask(Context context, GCalHelper gcalHelper, TaskService taskService, Task task, long newDueDate) { long hideUntil = task.getHideUntil(); if(hideUntil > 0 && task.getDueDate() > 0) { diff --git a/src/main/java/com/todoroo/astrid/tags/TagsControlSet.java b/src/main/java/com/todoroo/astrid/tags/TagsControlSet.java index 123a4a926..b971d6050 100644 --- a/src/main/java/com/todoroo/astrid/tags/TagsControlSet.java +++ b/src/main/java/com/todoroo/astrid/tags/TagsControlSet.java @@ -6,6 +6,7 @@ package com.todoroo.astrid.tags; import android.app.Activity; +import android.support.v4.app.FragmentActivity; import android.support.v7.app.AlertDialog; import android.text.Editable; import android.text.TextUtils; @@ -72,7 +73,7 @@ public final class TagsControlSet extends PopupControlSet { private final TagDataDao tagDataDao; private final TagService tagService; - public TagsControlSet(MetadataDao metadataDao, TagDataDao tagDataDao, ActivityPreferences preferences, TagService tagService, Activity activity, DialogBuilder dialogBuilder) { + public TagsControlSet(MetadataDao metadataDao, TagDataDao tagDataDao, ActivityPreferences preferences, TagService tagService, FragmentActivity activity, DialogBuilder dialogBuilder) { super(preferences, activity, R.layout.control_set_tag_list, R.layout.control_set_tags, R.string.TEA_tags_label_long, dialogBuilder); this.metadataDao = metadataDao; this.tagDataDao = tagDataDao; diff --git a/src/main/java/com/todoroo/astrid/timers/TimerActionControlSet.java b/src/main/java/com/todoroo/astrid/timers/TimerActionControlSet.java index 0883e0074..c05b96c4b 100644 --- a/src/main/java/com/todoroo/astrid/timers/TimerActionControlSet.java +++ b/src/main/java/com/todoroo/astrid/timers/TimerActionControlSet.java @@ -5,8 +5,8 @@ */ package com.todoroo.astrid.timers; -import android.app.Activity; import android.os.SystemClock; +import android.support.v4.app.FragmentActivity; import android.text.format.DateFormat; import android.view.View; import android.view.View.OnClickListener; @@ -33,7 +33,7 @@ public class TimerActionControlSet extends TaskEditControlSetBase { private boolean timerActive; private final List listeners = new LinkedList<>(); - public TimerActionControlSet(final NotificationManager notificationManager, final TaskService taskService, final Activity activity, View parent) { + public TimerActionControlSet(final NotificationManager notificationManager, final TaskService taskService, final FragmentActivity activity, View parent) { super(activity, -1); LinearLayout timerContainer = (LinearLayout) parent.findViewById(R.id.timer_container); diff --git a/src/main/java/com/todoroo/astrid/timers/TimerControlSet.java b/src/main/java/com/todoroo/astrid/timers/TimerControlSet.java index a3e614b0c..d043dbc57 100644 --- a/src/main/java/com/todoroo/astrid/timers/TimerControlSet.java +++ b/src/main/java/com/todoroo/astrid/timers/TimerControlSet.java @@ -5,7 +5,7 @@ */ package com.todoroo.astrid.timers; -import android.app.Activity; +import android.support.v4.app.FragmentActivity; import android.text.TextUtils; import android.text.format.DateUtils; import android.view.View; @@ -34,7 +34,7 @@ public class TimerControlSet extends PopupControlSet implements TimerActionListe private final TextView displayEdit; private ActivityPreferences preferences; - public TimerControlSet(ActivityPreferences preferences, final Activity activity, DialogBuilder dialogBuilder) { + public TimerControlSet(ActivityPreferences preferences, final FragmentActivity activity, DialogBuilder dialogBuilder) { super(preferences, activity, R.layout.control_set_timers_dialog, R.layout.control_set_timers, R.string.TEA_timer_controls, dialogBuilder); this.preferences = preferences; @@ -81,7 +81,7 @@ public class TimerControlSet extends PopupControlSet implements TimerActionListe private final TimeDurationControlSet controlSet; private final IntegerProperty property; - public TimeDurationTaskEditControlSet(Activity activity, View v, IntegerProperty property, int timeButtonId) { + public TimeDurationTaskEditControlSet(FragmentActivity activity, View v, IntegerProperty property, int timeButtonId) { super(activity, -1); this.property = property; this.controlSet = new TimeDurationControlSet(activity, v, property, timeButtonId, preferences); diff --git a/src/main/java/com/todoroo/astrid/ui/DateAndTimeDialog.java b/src/main/java/com/todoroo/astrid/ui/DateAndTimeDialog.java deleted file mode 100644 index e07d3b1c0..000000000 --- a/src/main/java/com/todoroo/astrid/ui/DateAndTimeDialog.java +++ /dev/null @@ -1,87 +0,0 @@ -/** - * Copyright (c) 2012 Todoroo Inc - * - * See the file "LICENSE" for the full license governing this code. - */ -package com.todoroo.astrid.ui; - -import android.app.Dialog; -import android.content.Context; -import android.content.DialogInterface; -import android.view.View; -import android.view.Window; -import android.view.WindowManager.LayoutParams; -import android.widget.Button; - -import org.tasks.R; -import org.tasks.preferences.ActivityPreferences; - -public class DateAndTimeDialog extends Dialog { - - public interface DateAndTimeDialogListener { - void onDateAndTimeSelected(long date); - } - - private final DateAndTimePicker dateAndTimePicker; - private boolean cancelled = false; - - private DateAndTimeDialogListener listener; - - public DateAndTimeDialog(ActivityPreferences preferences, Context context, long startDate, int contentView, int title) { - super(context, preferences.getEditDialogTheme()); - - if (title == 0) { - requestWindowFeature(Window.FEATURE_NO_TITLE); - } else { - setTitle(title); - } - /** Design the dialog in main.xml file */ - setContentView(contentView); - - LayoutParams params = getWindow().getAttributes(); - params.height = LayoutParams.FILL_PARENT; - params.width = LayoutParams.FILL_PARENT; - getWindow().setAttributes(params); - - dateAndTimePicker = (DateAndTimePicker) findViewById(R.id.date_and_time); - dateAndTimePicker.initializeWithDate(startDate); - - Button okButton = (Button) findViewById(R.id.ok); - Button cancelButton = (Button) findViewById(R.id.cancel); - - okButton.setOnClickListener(new View.OnClickListener() { - @Override - public void onClick(View v) { - dismiss(); - if (listener != null) { - listener.onDateAndTimeSelected(dateAndTimePicker.constructDueDate()); - } - } - }); - - cancelButton.setOnClickListener(new View.OnClickListener() { - @Override - public void onClick(View v) { - cancelled = true; - cancel(); - } - }); - - setOnCancelListener(new OnCancelListener() { - @Override - public void onCancel(DialogInterface dialog) { - if (!cancelled) { // i.e. if back button pressed, which we treat as an "OK" - if (listener != null) { - listener.onDateAndTimeSelected(dateAndTimePicker.constructDueDate()); - } - } else { - cancelled = false; // reset - } - } - }); - } - - public void setDateAndTimeDialogListener(DateAndTimeDialogListener listener) { - this.listener = listener; - } -} diff --git a/src/main/java/com/todoroo/astrid/ui/DeadlineControlSet.java b/src/main/java/com/todoroo/astrid/ui/DeadlineControlSet.java index d07a5ffd7..6d19547aa 100644 --- a/src/main/java/com/todoroo/astrid/ui/DeadlineControlSet.java +++ b/src/main/java/com/todoroo/astrid/ui/DeadlineControlSet.java @@ -5,7 +5,7 @@ */ package com.todoroo.astrid.ui; -import android.app.Activity; +import android.support.v4.app.FragmentActivity; import android.text.TextUtils; import android.view.Gravity; import android.widget.LinearLayout; @@ -22,7 +22,7 @@ public class DeadlineControlSet extends PopupControlSet { private DateAndTimePicker dateAndTimePicker; - public DeadlineControlSet(ActivityPreferences preferences, Activity activity, DialogBuilder dialogBuilder) { + public DeadlineControlSet(ActivityPreferences preferences, FragmentActivity activity, DialogBuilder dialogBuilder) { super(preferences, activity, R.layout.control_set_deadline_dialog, R.layout.control_set_deadline, 0, dialogBuilder); } diff --git a/src/main/java/com/todoroo/astrid/ui/DescriptionControlSet.java b/src/main/java/com/todoroo/astrid/ui/DescriptionControlSet.java index 6fd0c4d09..ff1250f64 100644 --- a/src/main/java/com/todoroo/astrid/ui/DescriptionControlSet.java +++ b/src/main/java/com/todoroo/astrid/ui/DescriptionControlSet.java @@ -5,7 +5,7 @@ */ package com.todoroo.astrid.ui; -import android.app.Activity; +import android.support.v4.app.FragmentActivity; import android.widget.EditText; import com.todoroo.astrid.data.Task; @@ -17,7 +17,7 @@ public class DescriptionControlSet extends TaskEditControlSetBase { protected EditText editText; - public DescriptionControlSet(Activity activity) { + public DescriptionControlSet(FragmentActivity activity) { super(activity, R.layout.control_set_description); } diff --git a/src/main/java/com/todoroo/astrid/ui/ImportanceControlSet.java b/src/main/java/com/todoroo/astrid/ui/ImportanceControlSet.java index a6ed4eb82..53b652bb6 100644 --- a/src/main/java/com/todoroo/astrid/ui/ImportanceControlSet.java +++ b/src/main/java/com/todoroo/astrid/ui/ImportanceControlSet.java @@ -5,7 +5,7 @@ */ package com.todoroo.astrid.ui; -import android.app.Activity; +import android.support.v4.app.FragmentActivity; import android.util.DisplayMetrics; import android.view.View; import android.view.ViewGroup.LayoutParams; @@ -40,7 +40,7 @@ public class ImportanceControlSet extends TaskEditControlSetBase { void importanceChanged(int i); } - public ImportanceControlSet(Activity activity) { + public ImportanceControlSet(FragmentActivity activity) { super(activity, R.layout.control_set_importance); colors = Task.getImportanceColors(activity.getResources()); } diff --git a/src/main/java/com/todoroo/astrid/ui/PopupControlSet.java b/src/main/java/com/todoroo/astrid/ui/PopupControlSet.java index 8542e2367..2b59e61ce 100644 --- a/src/main/java/com/todoroo/astrid/ui/PopupControlSet.java +++ b/src/main/java/com/todoroo/astrid/ui/PopupControlSet.java @@ -5,21 +5,16 @@ */ package com.todoroo.astrid.ui; -import android.app.Activity; import android.app.Dialog; import android.content.DialogInterface; +import android.support.v4.app.FragmentActivity; import android.support.v7.app.AlertDialog; -import android.util.DisplayMetrics; import android.view.View; import android.view.View.OnClickListener; -import android.view.ViewGroup.LayoutParams; -import android.widget.Button; -import com.todoroo.andlib.utility.DialogUtilities; import com.todoroo.astrid.data.Task; import com.todoroo.astrid.helper.TaskEditControlSetBase; -import org.tasks.R; import org.tasks.dialogs.DialogBuilder; import org.tasks.preferences.ActivityPreferences; @@ -50,7 +45,7 @@ public abstract class PopupControlSet extends TaskEditControlSetBase { } }; - public PopupControlSet(ActivityPreferences preferences, Activity activity, int viewLayout, + public PopupControlSet(ActivityPreferences preferences, FragmentActivity activity, int viewLayout, int taskEditViewLayout, final int title, DialogBuilder dialogBuilder) { super(activity, viewLayout, false); this.preferences = preferences; diff --git a/src/main/java/com/todoroo/astrid/ui/RandomReminderControlSet.java b/src/main/java/com/todoroo/astrid/ui/RandomReminderControlSet.java index 8f6adc752..b9b577cfb 100644 --- a/src/main/java/com/todoroo/astrid/ui/RandomReminderControlSet.java +++ b/src/main/java/com/todoroo/astrid/ui/RandomReminderControlSet.java @@ -32,7 +32,7 @@ public class RandomReminderControlSet { periodSpinner.setVisibility(View.VISIBLE); // create adapter ArrayAdapter adapter = new ArrayAdapter<>( - activity, R.layout.simple_spinner_item, + activity, android.R.layout.simple_spinner_item, activity.getResources().getStringArray(R.array.TEA_reminder_random)); adapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item); periodSpinner.setAdapter(adapter); diff --git a/src/main/java/com/todoroo/astrid/ui/ReminderControlSet.java b/src/main/java/com/todoroo/astrid/ui/ReminderControlSet.java index 1bbe8e702..6fe79b1da 100644 --- a/src/main/java/com/todoroo/astrid/ui/ReminderControlSet.java +++ b/src/main/java/com/todoroo/astrid/ui/ReminderControlSet.java @@ -196,7 +196,7 @@ public class ReminderControlSet extends TaskEditControlSetBase implements Adapte }); addSpinner = (Spinner) getView().findViewById(R.id.alarms_add_spinner); addSpinner.setOnItemSelectedListener(ReminderControlSet.this); - remindAdapter = new ArrayAdapter(activity, R.layout.simple_spinner_item, spinnerOptions) { + remindAdapter = new ArrayAdapter(activity, android.R.layout.simple_spinner_item, spinnerOptions) { @Override public View getDropDownView(int position, View convertView, ViewGroup parent) { View v; diff --git a/src/main/java/org/tasks/preferences/ActivityPreferences.java b/src/main/java/org/tasks/preferences/ActivityPreferences.java index 3d230615e..3b55fc2c8 100644 --- a/src/main/java/org/tasks/preferences/ActivityPreferences.java +++ b/src/main/java/org/tasks/preferences/ActivityPreferences.java @@ -80,10 +80,6 @@ public class ActivityPreferences extends Preferences { return isDarkTheme() ? R.style.TasksDialogDark : R.style.TasksDialog; } - public int getEditDialogTheme() { - return isDarkTheme() ? R.style.TEA_Dialog_Dark : R.style.TEA_Dialog; - } - public boolean isDarkTheme() { return getBoolean(R.string.p_use_dark_theme, false); } diff --git a/src/main/res/layout/control_set_repeat.xml b/src/main/res/layout/control_set_repeat.xml index 61af008c9..51e431fe5 100644 --- a/src/main/res/layout/control_set_repeat.xml +++ b/src/main/res/layout/control_set_repeat.xml @@ -1,57 +1,67 @@ - - - - - - + android:paddingRight="5dip"> + - -