diff --git a/src/main/java/com/todoroo/astrid/activity/TaskEditFragment.java b/src/main/java/com/todoroo/astrid/activity/TaskEditFragment.java index 653a168c6..f62dadc72 100755 --- a/src/main/java/com/todoroo/astrid/activity/TaskEditFragment.java +++ b/src/main/java/com/todoroo/astrid/activity/TaskEditFragment.java @@ -141,6 +141,10 @@ public final class TaskEditFragment extends InjectingFragment implements Toolbar commentsController.initialize(model, comments); commentsController.reloadView(); + for (int i = 0 ; i < TaskEditControlSetFragmentManager.TASK_EDIT_CONTROL_FRAGMENT_ROWS.length - taskEditControlSetFragmentManager.getNumRows() ; i++) { + view.findViewById(TaskEditControlSetFragmentManager.TASK_EDIT_DIVIDER_ROWS[i]).setVisibility(View.GONE); + } + return view; } diff --git a/src/main/java/org/tasks/fragments/TaskEditControlSetFragmentManager.java b/src/main/java/org/tasks/fragments/TaskEditControlSetFragmentManager.java index ea09319e3..786c4d22a 100644 --- a/src/main/java/org/tasks/fragments/TaskEditControlSetFragmentManager.java +++ b/src/main/java/org/tasks/fragments/TaskEditControlSetFragmentManager.java @@ -51,6 +51,19 @@ public class TaskEditControlSetFragmentManager { R.id.row_10, }; + public static final int[] TASK_EDIT_DIVIDER_ROWS = new int[] { + R.id.row_divider_10, + R.id.row_divider_9, + R.id.row_divider_8, + R.id.row_divider_7, + R.id.row_divider_6, + R.id.row_divider_5, + R.id.row_divider_4, + R.id.row_divider_3, + R.id.row_divider_2, + R.id.row_divider_1 + }; + private static final int[] TASK_EDIT_CONTROL_SET_FRAGMENTS = new int[] { EditTitleControlSet.TAG, DeadlineControlSet.TAG, @@ -74,8 +87,8 @@ public class TaskEditControlSetFragmentManager { private final Map controlSetFragments = new LinkedHashMap<>(); private final List displayOrder; - private final String hideAlwaysTrigger; private final FragmentManager fragmentManager; + private int numRows; @Inject public TaskEditControlSetFragmentManager(Activity activity, Preferences preferences) { @@ -83,20 +96,26 @@ public class TaskEditControlSetFragmentManager { displayOrder.add(0, activity.getString(EditTitleControlSet.TAG)); displayOrder.add(1, activity.getString(CommentBarFragment.TAG)); fragmentManager = activity.getFragmentManager(); - hideAlwaysTrigger = activity.getString(R.string.TEA_ctrl_hide_section_pref); + String hideAlwaysTrigger = activity.getString(R.string.TEA_ctrl_hide_section_pref); + for (numRows = 0 ; numRows < displayOrder.size() ; numRows++) { + if (displayOrder.get(numRows).equals(hideAlwaysTrigger)) { + break; + } + } for (int resId : TASK_EDIT_CONTROL_SET_FRAGMENTS) { controlSetFragments.put(activity.getString(resId), resId); } } + public int getNumRows() { + return numRows; + } + public List createNewFragments(boolean isNewTask, Task task) { List taskEditControlFragments = new ArrayList<>(); - for (int i = 0; i < displayOrder.size(); i++) { + for (int i = 0; i < numRows; i++) { String item = displayOrder.get(i); - if (item.equals(hideAlwaysTrigger)) { - break; - } Integer resId = controlSetFragments.get(item); if (resId == null) { Timber.e("Unknown task edit control %s", item); diff --git a/src/main/java/org/tasks/ui/TaskEditControlFragment.java b/src/main/java/org/tasks/ui/TaskEditControlFragment.java index cf85d8ba8..c6527bc26 100644 --- a/src/main/java/org/tasks/ui/TaskEditControlFragment.java +++ b/src/main/java/org/tasks/ui/TaskEditControlFragment.java @@ -22,7 +22,7 @@ public abstract class TaskEditControlFragment extends InjectingFragment { public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { final View view = inflater.inflate(R.layout.control_set_template, null); LinearLayout content = (LinearLayout) view.findViewById(R.id.content); - content.addView(inflater.inflate(getLayout(), null)); + inflater.inflate(getLayout(), content); ImageView icon = (ImageView) view.findViewById(R.id.icon); icon.setImageResource(getIcon()); ButterKnife.bind(this, view); diff --git a/src/main/res/layout/control_set_deadline.xml b/src/main/res/layout/control_set_deadline.xml index cf56d795c..8282c96b3 100644 --- a/src/main/res/layout/control_set_deadline.xml +++ b/src/main/res/layout/control_set_deadline.xml @@ -1,6 +1,6 @@ diff --git a/src/main/res/layout/control_set_gcal_display.xml b/src/main/res/layout/control_set_gcal_display.xml index e8b222be7..6412cef87 100644 --- a/src/main/res/layout/control_set_gcal_display.xml +++ b/src/main/res/layout/control_set_gcal_display.xml @@ -4,12 +4,12 @@ ** See the file "LICENSE" for the full license governing this code. --> diff --git a/src/main/res/layout/control_set_repeat_display.xml b/src/main/res/layout/control_set_repeat_display.xml index 3771206c1..89f830b87 100644 --- a/src/main/res/layout/control_set_repeat_display.xml +++ b/src/main/res/layout/control_set_repeat_display.xml @@ -4,7 +4,7 @@ ** See the file "LICENSE" for the full license governing this code. --> diff --git a/src/main/res/layout/control_set_tag_list.xml b/src/main/res/layout/control_set_tag_list.xml index b0dddbcc2..f343f7adc 100644 --- a/src/main/res/layout/control_set_tag_list.xml +++ b/src/main/res/layout/control_set_tag_list.xml @@ -18,8 +18,7 @@ android:layout_width="fill_parent" android:layout_height="wrap_content" android:layout_marginTop="2dip" - android:layout_marginBottom="5dip" - /> + android:layout_marginBottom="5dip" /> - - - - - - - - \ No newline at end of file diff --git a/src/main/res/layout/control_set_timers_dialog.xml b/src/main/res/layout/control_set_timers_dialog.xml index bf124c337..1462918c5 100644 --- a/src/main/res/layout/control_set_timers_dialog.xml +++ b/src/main/res/layout/control_set_timers_dialog.xml @@ -27,18 +27,21 @@ style="@style/TextAppearance" /> + + - + diff --git a/src/main/res/layout/control_set_title.xml b/src/main/res/layout/control_set_title.xml index 43ff53eeb..7f4a113a7 100644 --- a/src/main/res/layout/control_set_title.xml +++ b/src/main/res/layout/control_set_title.xml @@ -10,7 +10,7 @@ + + + + + + + + + + + + + + + + + + + + 24dp 12dp + 68dp \ No newline at end of file diff --git a/src/main/res/values/dimens.xml b/src/main/res/values/dimens.xml index ca1d0966b..f02b28074 100644 --- a/src/main/res/values/dimens.xml +++ b/src/main/res/values/dimens.xml @@ -3,6 +3,7 @@ 260dp 16dp 20dp + 60dp 4dp 0dp diff --git a/src/main/res/values/styles.xml b/src/main/res/values/styles.xml index d159acd2c..a498590bd 100644 --- a/src/main/res/values/styles.xml +++ b/src/main/res/values/styles.xml @@ -64,6 +64,15 @@ 1px + +