diff --git a/astrid/res/drawable/ic_sort.png b/astrid/res/drawable/ic_sort.png
new file mode 100644
index 000000000..af942422d
Binary files /dev/null and b/astrid/res/drawable/ic_sort.png differ
diff --git a/astrid/res/layout/task_list_activity.xml b/astrid/res/layout/task_list_activity.xml
index 45359fe78..fd58f4c46 100644
--- a/astrid/res/layout/task_list_activity.xml
+++ b/astrid/res/layout/task_list_activity.xml
@@ -34,18 +34,6 @@
android:layout_height="fill_parent"
android:layout_weight="1"
android:orientation="horizontal">
-
-
-
-
+
+
+
+
+
+
diff --git a/astrid/src/com/todoroo/astrid/activity/DraggableTaskListActivity.java b/astrid/src/com/todoroo/astrid/activity/DraggableTaskListActivity.java
index a1f4f57fd..870a23cac 100644
--- a/astrid/src/com/todoroo/astrid/activity/DraggableTaskListActivity.java
+++ b/astrid/src/com/todoroo/astrid/activity/DraggableTaskListActivity.java
@@ -55,6 +55,12 @@ public class DraggableTaskListActivity extends TaskListActivity {
return getLayoutInflater().inflate(R.layout.task_list_body_draggable, root, false);
}
+ @Override
+ protected void setUpUiComponents() {
+ super.setUpUiComponents();
+ findViewById(R.id.sortContainer).setVisibility(View.GONE);
+ }
+
// --- task adapter
/**
diff --git a/astrid/src/com/todoroo/astrid/activity/TaskListActivity.java b/astrid/src/com/todoroo/astrid/activity/TaskListActivity.java
index ff36bf305..734c74ded 100644
--- a/astrid/src/com/todoroo/astrid/activity/TaskListActivity.java
+++ b/astrid/src/com/todoroo/astrid/activity/TaskListActivity.java
@@ -137,7 +137,6 @@ public class TaskListActivity extends ListActivity implements OnScrollListener,
protected static final int MENU_LISTS_ID = Menu.FIRST + 1;
protected static final int MENU_ADDONS_ID = Menu.FIRST + 2;
protected static final int MENU_SETTINGS_ID = Menu.FIRST + 3;
- protected static final int MENU_SORT_ID = Menu.FIRST + 4;
protected static final int MENU_SYNC_ID = Menu.FIRST + 5;
protected static final int MENU_SUPPORT_ID = Menu.FIRST + 6;
protected static final int MENU_ADDON_INTENT_ID = Menu.FIRST + 7;
@@ -301,8 +300,6 @@ public class TaskListActivity extends ListActivity implements OnScrollListener,
isFilter = true;
} else {
filter = CoreFilterExposer.buildInboxFilter(getResources());
- //findViewById(R.id.headerLogo).setVisibility(View.VISIBLE);
- //findViewById(R.id.listLabel).setVisibility(View.GONE);
isFilter = false;
}
@@ -331,12 +328,6 @@ public class TaskListActivity extends ListActivity implements OnScrollListener,
MenuItem item;
- if(!(this instanceof DraggableTaskListActivity)) {
- item = menu.add(Menu.NONE, MENU_SORT_ID, Menu.NONE,
- R.string.TLA_menu_sort);
- item.setIcon(android.R.drawable.ic_menu_sort_by_size);
- }
-
addSyncRefreshMenuItem(menu);
item = menu.add(Menu.NONE, MENU_LISTS_ID, Menu.NONE,
@@ -377,7 +368,7 @@ public class TaskListActivity extends ListActivity implements OnScrollListener,
return true;
}
- private void setUpUiComponents() {
+ protected void setUpUiComponents() {
((ImageView)findViewById(R.id.back)).setOnClickListener(new OnClickListener() {
public void onClick(View v) {
Preferences.setBoolean(R.string.p_showed_lists_help, true);
@@ -385,6 +376,16 @@ public class TaskListActivity extends ListActivity implements OnScrollListener,
}
});
+ findViewById(R.id.sort_settings).setOnClickListener(new OnClickListener() {
+ @Override
+ public void onClick(View v) {
+ StatisticsService.reportEvent(StatisticsConstants.TLA_MENU_SORT);
+ AlertDialog dialog = SortSelectionActivity.createDialog(TaskListActivity.this,
+ TaskListActivity.this, sortFlags, sortSort);
+ dialog.show();
+ }
+ });
+
// set listener for quick-changing task priority
getListView().setOnKeyListener(new OnKeyListener() {
@Override
@@ -1204,12 +1205,6 @@ public class TaskListActivity extends ListActivity implements OnScrollListener,
intent = new Intent(this, EditPreferences.class);
startActivityForResult(intent, ACTIVITY_SETTINGS);
return true;
- case MENU_SORT_ID:
- StatisticsService.reportEvent(StatisticsConstants.TLA_MENU_SORT);
- AlertDialog dialog = SortSelectionActivity.createDialog(this,
- this, sortFlags, sortSort);
- dialog.show();
- return true;
case MENU_SYNC_ID:
StatisticsService.reportEvent(StatisticsConstants.TLA_MENU_SYNC);
performSyncAction();