From 4f61c9b5a47c065503bc57e03ebb5ee293550400 Mon Sep 17 00:00:00 2001 From: Tim Su Date: Thu, 1 Jul 2010 13:45:42 -0700 Subject: [PATCH 1/3] Fixed various minor usability issues. A lot more smooth now. --- astrid/AndroidManifest.xml | 4 +- astrid/astrid.launch | 25 +++++ .../andlib/utility/DialogUtilities.java | 5 +- astrid/default.properties | 2 +- .../astrid/filters/CoreFilterExposer.java | 5 +- ...tailExposer.java => TagDetailExposer.java} | 2 +- ...lterExposer.java => TagFilterExposer.java} | 2 +- .../com/todoroo/astrid/tags/TagService.java | 24 +++-- astrid/res/layout/task_row.xml | 5 +- astrid/res/values/strings-3.0.xml | 7 +- astrid/res/values/strings-filters.xml | 3 + astrid/res/values/styles-3.0.xml | 7 +- .../astrid/activity/FilterListActivity.java | 92 +++++++++++++------ .../astrid/activity/TaskEditActivity.java | 13 +-- .../astrid/activity/TaskListActivity.java | 27 +++++- .../todoroo/astrid/adapter/TaskAdapter.java | 13 +-- astrid/src/com/todoroo/astrid/model/Task.java | 2 +- .../service/AstridDependencyInjector.java | 1 + 18 files changed, 169 insertions(+), 70 deletions(-) create mode 100644 astrid/astrid.launch rename astrid/plugin-src/com/todoroo/astrid/tags/{DetailExposer.java => TagDetailExposer.java} (96%) rename astrid/plugin-src/com/todoroo/astrid/tags/{FilterExposer.java => TagFilterExposer.java} (98%) diff --git a/astrid/AndroidManifest.xml b/astrid/AndroidManifest.xml index 0e04268e3..1cc711c5f 100644 --- a/astrid/AndroidManifest.xml +++ b/astrid/AndroidManifest.xml @@ -182,13 +182,13 @@ - + - + diff --git a/astrid/astrid.launch b/astrid/astrid.launch new file mode 100644 index 000000000..cc219d422 --- /dev/null +++ b/astrid/astrid.launch @@ -0,0 +1,25 @@ + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/astrid/common-src/com/todoroo/andlib/utility/DialogUtilities.java b/astrid/common-src/com/todoroo/andlib/utility/DialogUtilities.java index 32d5a94a5..8d6f3e4f6 100644 --- a/astrid/common-src/com/todoroo/andlib/utility/DialogUtilities.java +++ b/astrid/common-src/com/todoroo/andlib/utility/DialogUtilities.java @@ -15,6 +15,9 @@ public class DialogUtilities { @Autowired public Integer informationDialogTitleResource; + @Autowired + public Integer confirmDialogTitleResource; + public DialogUtilities() { DependencyInjectionService.getInstance().inject(this); } @@ -32,7 +35,7 @@ public class DialogUtilities { activity.runOnUiThread(new Runnable() { public void run() { new AlertDialog.Builder(activity) - .setTitle(informationDialogTitleResource) + .setTitle(confirmDialogTitleResource) .setMessage(text) .setView(view) .setIcon(android.R.drawable.ic_dialog_alert) diff --git a/astrid/default.properties b/astrid/default.properties index 694331ea4..c5d5335ee 100644 --- a/astrid/default.properties +++ b/astrid/default.properties @@ -10,5 +10,5 @@ # Indicates whether an apk should be generated for each density. split.density=false # Project target. -target=android-7 +target=android-8 apk-configurations= diff --git a/astrid/plugin-src/com/todoroo/astrid/filters/CoreFilterExposer.java b/astrid/plugin-src/com/todoroo/astrid/filters/CoreFilterExposer.java index 24c009b32..089261793 100644 --- a/astrid/plugin-src/com/todoroo/astrid/filters/CoreFilterExposer.java +++ b/astrid/plugin-src/com/todoroo/astrid/filters/CoreFilterExposer.java @@ -39,7 +39,8 @@ public final class CoreFilterExposer extends BroadcastReceiver { Filter all = new Filter(CorePlugin.pluginIdentifier, r.getString(R.string.BFE_All), r.getString(R.string.BFE_All), - new QueryTemplate().orderBy(Order.desc(Task.MODIFICATION_DATE)), + new QueryTemplate().where(Criterion.not(TaskCriteria.isDeleted())). + orderBy(Order.desc(Task.MODIFICATION_DATE)), null); all.listingIcon = ((BitmapDrawable)r.getDrawable(R.drawable.filter_all)).getBitmap(); @@ -59,7 +60,7 @@ public final class CoreFilterExposer extends BroadcastReceiver { @SuppressWarnings("nls") public static Filter buildInboxFilter(Resources r) { Filter inbox = new Filter(CorePlugin.pluginIdentifier, r.getString(R.string.BFE_Inbox), - r.getString(R.string.BFE_Inbox), + r.getString(R.string.BFE_Inbox_title), new QueryTemplate().where(Criterion.and(TaskCriteria.isActive(), TaskCriteria.isVisible(DateUtilities.now()))).orderBy( Order.asc(Functions.caseStatement(Task.DUE_DATE.eq(0), diff --git a/astrid/plugin-src/com/todoroo/astrid/tags/DetailExposer.java b/astrid/plugin-src/com/todoroo/astrid/tags/TagDetailExposer.java similarity index 96% rename from astrid/plugin-src/com/todoroo/astrid/tags/DetailExposer.java rename to astrid/plugin-src/com/todoroo/astrid/tags/TagDetailExposer.java index d1399a05e..dcd08bcbd 100644 --- a/astrid/plugin-src/com/todoroo/astrid/tags/DetailExposer.java +++ b/astrid/plugin-src/com/todoroo/astrid/tags/TagDetailExposer.java @@ -17,7 +17,7 @@ import com.todoroo.astrid.api.TaskDetail; * @author Tim Su * */ -public class DetailExposer extends BroadcastReceiver { +public class TagDetailExposer extends BroadcastReceiver { private static TagService tagService = null; diff --git a/astrid/plugin-src/com/todoroo/astrid/tags/FilterExposer.java b/astrid/plugin-src/com/todoroo/astrid/tags/TagFilterExposer.java similarity index 98% rename from astrid/plugin-src/com/todoroo/astrid/tags/FilterExposer.java rename to astrid/plugin-src/com/todoroo/astrid/tags/TagFilterExposer.java index 333086f64..ca0a96c24 100644 --- a/astrid/plugin-src/com/todoroo/astrid/tags/FilterExposer.java +++ b/astrid/plugin-src/com/todoroo/astrid/tags/TagFilterExposer.java @@ -25,7 +25,7 @@ import com.todoroo.astrid.tags.TagService.Tag; * @author Tim Su * */ -public class FilterExposer extends BroadcastReceiver { +public class TagFilterExposer extends BroadcastReceiver { private TagService tagService; diff --git a/astrid/plugin-src/com/todoroo/astrid/tags/TagService.java b/astrid/plugin-src/com/todoroo/astrid/tags/TagService.java index c523155c3..b39a8471d 100644 --- a/astrid/plugin-src/com/todoroo/astrid/tags/TagService.java +++ b/astrid/plugin-src/com/todoroo/astrid/tags/TagService.java @@ -2,8 +2,8 @@ package com.todoroo.astrid.tags; import java.util.ArrayList; -import com.todoroo.andlib.data.TodorooCursor; import com.todoroo.andlib.data.Property.CountProperty; +import com.todoroo.andlib.data.TodorooCursor; import com.todoroo.andlib.service.Autowired; import com.todoroo.andlib.service.DependencyInjectionService; import com.todoroo.andlib.sql.Criterion; @@ -112,7 +112,7 @@ public class TagService { * Return tags on the given task * * @param taskId - * @return empty array if no tags, otherwise array + * @return cursor. PLEASE CLOSE THE CURSOR! */ public TodorooCursor getTags(long taskId) { Query query = Query.select(Metadata.VALUE).where(Criterion.and(MetadataCriteria.withKey(KEY), @@ -129,14 +129,18 @@ public class TagService { public String getTagsAsString(long taskId) { StringBuilder tagBuilder = new StringBuilder(); TodorooCursor tags = getTags(taskId); - int length = tags.getCount(); - Metadata metadata = new Metadata(); - for (int i = 0; i < length; i++) { - tags.moveToNext(); - metadata.readFromCursor(tags); - tagBuilder.append(metadata.getValue(Metadata.VALUE)); - if (i < length - 1) - tagBuilder.append(", "); + try { + int length = tags.getCount(); + Metadata metadata = new Metadata(); + for (int i = 0; i < length; i++) { + tags.moveToNext(); + metadata.readFromCursor(tags); + tagBuilder.append(metadata.getValue(Metadata.VALUE)); + if (i < length - 1) + tagBuilder.append(", "); + } + } finally { + tags.close(); } return tagBuilder.toString(); } diff --git a/astrid/res/layout/task_row.xml b/astrid/res/layout/task_row.xml index 03cbaff4b..80270f383 100644 --- a/astrid/res/layout/task_row.xml +++ b/astrid/res/layout/task_row.xml @@ -15,7 +15,7 @@ diff --git a/astrid/res/values/strings-3.0.xml b/astrid/res/values/strings-3.0.xml index 3470144eb..aceefdce9 100644 --- a/astrid/res/values/strings-3.0.xml +++ b/astrid/res/values/strings-3.0.xml @@ -201,8 +201,11 @@ button: add task & go to the edit page. Help - - Create Shortcut: + + Create Shortcut + + + Name of shortcut: Search For Tasks diff --git a/astrid/res/values/strings-filters.xml b/astrid/res/values/strings-filters.xml index 374fad2fe..d8921a5e0 100644 --- a/astrid/res/values/strings-filters.xml +++ b/astrid/res/values/strings-filters.xml @@ -6,6 +6,9 @@ Inbox + + + Astrid: Inbox Completed diff --git a/astrid/res/values/styles-3.0.xml b/astrid/res/values/styles-3.0.xml index 815405ffd..fd595df2e 100644 --- a/astrid/res/values/styles-3.0.xml +++ b/astrid/res/values/styles-3.0.xml @@ -32,12 +32,17 @@ + +