From 02958e46e657d190bdd8d19ba3f8cc3874296e6a Mon Sep 17 00:00:00 2001
From: Alex Baker <alex@tasks.org>
Date: Fri, 19 May 2023 23:47:12 -0500
Subject: [PATCH] Fix duplicated subtasks

---
 .../java/org/tasks/ui/TaskEditViewModel.kt    | 28 +++++++++----------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/app/src/main/java/org/tasks/ui/TaskEditViewModel.kt b/app/src/main/java/org/tasks/ui/TaskEditViewModel.kt
index f68d38861..76af6e8fb 100644
--- a/app/src/main/java/org/tasks/ui/TaskEditViewModel.kt
+++ b/app/src/main/java/org/tasks/ui/TaskEditViewModel.kt
@@ -293,6 +293,20 @@ class TaskEditViewModel @Inject constructor(
             task.modificationDate = currentTimeMillis()
         }
 
+        if (!task.hasStartDate()) {
+            selectedAlarms.value = selectedAlarms.value.filterNot { a -> a.type == TYPE_REL_START }
+        }
+        if (!task.hasDueDate()) {
+            selectedAlarms.value = selectedAlarms.value.filterNot { a -> a.type == TYPE_REL_END }
+        }
+
+        taskDao.save(task, null)
+
+        if (isNew || originalList != selectedList.value) {
+            task.parent = 0
+            taskMover.move(listOf(task.id), selectedList.value)
+        }
+
         for (subtask in newSubtasks.value) {
             if (Strings.isNullOrEmpty(subtask.title)) {
                 continue
@@ -324,20 +338,6 @@ class TaskEditViewModel @Inject constructor(
             }
         }
 
-        if (!task.hasStartDate()) {
-            selectedAlarms.value = selectedAlarms.value.filterNot { a -> a.type == TYPE_REL_START }
-        }
-        if (!task.hasDueDate()) {
-            selectedAlarms.value = selectedAlarms.value.filterNot { a -> a.type == TYPE_REL_END }
-        }
-
-        taskDao.save(task, null)
-
-        if (isNew || originalList != selectedList.value) {
-            task.parent = 0
-            taskMover.move(listOf(task.id), selectedList.value)
-        }
-
         if (
             selectedAlarms.value.toHashSet() != originalAlarms.toHashSet() ||
             (isNew && selectedAlarms.value.isNotEmpty())