From 0155d9783e0076d457a67723c69a8c381b663603 Mon Sep 17 00:00:00 2001
From: Sam Bosley <sboz88@gmail.com>
Date: Thu, 14 Mar 2013 13:11:28 -0700
Subject: [PATCH] Cleaner code

---
 .../astrid/actfm/sync/messages/ChangesHappened.java | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/astrid/plugin-src/com/todoroo/astrid/actfm/sync/messages/ChangesHappened.java b/astrid/plugin-src/com/todoroo/astrid/actfm/sync/messages/ChangesHappened.java
index da7e16b30..0d94c53df 100644
--- a/astrid/plugin-src/com/todoroo/astrid/actfm/sync/messages/ChangesHappened.java
+++ b/astrid/plugin-src/com/todoroo/astrid/actfm/sync/messages/ChangesHappened.java
@@ -133,20 +133,13 @@ public class ChangesHappened<TYPE extends RemoteModel, OE extends OutstandingEnt
                 } else if (NameMaps.ATTACHMENT_ADDED_COLUMN.equals(localColumn)) {
                     serverColumn = NameMaps.ATTACHMENT_ADDED_COLUMN;
                     JSONObject fileJson = getFileJson(change.getValue(OutstandingEntry.VALUE_STRING_PROPERTY));
-                    if (fileJson == null) {
+                    String name = fileJson == null ? null : addToEntityFromFileJson(entity, fileJson, uploadCounter);
+                    if (name == null) {
                         PluginServices.getTaskAttachmentDao().delete(id);
                         PluginServices.getTaskAttachmentOutstandingDao().deleteWhere(TaskAttachmentOutstanding.ENTITY_ID_PROPERTY.eq(id));
                         return null;
-                    } else { // JSON has valid file path
-                        String name = addToEntityFromFileJson(entity, fileJson, uploadCounter);
-                        if (name != null) {
-                            changeJson.put("value", name);
-                        } else {
-                            PluginServices.getTaskAttachmentDao().delete(id);
-                            PluginServices.getTaskAttachmentOutstandingDao().deleteWhere(TaskAttachmentOutstanding.ENTITY_ID_PROPERTY.eq(id));
-                            return null;
-                        }
                     }
+                    changeJson.put("value", name);
                 } else {
                     Property<?> localProperty = NameMaps.localColumnNameToProperty(table, localColumn);
                     if (localProperty == null)