You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/control/controlclient
Avery Pennarun 08acb502e5 Add tstest.PanicOnLog(), and fix various problems detected by this.
If a test calls log.Printf, 'go test' horrifyingly rearranges the
output to no longer be in chronological order, which makes debugging
virtually impossible. Let's stop that from happening by making
log.Printf panic if called from any module, no matter how deep, during
tests.

This required us to change the default error handler in at least one
http.Server, as well as plumbing a bunch of logf functions around,
especially in magicsock and wgengine, but also in logtail and backoff.

To add insult to injury, 'go test' also rearranges the output when a
parent test has multiple sub-tests (all the sub-test's t.Logf is always
printed after all the parent tests t.Logf), so we need to screw around
with a special Logf that can point at the "current" t (current_t.Logf)
in some places. Probably our entire way of using subtests is wrong,
since 'go test' would probably like to run them all in parallel if you
called t.Parallel(), but it definitely can't because the're all
manipulating the shared state created by the parent test. They should
probably all be separate toplevel tests instead, with common
setup/teardown logic. But that's a job for another time.

Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>
4 years ago
..
auto.go Add tstest.PanicOnLog(), and fix various problems detected by this. 4 years ago
auto_test.go Add tstest.PanicOnLog(), and fix various problems detected by this. 4 years ago
controlclient_test.go types/structs: add structs.Incomparable annotation, use it where applicable 4 years ago
direct.go types/structs: add structs.Incomparable annotation, use it where applicable 4 years ago
direct_test.go {ipn,control/controlclient}/tests: pass a logf function to control.New(). 4 years ago
filter.go Appease the "missing copyright header" check. 4 years ago
netmap.go cmd/relaynode: delete it! 4 years ago
persist_test.go ipn: implement Prefs.Equals efficiently. 4 years ago