You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/wgengine
Jonathan Nobels 3e89068792
net/netmon, wgengine/userspace: purge ChangeDelta.Major and address TODOs (#17823)
updates tailscale/corp#33891

Addresses several older the TODO's in netmon.  This removes the 
Major flag precomputes the ChangeDelta state, rather than making
consumers of ChangeDeltas sort that out themselves.   We're also seeing
a lot of ChangeDelta's being flagged as "Major" when they are
not interesting, triggering rebinds in wgengine that are not needed.  This
cleans that up and adds a host of additional tests.

The dependencies are cleaned, notably removing dependency on netmon
itself for calculating what is interesting, and what is not.  This includes letting
individual platforms set a bespoke global "IsInterestingInterface"
function.  This is only used on Darwin.

RebindRequired now roughly follows how "Major" was historically
calculated but includes some additional checks for various
uninteresting events such as changes in interface addresses that
shouldn't trigger a rebind.  This significantly reduces thrashing (by
roughly half on Darwin clients which switching between nics).   The individual
values that we roll  into RebindRequired are also exposed so that
components consuming netmap.ChangeDelta can ask more
targeted questions.

Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
3 days ago
..
bench types/netmap: remove PrivateKey from NetworkMap 1 month ago
filter wgengine/filter: add check for unknown proto 11 months ago
magicsock net/{packet,tstun},wgengine: update disco key when receiving via TSMP (#18158) 1 week ago
netlog wgengine/netlog: strip dot suffix from node name (#17954) 1 month ago
netstack all: rename variables with lowercase-l/uppercase-I 1 month ago
router all: rename variables with lowercase-l/uppercase-I 1 month ago
wgcfg types/netmap: remove PrivateKey from NetworkMap 1 month ago
wgint wgengine{,/wgint}: add wgint.Peer wrapper type, add to wgengine.Engine 2 years ago
wglog all: use Go 1.22 range-over-int 2 years ago
winnet all: add test for package comments, fix, add comments as needed 1 year ago
mem_ios.go all: update copyright and license headers 3 years ago
pendopen.go wgengine: stop importing flowtrack when unused 3 months ago
pendopen_omit.go wgengine: stop importing flowtrack when unused 3 months ago
userspace.go net/netmon, wgengine/userspace: purge ChangeDelta.Major and address TODOs (#17823) 3 days ago
userspace_ext_test.go health,ipn/ipnlocal: introduce eventbus in heath.Tracker (#17085) 3 months ago
userspace_test.go net/tstun: add TSMPDiscoAdvertisement to TSMPPing (#17995) 4 weeks ago
watchdog.go ipn/ipnlocal: remove all the weird locking (LockedOnEntry, UnlockEarly, etc) 1 month ago
watchdog_omit.go ipn/ipnlocal, engine: avoid runtime/pprof with two usages of ts_omit_debug 3 months ago
watchdog_test.go health,ipn/ipnlocal: introduce eventbus in heath.Tracker (#17085) 3 months ago
wgengine.go ipn/ipnlocal: remove all the weird locking (LockedOnEntry, UnlockEarly, etc) 1 month ago