You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/ipn/ipnlocal
Brad Fitzpatrick e968b0ecd7 cmd/tailscale,controlclient,ipnlocal: fix 'up', deflake tests more
The CLI's "up" is kinda chaotic and LocalBackend.Start is kinda
chaotic and they both need to be redone/deleted (respectively), but
this fixes some buggy behavior meanwhile. We were previously calling
StartLoginInteractive (to start the controlclient's RegisterRequest)
redundantly in some cases, causing test flakes depending on timing and
up's weird state machine.

We only need to call StartLoginInteractive in the client if Start itself
doesn't. But Start doesn't tell us that. So cheat a bit and a put the
information about whether there's a current NodeKey in the ipn.Status.
It used to be accessible over LocalAPI via GetPrefs as a private key but
we removed that for security. But a bool is fine.

So then only call StartLoginInteractive if that bool is false and don't
do it in the WatchIPNBus loop.

Fixes #12028
Updates #12042

Change-Id: I0923c3f704a9d6afd825a858eb9a63ca7c1df294
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
2 years ago
..
testdata ipn/ipnlocal: fix the path for writing cert files (#7203) 3 years ago
breaktcp_darwin.go cmd/tailscale: add debug commands to break connections 2 years ago
breaktcp_linux.go cmd/tailscale: add debug commands to break connections 2 years ago
c2n.go ipn/ipnlocal,ssh/tailssh: reject c2n /update if SSH conns are active (#11820) 2 years ago
c2n_pprof.go ipn/ipnlocal: add c2n /debug/pprof/allocs endpoint 2 years ago
c2n_test.go util/cmpx: delete now that we're using Go 1.22 2 years ago
cert.go ipn/ipnlocal: remove ancient transition mechanism for https certs 2 years ago
cert_js.go ipn/ipnlocal: add c2n method to check on TLS cert fetch status 2 years ago
cert_test.go all: use Go 1.21 slices, maps instead of x/exp/{slices,maps} 2 years ago
dnsconfig_test.go util/cmpx: delete now that we're using Go 1.22 2 years ago
drive.go ipn/ipnlocal: reuse transport across Taildrive remotes 2 years ago
expiry.go ssh/tailssh: use control server time instead of local time 2 years ago
expiry_test.go types/netmap, all: make NetworkMap.SelfNode a tailcfg.NodeView 2 years ago
local.go cmd/tailscale,controlclient,ipnlocal: fix 'up', deflake tests more 2 years ago
local_test.go ipn/ipnlocal, all: plumb health trackers in tests 2 years ago
loglines_test.go ipn/ipnlocal, all: plumb health trackers in tests 2 years ago
network-lock.go ipn/{ipnlocal,localapi},wgengine{,/magicsock}: plumb health.Tracker 2 years ago
network-lock_test.go ipn/ipnlocal: plumb health.Tracker into profileManager constructor 2 years ago
peerapi.go net/{interfaces,netmon}, all: merge net/interfaces package into net/netmon 2 years ago
peerapi_h2c.go all: update copyright and license headers 3 years ago
peerapi_macios_ext.go net/netmon, add: add netmon.State type alias of interfaces.State 2 years ago
peerapi_test.go ipn/ipnlocal, all: plumb health trackers in tests 2 years ago
profiles.go ipn/ipnlocal: set default NoStatefulFiltering in ipn.NewPrefs (#12031) 2 years ago
profiles_notwindows.go ipn/ipnlocal: fix profile duplication 2 years ago
profiles_test.go ipn/ipnlocal: set default NoStatefulFiltering in ipn.NewPrefs (#12031) 2 years ago
profiles_windows.go ipn/ipnlocal: set default NoStatefulFiltering in ipn.NewPrefs (#12031) 2 years ago
serve.go all: use Go 1.22 range-over-int 2 years ago
serve_test.go ipn/ipnlocal, all: plumb health trackers in tests 2 years ago
ssh.go ipnlocal: log failure to get ssh host keys 2 years ago
ssh_stub.go ipnlocal: log failure to get ssh host keys 2 years ago
ssh_test.go ipn/ipnlocal: plumb health.Tracker into profileManager constructor 2 years ago
state_test.go ipn/ipnlocal, all: plumb health trackers in tests 2 years ago
taildrop.go ipn/localapi: add support for multipart POST to file-put 2 years ago
web_client.go all: remove LenIter, use Go 1.22 range-over-int instead 2 years ago
web_client_stub.go ipn/ipnlocal: add mutex to webClient struct 2 years ago