You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/wgengine/magicsock
Joe Tsai 2e5d08ec4f
net/connstats: invert network logging data flow (#6272)
Previously, tstun.Wrapper and magicsock.Conn managed their
own statistics data structure and relied on an external call to
Extract to extract (and reset) the statistics.
This makes it difficult to ensure a maximum size on the statistics
as the caller has no introspection into whether the number
of unique connections is getting too large.

Invert the control flow such that a *connstats.Statistics
is registered with tstun.Wrapper and magicsock.Conn.
Methods on non-nil *connstats.Statistics are called for every packet.
This allows the implementation of connstats.Statistics (in the future)
to better control when it needs to flush to ensure
bounds on maximum sizes.

The value registered into tstun.Wrapper and magicsock.Conn could
be an interface, but that has two performance detriments:

1. Method calls on interface values are more expensive since
they must go through a virtual method dispatch.

2. The implementation would need a sync.Mutex to protect the
statistics value instead of using an atomic.Pointer.

Given that methods on constats.Statistics are called for every packet,
we want reduce the CPU cost on this hot path.

Signed-off-by: Joe Tsai <joetsai@digital-static.net>
2 years ago
..
debughttp.go wgengine/magicsock: fix panic in http debug server 2 years ago
debugknobs.go all: remove old +build tags 2 years ago
debugknobs_stubs.go all: remove old +build tags 2 years ago
discopingpurpose_string.go wgengine/magicsock: make discoPingPurpose a stringer 4 years ago
magicsock.go net/connstats: invert network logging data flow (#6272) 2 years ago
magicsock_default.go all: remove old +build tags 2 years ago
magicsock_linux.go wgengine/magicsock: set UDP socket buffer sizes to 7MB 2 years ago
magicsock_test.go net/connstats: invert network logging data flow (#6272) 2 years ago
magicsock_unix_test.go all: remove old +build tags 2 years ago
pathfinder.go wgengine/magicsock: set up pathfinder (#5994) 2 years ago