You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/wgengine/magicsock
Amal Bansode 6de5b01e04
ipn/localapi: stop logging "broken pipe" errors (#18487)
The Tailscale CLI has some methods to watch the IPN bus for
messages, say, the current netmap (`tailscale debug netmap`).
The Tailscale daemon supports this using a streaming HTTP
response. Sometimes, the client can close its connection
abruptly -- due to an interruption, or in the case of `debug netmap`,
intentionally after consuming one message.

If the server daemon is writing a response as the client closes
its end of the socket, the daemon typically encounters a "broken pipe"
error. The "Watch IPN Bus" handler currently logs such errors after
they're propagated by a JSON encoding/writer helper.

Since the Tailscale CLI nominally closes its socket with the daemon
in this slightly ungraceful way (viz. `debug netmap`), stop logging
these broken pipe errors as far as possible. This will help avoid
confounding users when they scan backend logs.

Updates #18477

Signed-off-by: Amal Bansode <amal@tailscale.com>
3 days ago
..
blockforever_conn.go all: remove AUTHORS file and references to it 6 days ago
debughttp.go all: remove AUTHORS file and references to it 6 days ago
debugknobs.go all: remove AUTHORS file and references to it 6 days ago
debugknobs_stubs.go all: remove AUTHORS file and references to it 6 days ago
derp.go all: remove AUTHORS file and references to it 6 days ago
derp_test.go all: remove AUTHORS file and references to it 6 days ago
disco_atomic.go all: remove AUTHORS file and references to it 6 days ago
disco_atomic_test.go all: remove AUTHORS file and references to it 6 days ago
discopingpurpose_string.go all: remove AUTHORS file and references to it 6 days ago
endpoint.go all: remove AUTHORS file and references to it 6 days ago
endpoint_default.go all: remove AUTHORS file and references to it 6 days ago
endpoint_stub.go all: remove AUTHORS file and references to it 6 days ago
endpoint_test.go all: remove AUTHORS file and references to it 6 days ago
endpoint_tracker.go all: remove AUTHORS file and references to it 6 days ago
endpoint_tracker_test.go all: remove AUTHORS file and references to it 6 days ago
magicsock.go all: remove AUTHORS file and references to it 6 days ago
magicsock_default.go all: remove AUTHORS file and references to it 6 days ago
magicsock_linux.go all: remove AUTHORS file and references to it 6 days ago
magicsock_linux_test.go all: remove AUTHORS file and references to it 6 days ago
magicsock_notplan9.go ipn/localapi: stop logging "broken pipe" errors (#18487) 3 days ago
magicsock_plan9.go all: remove AUTHORS file and references to it 6 days ago
magicsock_test.go all: remove AUTHORS file and references to it 6 days ago
peermap.go all: remove AUTHORS file and references to it 6 days ago
peermap_test.go all: remove AUTHORS file and references to it 6 days ago
peermtu.go all: remove AUTHORS file and references to it 6 days ago
peermtu_darwin.go all: remove AUTHORS file and references to it 6 days ago
peermtu_linux.go all: remove AUTHORS file and references to it 6 days ago
peermtu_stubs.go all: remove AUTHORS file and references to it 6 days ago
peermtu_unix.go all: remove AUTHORS file and references to it 6 days ago
rebinding_conn.go all: remove AUTHORS file and references to it 6 days ago
relaymanager.go all: remove AUTHORS file and references to it 6 days ago
relaymanager_test.go all: remove AUTHORS file and references to it 6 days ago