You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/cmd/containerboot
Irbe Krumina 5b670eb3a5
cmd/containerboot: allow setting --accept-dns via TS_EXTRA_ARGS again (#16129)
In 1.84 we made 'tailscale set'/'tailscale up' error out if duplicate
command line flags are passed.
This broke some container configurations as we have two env vars that
can be used to set --accept-dns flag:
- TS_ACCEPT_DNS- specifically for --accept-dns
- TS_EXTRA_ARGS- accepts any arbitrary 'tailscale up'/'tailscale set'
flag.

We default TS_ACCEPT_DNS to false (to make the container behaviour more
declarative), which with the new restrictive CLI behaviour resulted in
failure for users who had set --accept-dns via TS_EXTRA_ARGS as the flag would be
provided twice.

This PR re-instates the previous behaviour by checking if TS_EXTRA_ARGS
contains --accept-dns flag and if so using its value to override TS_ACCEPT_DNS.

Updates tailscale/tailscale#16108

Signed-off-by: Irbe Krumina <irbe@tailscale.com>
6 months ago
..
certs.go cmd/{k8s-operator,containerboot}: check TLS cert before advertising VIPService (#15427) 8 months ago
certs_test.go cmd/containerboot: manage HA Ingress TLS certs from containerboot (#15303) 9 months ago
egressservices.go cmd/containerboot,kube/ingressservices: proxy VIPService TCP/UDP traffic to cluster Services (#15897) 7 months ago
egressservices_test.go cmd/containerboot,kube/ingressservices: proxy VIPService TCP/UDP traffic to cluster Services (#15897) 7 months ago
forwarding.go cmd/containerboot,util/linuxfw: create a SNAT rule for dst/src only once, clean up if needed (#13658) 1 year ago
healthz.go cmd/{containerboot,k8s-operator},kube/kubetypes: unadvertise ingress services on shutdown (#15451) 8 months ago
ingressservices.go cmd/containerboot,kube/ingressservices: proxy VIPService TCP/UDP traffic to cluster Services (#15897) 7 months ago
ingressservices_test.go cmd/containerboot,kube/ingressservices: proxy VIPService TCP/UDP traffic to cluster Services (#15897) 7 months ago
kube.go cmd/containerboot: wait for consistent state on shutdown (#14263) 10 months ago
kube_test.go cmd/containerboot: wait for consistent state on shutdown (#14263) 10 months ago
main.go cmd/containerboot,kube/ingressservices: proxy VIPService TCP/UDP traffic to cluster Services (#15897) 7 months ago
main_test.go cmd/containerboot: allow setting --accept-dns via TS_EXTRA_ARGS again (#16129) 6 months ago
metrics.go cmd/{containerboot,k8s-operator},kube/kubetypes: unadvertise ingress services on shutdown (#15451) 8 months ago
serve.go cmd/containerboot,kube/ingressservices: proxy VIPService TCP/UDP traffic to cluster Services (#15897) 7 months ago
serve_test.go cmd/containerboot: manage HA Ingress TLS certs from containerboot (#15303) 9 months ago
services.go cmd/containerboot,kube/ingressservices: proxy VIPService TCP/UDP traffic to cluster Services (#15897) 7 months ago
settings.go cmd/containerboot: allow setting --accept-dns via TS_EXTRA_ARGS again (#16129) 6 months ago
settings_test.go cmd/containerboot: allow setting --accept-dns via TS_EXTRA_ARGS again (#16129) 6 months ago
tailscaled.go cmd/containerboot: speed up tests (#14883) 8 months ago
test_tailscale.sh cmd/containerboot: make a tests table, add more tests. 3 years ago
test_tailscaled.sh cmd/containerboot: avoid leaking bash scripts after test runs 2 years ago