You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/control/controlclient
Brad Fitzpatrick 171ec9f8f4 control/{controlknobs,controlclient}: simplify knobs API, fix controlclient crash
From integration tests elsewhere:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x70 pc=0x845c9b]

goroutine 226 [running]:
tailscale.com/control/controlclient.(*Direct).sendMapRequest(0xc00053e1e0, 0x16670f0, 0xc000353780, 0xffffffffffffffff, 0xc0003e5f10, 0x0, 0x0)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:803 +0x19bb
tailscale.com/control/controlclient.(*Direct).PollNetMap(...)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:574
tailscale.com/control/controlclient.(*Auto).mapRoutine(0xc00052a1e0)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:464 +0x571
created by tailscale.com/control/controlclient.(*Auto).Start
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:151 +0x65
exit status 2

Also remove types/opt.Bool API addition which is now unnecessary.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
3 years ago
..
auto.go ipn/{ipnlocal,localapi}, control/controlclient: add SetDNS localapi 4 years ago
client.go ipn/{ipnlocal,localapi}, control/controlclient: add SetDNS localapi 4 years ago
controlclient_test.go ipnlocal: don't assume NeedsLogin immediately after StartLogout(). 4 years ago
debug.go tailcfg, control/controlclient: add goroutine dump debug feature 4 years ago
debug_test.go tailcfg, control/controlclient: add goroutine dump debug feature 4 years ago
direct.go control/{controlknobs,controlclient}: simplify knobs API, fix controlclient crash 3 years ago
direct_test.go all: adapt to opaque netaddr types 4 years ago
hostinfo_linux.go hostinfo: add hostinfo package, move stuff out of controlclient 4 years ago
hostinfo_windows.go control/controlclient: cache Windows version 4 years ago
map.go control/controlclient: add debug knob to force node to only IPv6 self addr 3 years ago
map_test.go tailcfg, control/controlclient: accept nil MapResponse.Node (mapver 18) 4 years ago
sign.go control/controlclient: sign RegisterRequest (#1549) 4 years ago
sign_supported.go control/controlclient: use our fork of certstore 4 years ago
sign_unsupported.go control/controlclient: sign RegisterRequest (#1549) 4 years ago
status.go ipnlocal: don't assume NeedsLogin immediately after StartLogout(). 4 years ago