You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Joe Tsai d32700c7b2 util/deephash: specialize for netip.Addr and drop AppendTo support (#5402) ... There are 5 types that we care about that implement AppendTo: key.DiscoPublic key.NodePublic netip.Prefix netipx.IPRange netip.Addr The key types are thin wrappers around [32]byte and are memory hashable. The netip.Prefix and netipx.IPRange types are thin wrappers over netip.Addr and are hashable by default if netip.Addr is hashable. The netip.Addr type is the only one with a complex structure where the default behavior of deephash does not hash it correctly due to the presence of the intern.Value type. Drop support for AppendTo and instead add specialized hashing for netip.Addr that would be semantically equivalent to == on the netip.Addr values. The AppendTo support was already broken prior to this change. It was fully removed (intentionally or not) in #4870. It was partially restored in #4858 for the fast path, but still broken in the slow path. Just drop support for it altogether. This does mean we lack any ability for types to self-hash themselves. In the future we can add support for types that implement: interface { DeepHash() Sum } Test and fuzz cases were added for the relevant types that used to rely on the AppendTo method. FuzzAddr has been executed on 1 billion samples without issues. Signed-off-by: Joe Tsai joetsai@digital-static.net		2 years ago
..
cibuild	all: use cibuild.On	3 years ago
clientmetric	all: gofmt for Go 1.19	2 years ago
cloudenv	all: use syncs.AtomicValue	2 years ago
cmpver	util/cmpver: move into OSS from corp repo.	4 years ago
codegen	all: convert more code to use net/netip directly	2 years ago
deephash	util/deephash: specialize for netip.Addr and drop AppendTo support (#5402)	2 years ago
dnsname	all: use Go 1.18's strings.Cut	3 years ago
endian	all: gofmt with Go 1.17	3 years ago
groupmember	util/groupmember: remove redundant code (#4298)	3 years ago
hashx	util/hashx: move from sha256x (#5388)	2 years ago
jsonutil	all: use any instead of interface{}	3 years ago
lineread	util/lineread: add docs to Reader	4 years ago
mak	util/mak: move tailssh's mapSet into a new package for reuse elsewhere	3 years ago
multierr	all: gofmt for Go 1.19	2 years ago
must	util/must: rename Do->Get, add Do	2 years ago
osshare	all: gofmt with Go 1.17	3 years ago
pidowner	all: gofmt with Go 1.17	3 years ago
precompress	cmd/tsconnect,util/precompress: move precompression to its own package	2 years ago
racebuild	all: gofmt with Go 1.17	3 years ago
singleflight	all: gofmt for Go 1.19	2 years ago
strs	util/strs: add new package for string utility funcs	2 years ago
systemd	all: gofmt for Go 1.19	2 years ago
uniq	all: use any instead of interface{}	3 years ago
winutil	util/winutil: consolidate interface specific registry keys	2 years ago