You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/ipn/ipnlocal
Josh Bleecher Snyder 07c09f470d ipn/ipnlocal: do not shut down the backend halfway through TestStateMachine
LocalBackend.Shutdown's docs say:

> The backend can no longer be used after Shutdown returns.

Nevertheless, TestStateMachine blithely calls Shutdown, talks some smack,
and continues on, expecting things to work. Other uses of Shutdown
in the codebase are as intended.

Things mostly kinda work anyway, except that the wgengine.Engine has been
shut down, so calls to Reconfig fail. Those get logged:

> local.go:603: wgengine status error: engine closing; no status

but otherwise ignored.

However, the Reconfig failure caused one fewer call to pause/unpause
than normal. Now the assertCalls lines match the equivalent ones
earlier in the test.

I don't see an obvious correct replacement for Shutdown in the context
of this test; I'm not sure entirely what it is trying to accomplish.
It is possible that many of the tests remaining after the prior call
to Shutdown are now extraneous. They don't harm anything, though,
so err on the side of safety and leave them for now.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
3 years ago
..
dnsconfig_test.go ipn/ipnlocal: flesh out the dnsConfigForNetmap tests 3 years ago
local.go ipn/ipnlocal: fix minor typo in comment 3 years ago
local_test.go all: close fake userspace engines when tests complete 3 years ago
loglines_test.go all: close fake userspace engines when tests complete 3 years ago
peerapi.go all: adapt to opaque netaddr types 3 years ago
peerapi_macios_ext.go all: simplify ts_macext build tags 3 years ago
peerapi_test.go all: update tests to use tstest.MemLogger 3 years ago
state_test.go ipn/ipnlocal: do not shut down the backend halfway through TestStateMachine 3 years ago