You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/cmd
Nick Khyl a9dc6e07ad util/codegen, cmd/cloner, cmd/viewer: update codegen.LookupMethod to support alias type nodes
Go 1.23 updates the go/types package to produce Alias type nodes for type aliases, unless disabled with gotypesalias=0.
This new default behavior breaks codegen.LookupMethod, which uses checked type assertions to types.Named and
types.Interface, as only named types and interfaces have methods.

In this PR, we update codegen.LookupMethod to perform method lookup on the right-hand side of the alias declaration
and clearly switch on the supported type nodes types. We also improve support for various edge cases, such as when an alias
is used as a type parameter constraint, and add tests for the LookupMethod function.

Additionally, we update cmd/viewer/tests to include types with aliases used in type fields and generic type constraints.

Updates #13224
Updates #12912

Signed-off-by: Nick Khyl <nickk@tailscale.com>
1 year ago
..
addlicense all: update tools that manage copyright headers 3 years ago
build-webclient client/web: precompress assets 2 years ago
cloner util/codegen, cmd/cloner, cmd/viewer: update codegen.LookupMethod to support alias type nodes 1 year ago
connector-gen cmd/connector-gen: add helper tool for wide app connector configurations 2 years ago
containerboot cmd/containerboot: optionally serve health check endpoint (#12899) 1 year ago
derper go.mod: update to github.com/tailscale/netlink library that doesn't require vishvananda/netlink 1 year ago
derpprobe cmd/derpprobe: use a status page from the prober library 1 year ago
dist release/dist/qnap: add qnap target builder 2 years ago
get-authkey util/cmpx: delete now that we're using Go 1.22 2 years ago
gitops-pusher cmd/gitops-pusher: ignore previous etag if local acls match control (#13068) 1 year ago
hello cmd/hello: link to the Hello KB article (#11022) 2 years ago
k8s-nameserver cmd/k8s-nameserver: fix AAAA record query response (#12412) 2 years ago
k8s-operator go.mod: update to github.com/tailscale/netlink library that doesn't require vishvananda/netlink 1 year ago
mkmanifest cmd/mkmanifest, cmd/tailscale, cmd/tailscaled: remove Windows arm32 resources from OSS 3 years ago
mkpkg go.mod: upgrade nfpm to v2 (#8786) 2 years ago
mkversion version/mkversion: open-source version generation logic 3 years ago
nardump all: update copyright and license headers 3 years ago
natc go.mod: bump bart 1 year ago
netlogfmt all: use Go 1.22 range-over-int 2 years ago
nginx-auth tailcfg,all: add and use Node.IsTagged() 3 years ago
pgproxy tsnet: split user facing and backend logging 2 years ago
printdep cmd/printdep: print correct toolchain URL 3 years ago
proxy-to-grafana cmd/proxy-to-grafana: add flag for alternative control server 1 year ago
sniproxy all: use math/rand/v2 more 2 years ago
speedtest all: update copyright and license headers 3 years ago
ssh-auth-none-demo all: replace deprecated ioutil references 2 years ago
stunc cmd/stunc: support user-specified port (#12469) 2 years ago
stund all: switch to and require Go 1.23 1 year ago
stunstamp cmd/stunstamp: refactor connection construction (#13110) 1 year ago
sync-containers all: adjust some build tags for plan9 2 years ago
systray cmd/systray: set ipn.NotifyNoPrivateKeys, permit non-operator use 1 year ago
tailscale go.mod: update to github.com/tailscale/netlink library that doesn't require vishvananda/netlink 1 year ago
tailscaled go.mod: update to github.com/tailscale/netlink library that doesn't require vishvananda/netlink 1 year ago
testcontrol all: use Go 1.22 range-over-int 2 years ago
testwrapper cmd/testwrapper: apply results of all unit tests to coverage for all packages 2 years ago
tl-longchain cmd/tl-longchain: tool to re-sign nodes with long rotation signatures 1 year ago
tsconnect all: use math/rand/v2 more 2 years ago
tsidp cmd/tsidp: add funnel support (#12591) 1 year ago
tsshd all: update copyright and license headers 3 years ago
tta cmd/tta, tstest/natlab/vnet: remove unneeded port 124 log hack, add log buffer 1 year ago
viewer util/codegen, cmd/cloner, cmd/viewer: update codegen.LookupMethod to support alias type nodes 1 year ago
vnet cmd/vnet: add --blend and --pcap flags 1 year ago
xdpderper all: add test for package comments, fix, add comments as needed 1 year ago