You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/net/tshttpproxy
Aaron Klotz 4dbdb19c26 net/tshttpproxy: fix incorrect type in Windows implementation, switch to mkwinsyscall, fix memory leak
The definition of winHTTPProxyInfo was using the wrong type (uint16 vs uint32)
for its first field. I fixed that type.

Furthermore, any UTF16 strings returned in that structure must be explicitly
freed. I added code to do this.

Finally, since this is the second time I've seen type safety errors in this code,
I switched the native API calls over to use wrappers generated by mkwinsyscall.
I know that would not have helped prevent the previous two problems, but every
bit helps IMHO.

Updates https://github.com/tailscale/tailscale/issues/4811

Signed-off-by: Aaron Klotz <aaron@tailscale.com>
2 years ago
..
mksyscall.go net/tshttpproxy: fix incorrect type in Windows implementation, switch to mkwinsyscall, fix memory leak 2 years ago
tshttpproxy.go net/tshttpproxy: support HTTP proxy environment credentials on Windows too 4 years ago
tshttpproxy_future.go all: gofmt with Go 1.17 3 years ago
tshttpproxy_linux.go tshttpproxy: support synology proxy configuration 3 years ago
tshttpproxy_synology.go net/tshttpproxy: synology: pick proxy by scheme 3 years ago
tshttpproxy_synology_test.go net/tshttpproxy: synology: pick proxy by scheme 3 years ago
tshttpproxy_test.go net/tshttpproxy: support HTTP proxy environment credentials on Windows too 4 years ago
tshttpproxy_windows.go net/tshttpproxy: fix incorrect type in Windows implementation, switch to mkwinsyscall, fix memory leak 2 years ago
zsyscall_windows.go net/tshttpproxy: fix incorrect type in Windows implementation, switch to mkwinsyscall, fix memory leak 2 years ago