You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/wgengine
Amal Bansode 6de5b01e04
ipn/localapi: stop logging "broken pipe" errors (#18487)
The Tailscale CLI has some methods to watch the IPN bus for
messages, say, the current netmap (`tailscale debug netmap`).
The Tailscale daemon supports this using a streaming HTTP
response. Sometimes, the client can close its connection
abruptly -- due to an interruption, or in the case of `debug netmap`,
intentionally after consuming one message.

If the server daemon is writing a response as the client closes
its end of the socket, the daemon typically encounters a "broken pipe"
error. The "Watch IPN Bus" handler currently logs such errors after
they're propagated by a JSON encoding/writer helper.

Since the Tailscale CLI nominally closes its socket with the daemon
in this slightly ungraceful way (viz. `debug netmap`), stop logging
these broken pipe errors as far as possible. This will help avoid
confounding users when they scan backend logs.

Updates #18477

Signed-off-by: Amal Bansode <amal@tailscale.com>
2 days ago
..
bench all: remove AUTHORS file and references to it 5 days ago
filter all: remove AUTHORS file and references to it 5 days ago
magicsock ipn/localapi: stop logging "broken pipe" errors (#18487) 2 days ago
netlog all: remove AUTHORS file and references to it 5 days ago
netstack all: remove AUTHORS file and references to it 5 days ago
router all: remove AUTHORS file and references to it 5 days ago
wgcfg all: remove AUTHORS file and references to it 5 days ago
wgint all: remove AUTHORS file and references to it 5 days ago
wglog all: remove AUTHORS file and references to it 5 days ago
winnet all: remove AUTHORS file and references to it 5 days ago
mem_ios.go all: remove AUTHORS file and references to it 5 days ago
pendopen.go all: remove AUTHORS file and references to it 5 days ago
pendopen_omit.go all: remove AUTHORS file and references to it 5 days ago
userspace.go all: remove AUTHORS file and references to it 5 days ago
userspace_ext_test.go all: remove AUTHORS file and references to it 5 days ago
userspace_test.go all: remove AUTHORS file and references to it 5 days ago
watchdog.go all: remove AUTHORS file and references to it 5 days ago
watchdog_omit.go all: remove AUTHORS file and references to it 5 days ago
watchdog_test.go all: remove AUTHORS file and references to it 5 days ago
wgengine.go all: remove AUTHORS file and references to it 5 days ago