You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/ipn
Amal Bansode 6de5b01e04
ipn/localapi: stop logging "broken pipe" errors (#18487)
The Tailscale CLI has some methods to watch the IPN bus for
messages, say, the current netmap (`tailscale debug netmap`).
The Tailscale daemon supports this using a streaming HTTP
response. Sometimes, the client can close its connection
abruptly -- due to an interruption, or in the case of `debug netmap`,
intentionally after consuming one message.

If the server daemon is writing a response as the client closes
its end of the socket, the daemon typically encounters a "broken pipe"
error. The "Watch IPN Bus" handler currently logs such errors after
they're propagated by a JSON encoding/writer helper.

Since the Tailscale CLI nominally closes its socket with the daemon
in this slightly ungraceful way (viz. `debug netmap`), stop logging
these broken pipe errors as far as possible. This will help avoid
confounding users when they scan backend logs.

Updates #18477

Signed-off-by: Amal Bansode <amal@tailscale.com>
2 days ago
..
auditlog all: remove AUTHORS file and references to it 5 days ago
conffile all: remove AUTHORS file and references to it 5 days ago
desktop all: remove AUTHORS file and references to it 5 days ago
ipnauth all: remove AUTHORS file and references to it 5 days ago
ipnext all: remove AUTHORS file and references to it 5 days ago
ipnlocal ipn/ipnlocal/netmapcache: add a package to split and cache network maps (#18497) 2 days ago
ipnserver all: remove AUTHORS file and references to it 5 days ago
ipnstate all: remove AUTHORS file and references to it 5 days ago
lapitest all: remove AUTHORS file and references to it 5 days ago
localapi ipn/localapi: stop logging "broken pipe" errors (#18487) 2 days ago
policy all: remove AUTHORS file and references to it 5 days ago
store all: remove AUTHORS file and references to it 5 days ago
backend.go all: remove AUTHORS file and references to it 5 days ago
backend_test.go all: remove AUTHORS file and references to it 5 days ago
conf.go all: remove AUTHORS file and references to it 5 days ago
doc.go all: remove AUTHORS file and references to it 5 days ago
ipn_clone.go all: remove AUTHORS file and references to it 5 days ago
ipn_test.go all: remove AUTHORS file and references to it 5 days ago
ipn_view.go all: remove AUTHORS file and references to it 5 days ago
prefs.go all: remove AUTHORS file and references to it 5 days ago
prefs_test.go all: remove AUTHORS file and references to it 5 days ago
serve.go all: remove AUTHORS file and references to it 5 days ago
serve_expand_test.go all: remove AUTHORS file and references to it 5 days ago
serve_test.go all: remove AUTHORS file and references to it 5 days ago
store.go all: remove AUTHORS file and references to it 5 days ago
store_test.go all: remove AUTHORS file and references to it 5 days ago