You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/ipn
Avery Pennarun 8a7d35594d ipnlocal: don't assume NeedsLogin immediately after StartLogout().
Previously, there was no server round trip required to log out, so when
you asked ipnlocal to Logout(), it could clear the netmap immediately
and switch to NeedsLogin state.

In v1.8, we added a true Logout operation. ipn.Logout() would trigger
an async cc.StartLogout() and *also* immediately switch to NeedsLogin.
Unfortunately, some frontends would see NeedsLogin and immediately
trigger a new StartInteractiveLogin() operation, before the
controlclient auth state machine actually acted on the Logout command,
thus accidentally invalidating the entire logout operation, retaining
the netmap, and violating the user's expectations.

Instead, add a new LogoutFinished signal from controlclient
(paralleling LoginFinished) and, upon starting a logout, don't update
the ipn state machine until it's received.

Updates: #1918 (BUG-2)
Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>
4 years ago
..
ipnlocal ipnlocal: don't assume NeedsLogin immediately after StartLogout(). 4 years ago
ipnserver all: adapt to opaque netaddr types 4 years ago
ipnstate ipn/{ipnlocal,ipnstate}: add PeerStatus.ID stable ID to status --json output 4 years ago
localapi ipn/ipnlocal, etc: require file sharing capability to send/recv files 4 years ago
policy ipn/policy: mark peerapi4 and peerapi6 as interesting services 4 years ago
backend.go ipnlocal: accept a new opts.UpdatePrefs field. 4 years ago
doc.go Move Linux client & common packages into a public repo. 5 years ago
fake_test.go ipn{,/ipnlocal}, cmd/tailscale/cli: don't check pref reverts on initial up 4 years ago
handle.go ipn{,/ipnlocal}, cmd/tailscale/cli: don't check pref reverts on initial up 4 years ago
message.go ipn: allow b to be nil in NewBackendServer 4 years ago
message_test.go ipn: allow b to be nil in NewBackendServer 4 years ago
prefs.go ipnlocal: accept a new opts.UpdatePrefs field. 4 years ago
prefs_clone.go Add prefs.LoggedOut to fix several state machine bugs. 4 years ago
prefs_test.go Add prefs.LoggedOut to fix several state machine bugs. 4 years ago
store.go wgkey: new package 4 years ago
store_test.go Add tstest.PanicOnLog(), and fix various problems detected by this. 5 years ago