You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Nick Khyl fd7dd6433f ipn/ipnlocal: fix LocalBackend deadlock when packet arrives during profile switch (#18126) ... If a packet arrives while WireGuard is being reconfigured with b.mu held, such as during a profile switch, calling back into (*LocalBackend).GetPeerAPIPort from (*Wrapper).filterPacketInboundFromWireGuard may deadlock when it tries to acquire b.mu. This occurs because a peer cannot be removed while an inbound packet is being processed. The reconfig and profile switch wait for (*Peer).RoutineSequentialReceiver to return, but it never finishes because GetPeerAPIPort needs b.mu, which the waiting goroutine already holds. In this PR, we make peerAPIPorts a new syncs.AtomicValue field that is written with b.mu held but can be read by GetPeerAPIPort without holding the mutex, which fixes the deadlock. There might be other long-term ways to address the issue, such as moving peer API listeners from LocalBackend to nodeBackend so they can be accessed without holding b.mu, but these changes are too large and risky at this stage in the v1.92 release cycle. Updates #18124 Signed-off-by: Nick Khyl <nickk@tailscale.com> (cherry picked from commit 557457f3c2)		1 month ago
..
testdata	ipn/ipnlocal: fix the path for writing cert files (#7203)	3 years ago
breaktcp_darwin.go	cmd/tailscale: add debug commands to break connections	2 years ago
breaktcp_linux.go	cmd/tailscale: add debug commands to break connections	2 years ago
bus.go	ipn/local: add the suggested exit node to the ipn bus (#16748)	4 months ago
bus_test.go	ipn/ipnlocal: add IPN Bus NotifyRateLimit watch bit NotifyRateLimit	1 year ago
c2n.go	types/netmap: remove PrivateKey from NetworkMap	2 months ago
c2n_pprof.go	ipn/ipnlocal, engine: avoid runtime/pprof with two usages of ts_omit_debug	3 months ago
c2n_test.go	types/netmap,*: remove some redundant fields from NetMap	2 months ago
captiveportal.go	feature/featuretags: add build tag to remove captive portal detection	3 months ago
cert.go	syncs: add Mutex/RWMutex alias/wrappers for future mutex debugging	2 months ago
cert_disabled.go	feature/featuretags, all: add ts_omit_acme to disable TLS cert support	4 months ago
cert_test.go	ipn/ipnlocal, envknob: make it possible to configure the cert client to act in read-only mode (#15250)	10 months ago
dnsconfig_test.go	types/netmap,*: remove some redundant fields from NetMap	2 months ago
drive.go	ipn/ipnlocal: fix panic in driveTransport on network error	1 month ago
drive_test.go	ipn/ipnlocal: fix panic in driveTransport on network error	1 month ago
drive_tomove.go	feature/drive: start factoring out Taildrive, add ts_omit_drive build tag	4 months ago
expiry.go	ipn/ipnlocal: use eventbus.SubscribeFunc in expiryManager	3 months ago
expiry_test.go	control/controlclient: introduce eventbus messages instead of callbacks (#16956)	4 months ago
extension_host.go	ipn/ipnlocal: make GetExt work earlier, before extension init	8 months ago
extension_host_test.go	health,ipn/ipnlocal: introduce eventbus in heath.Tracker (#17085)	4 months ago
hwattest.go	Revert "control/controlclient: back out HW key attestation (#17664)" (#17732)	2 months ago
local.go	ipn/ipnlocal: fix LocalBackend deadlock when packet arrives during profile switch (#18126)	1 month ago
local_test.go	ipn/ipnlocal: don't panic if there are no suitable exit nodes	1 month ago
loglines_test.go	health,ipn/ipnlocal: introduce eventbus in heath.Tracker (#17085)	4 months ago
netstack.go	ipn/ipnlocal: move last unconditional gvisor import, complete ts_omit_netstack support	3 months ago
network-lock.go	tstest/integration: add integration test for Tailnet Lock	1 month ago
network-lock_test.go	tstest/integration: add integration test for Tailnet Lock	1 month ago
node_backend.go	types/netmap,*: remove some redundant fields from NetMap	2 months ago
node_backend_test.go	ipn/ipnlocal: introduce the concept of client-side-reachability (#17367)	3 months ago
peerapi.go	feature/featuretags: add features for c2n, peerapi, advertise/use routes/exit nodes	3 months ago
peerapi_drive.go	feature/drive: start factoring out Taildrive, add ts_omit_drive build tag	4 months ago
peerapi_macios_ext.go	net/netmon, add: add netmon.State type alias of interfaces.State	2 years ago
peerapi_test.go	ipn/ipnlocal: fix another racy test (#17472)	3 months ago
prefs_metrics.go	feature/featuretags: add features for c2n, peerapi, advertise/use routes/exit nodes	3 months ago
profiles.go	types/netmap: remove PrivateKey from NetworkMap	2 months ago
profiles_notwindows.go	ipn/ipnlocal: refactor and cleanup profileManager	1 year ago
profiles_test.go	ipn{,/local},cmd/tailscale: add "sync" flag and pref to disable control map poll	2 months ago
profiles_windows.go	ipn/ipnlocal: refactor and cleanup profileManager	1 year ago
serve.go	ipn/ipnlocal: add validations when setting serve config (#17950)	2 months ago
serve_disabled.go	all: add ts_omit_serve, start making tailscale serve/funnel be modular	4 months ago
serve_test.go	ipn/ipnlocal: add validations when setting serve config (#17950)	2 months ago
ssh.go	ipn/ipnlocal: fix a case where ts_omit_ssh was still linking in x/crypto/ssh	4 months ago
ssh_stub.go	ipn/ipnlocal: fix a case where ts_omit_ssh was still linking in x/crypto/ssh	4 months ago
ssh_test.go	health,ipn/ipnlocal: introduce eventbus in heath.Tracker (#17085)	4 months ago
state_test.go	types/key,wgengine/magicsock,control/controlclient,ipn: add debug disco key rotation	2 months ago
tailnetlock_disabled.go	all: add ts_omit_tailnetlock as a start of making it build-time modular	4 months ago
web_client.go	util/backoff: rename logtail/backoff package to util/backoff	3 months ago
web_client_stub.go	derp/derpserver: split off derp.Server out of derp into its own package	3 months ago