You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/wgengine
Andrea Gottardo a8ee83e2c5
health: begin work to use structured health warnings instead of strings, pipe changes into ipn.Notify (#12406)
Updates tailscale/tailscale#4136

This PR is the first round of work to move from encoding health warnings as strings and use structured data instead. The current health package revolves around the idea of Subsystems. Each subsystem can have (or not have) a Go error associated with it. The overall health of the backend is given by the concatenation of all these errors.

This PR polishes the concept of Warnable introduced by @bradfitz a few weeks ago. Each Warnable is a component of the backend (for instance, things like 'dns' or 'magicsock' are Warnables). Each Warnable has a unique identifying code. A Warnable is an entity we can warn the user about, by setting (or unsetting) a WarningState for it. Warnables have:

- an identifying Code, so that the GUI can track them as their WarningStates come and go
- a Title, which the GUIs can use to tell the user what component of the backend is broken
- a Text, which is a function that is called with a set of Args to generate a more detailed error message to explain the unhappy state

Additionally, this PR also begins to send Warnables and their WarningStates through LocalAPI to the clients, using ipn.Notify messages. An ipn.Notify is only issued when a warning is added or removed from the Tracker.

In a next PR, we'll get rid of subsystems entirely, and we'll start using structured warnings for all errors affecting the backend functionality.

Signed-off-by: Andrea Gottardo <andrea@gottardo.me>
2 years ago
..
bench ipn/ipnlocal, all: plumb health trackers in tests 2 years ago
capture various: add golangci-lint, fix issues (#7905) 3 years ago
filter all: use Go 1.22 range-over-int 2 years ago
magicsock wgengine/magicsock: use math/rands/v2 2 years ago
netlog wgengine: add exit destination logging enable for wgengine logger (#11952) 2 years ago
netstack wgengine/netstack: add test for #12448 2 years ago
router health: begin work to use structured health warnings instead of strings, pipe changes into ipn.Notify (#12406) 2 years ago
wgcfg ipn,wgengine: remove vestigial Prefs.AllowSingleHosts 2 years ago
wgint wgengine{,/wgint}: add wgint.Peer wrapper type, add to wgengine.Engine 2 years ago
wglog all: use Go 1.22 range-over-int 2 years ago
winnet all: update copyright and license headers 3 years ago
mem_ios.go all: update copyright and license headers 3 years ago
pendopen.go wgengine: make pendOpen time later, after dup check 2 years ago
userspace.go net/dns: don't set MatchDomains on Apple platforms when no upstream nameservers available (#12334) 2 years ago
userspace_ext_test.go ipn/ipnlocal, all: plumb health trackers in tests 2 years ago
userspace_test.go ipn/ipnlocal, all: plumb health trackers in tests 2 years ago
watchdog.go ipn/ipnlocal,net/tstun,wgengine: create and plumb jailed packet filter 2 years ago
watchdog_js.go all: update copyright and license headers 3 years ago
watchdog_test.go ipn/ipnlocal, all: plumb health trackers in tests 2 years ago
wgengine.go ipn/ipnlocal,net/tstun,wgengine: create and plumb jailed packet filter 2 years ago