You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

James 'zofrex' Sanderson 7407f404d9 ipn/ipnlocal: fix setAuthURL / setWgengineStatus race condition (#17408) ... If we received a wg engine status while processing an auth URL, there was a race condition where the authURL could be reset to "" immediately after we set it. To fix this we need to check that we are moving from a non-Running state to a Running state rather than always resetting the URL when we "move" into a Running state even if that is the current state. We also need to make sure that we do not return from stopEngineAndWait until the engine is stopped: before, we would return as soon as we received any engine status update, but that might have been an update already in-flight before we asked the engine to stop. Now we wait until we see an update that is indicative of a stopped engine, or we see that the engine is unblocked again, which indicates that the engine stopped and then started again while we were waiting before we checked the state. Updates #17388 Signed-off-by: James Sanderson <jsanderson@tailscale.com> Co-authored-by: Nick Khyl <nickk@tailscale.com>		3 months ago
..
testdata	ipn/ipnlocal: fix the path for writing cert files (#7203)	3 years ago
breaktcp_darwin.go	cmd/tailscale: add debug commands to break connections	2 years ago
breaktcp_linux.go	cmd/tailscale: add debug commands to break connections	2 years ago
bus.go	ipn/local: add the suggested exit node to the ipn bus (#16748)	5 months ago
bus_test.go	ipn/ipnlocal: add IPN Bus NotifyRateLimit watch bit NotifyRateLimit	1 year ago
c2n.go	control/controlclient,health,ipn/ipnlocal,health: fix deadlock by deleting health reporting	3 months ago
c2n_pprof.go	ipn/ipnlocal, engine: avoid runtime/pprof with two usages of ts_omit_debug	4 months ago
c2n_test.go	ipn/ipnlocal: make the redactNetmapPrivateKeys test recursive	4 months ago
captiveportal.go	feature/featuretags: add build tag to remove captive portal detection	4 months ago
cert.go	feature, net/tshttpproxy: pull out support for using proxies as a feature	4 months ago
cert_disabled.go	feature/featuretags, all: add ts_omit_acme to disable TLS cert support	4 months ago
cert_test.go	ipn/ipnlocal, envknob: make it possible to configure the cert client to act in read-only mode (#15250)	10 months ago
dnsconfig_test.go	ipn,net,tsnet,wgengine: make an eventbus mandatory where it is used (#16594)	6 months ago
drive.go	feature/drive: start factoring out Taildrive, add ts_omit_drive build tag	4 months ago
drive_tomove.go	feature/drive: start factoring out Taildrive, add ts_omit_drive build tag	4 months ago
expiry.go	ipn/ipnlocal: use eventbus.Monitor in expiryManager (#17204)	4 months ago
expiry_test.go	control/controlclient: introduce eventbus messages instead of callbacks (#16956)	4 months ago
extension_host.go	ipn/ipnlocal: make GetExt work earlier, before extension init	8 months ago
extension_host_test.go	health,ipn/ipnlocal: introduce eventbus in heath.Tracker (#17085)	4 months ago
local.go	ipn/ipnlocal: fix setAuthURL / setWgengineStatus race condition (#17408)	3 months ago
local_test.go	ipn/ipnlocal: fix setAuthURL / setWgengineStatus race condition (#17408)	3 months ago
loglines_test.go	health,ipn/ipnlocal: introduce eventbus in heath.Tracker (#17085)	4 months ago
netstack.go	ipn/ipnlocal: move last unconditional gvisor import, complete ts_omit_netstack support	4 months ago
network-lock.go	all: add ts_omit_tailnetlock as a start of making it build-time modular	4 months ago
network-lock_test.go	net/netmon: remove usage of direct callbacks from netmon (#17292)	3 months ago
node_backend.go	ipn/ipnlocal: introduce the concept of client-side-reachability (#17367)	3 months ago
node_backend_test.go	ipn/ipnlocal: introduce the concept of client-side-reachability (#17367)	3 months ago
peerapi.go	feature/featuretags: add features for c2n, peerapi, advertise/use routes/exit nodes	3 months ago
peerapi_drive.go	feature/drive: start factoring out Taildrive, add ts_omit_drive build tag	4 months ago
peerapi_macios_ext.go	net/netmon, add: add netmon.State type alias of interfaces.State	2 years ago
peerapi_test.go	appc,*: publish events for route updates and storage (#17392)	3 months ago
prefs_metrics.go	feature/featuretags: add features for c2n, peerapi, advertise/use routes/exit nodes	3 months ago
profiles.go	feature/clientupdate: move clientupdate to a modular feature, disabled for tsnet	4 months ago
profiles_notwindows.go	ipn/ipnlocal: refactor and cleanup profileManager	1 year ago
profiles_test.go	feature/clientupdate: move clientupdate to a modular feature, disabled for tsnet	4 months ago
profiles_windows.go	ipn/ipnlocal: refactor and cleanup profileManager	1 year ago
serve.go	ipn/ipnlocal: proxy h2c grpc using net/http.Transport instead of x/net/http2	4 months ago
serve_disabled.go	all: add ts_omit_serve, start making tailscale serve/funnel be modular	4 months ago
serve_test.go	ipn/ipnlocal: proxy h2c grpc using net/http.Transport instead of x/net/http2	4 months ago
ssh.go	ipn/ipnlocal: fix a case where ts_omit_ssh was still linking in x/crypto/ssh	4 months ago
ssh_stub.go	ipn/ipnlocal: fix a case where ts_omit_ssh was still linking in x/crypto/ssh	4 months ago
ssh_test.go	health,ipn/ipnlocal: introduce eventbus in heath.Tracker (#17085)	4 months ago
state_test.go	ipn/ipnlocal: fix setAuthURL / setWgengineStatus race condition (#17408)	3 months ago
tailnetlock_disabled.go	all: add ts_omit_tailnetlock as a start of making it build-time modular	4 months ago
web_client.go	util/backoff: rename logtail/backoff package to util/backoff	4 months ago
web_client_stub.go	derp/derpserver: split off derp.Server out of derp into its own package	4 months ago