You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/ipn
Josh Bleecher Snyder 07c09f470d ipn/ipnlocal: do not shut down the backend halfway through TestStateMachine
LocalBackend.Shutdown's docs say:

> The backend can no longer be used after Shutdown returns.

Nevertheless, TestStateMachine blithely calls Shutdown, talks some smack,
and continues on, expecting things to work. Other uses of Shutdown
in the codebase are as intended.

Things mostly kinda work anyway, except that the wgengine.Engine has been
shut down, so calls to Reconfig fail. Those get logged:

> local.go:603: wgengine status error: engine closing; no status

but otherwise ignored.

However, the Reconfig failure caused one fewer call to pause/unpause
than normal. Now the assertCalls lines match the equivalent ones
earlier in the test.

I don't see an obvious correct replacement for Shutdown in the context
of this test; I'm not sure entirely what it is trying to accomplish.
It is possible that many of the tests remaining after the prior call
to Shutdown are now extraneous. They don't harm anything, though,
so err on the side of safety and leave them for now.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
3 years ago
..
ipnlocal ipn/ipnlocal: do not shut down the backend halfway through TestStateMachine 3 years ago
ipnserver all: close fake userspace engines when tests complete 3 years ago
ipnstate cmd/tailscale: fix "tailscale ip $self-host-hostname" 3 years ago
localapi client/tailscale,ipn/localapi: warn on tailscale/tailscaled version skew 3 years ago
policy ipn/policy: mark peerapi4 and peerapi6 as interesting services 3 years ago
backend.go ipnlocal: accept a new opts.UpdatePrefs field. 3 years ago
doc.go Move Linux client & common packages into a public repo. 4 years ago
fake_test.go ipn{,/ipnlocal}, cmd/tailscale/cli: don't check pref reverts on initial up 3 years ago
handle.go ipn: another controlplane synonym 3 years ago
message.go ipn: allow b to be nil in NewBackendServer 3 years ago
message_test.go ipn: allow b to be nil in NewBackendServer 3 years ago
prefs.go ipn: another controlplane synonym 3 years ago
prefs_clone.go cmd/cloner: reduce diff noise when changing command 3 years ago
prefs_test.go ipn, etc: use controlplane.tailscale.com 3 years ago
store.go ipn/store: add ability to store data as k8s secrets. 3 years ago
store_test.go Add tstest.PanicOnLog(), and fix various problems detected by this. 4 years ago