You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/cmd
Brad Fitzpatrick f3d2fd22ef cmd/tailscale/cli: don't start WatchIPNBus until after up's initial Start
The CLI "up" command is a historical mess, both on the CLI side and
the LocalBackend side. We're getting closer to cleaning it up, but in
the meantime it was again implicated in flaky tests.

In this case, the background goroutine running WatchIPNBus was very
occasionally running enough to get to its StartLoginInteractive call
before the original goroutine did its Start call. That meant
integration tests were very rarely but sometimes logging in with the
default control plane URL out on the internet
(controlplane.tailscale.com) instead of the localhost control server
for tests.

This also might've affected new Headscale etc users on initial "up".

Fixes #11960
Fixes #11962

Change-Id: I36f8817b69267a99271b5ee78cb7dbf0fcc0bd34
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
2 years ago
..
addlicense all: update tools that manage copyright headers 3 years ago
build-webclient client/web: precompress assets 2 years ago
cloner all: use Go 1.22 range-over-int 2 years ago
connector-gen cmd/connector-gen: add helper tool for wide app connector configurations 2 years ago
containerboot cmd/containerboot,kube,ipn/store/kubestore: allow interactive login on kube, check Secret create perms, allow empty state Secret (#11326) 2 years ago
derper derp/derphttp: fix netcheck HTTPS probes 2 years ago
derpprobe cmd/{derper,derpprobe}: add --version flag 2 years ago
dist release/dist/qnap: add qnap target builder 2 years ago
get-authkey util/cmpx: delete now that we're using Go 1.22 2 years ago
gitops-pusher cmd/gitops-pusher: only use OAuth creds if non-empty string 2 years ago
hello cmd/hello: link to the Hello KB article (#11022) 2 years ago
k8s-nameserver cmd/{k8s-operator,k8s-nameserver},k8s-operator: update nameserver config with records for ingress/egress proxies (#11019) 2 years ago
k8s-operator cmd/k8s-operator: cleanup runReconciler signature (#11993) 2 years ago
mkmanifest cmd/mkmanifest, cmd/tailscale, cmd/tailscaled: remove Windows arm32 resources from OSS 3 years ago
mkpkg go.mod: upgrade nfpm to v2 (#8786) 2 years ago
mkversion version/mkversion: open-source version generation logic 3 years ago
nardump all: update copyright and license headers 3 years ago
netlogfmt all: use Go 1.22 range-over-int 2 years ago
nginx-auth tailcfg,all: add and use Node.IsTagged() 3 years ago
pgproxy various: add golangci-lint, fix issues (#7905) 3 years ago
printdep cmd/printdep: print correct toolchain URL 3 years ago
proxy-to-grafana all: use Go 1.22 range-over-int 2 years ago
sniproxy all: make more tests pass/skip in airplane mode 2 years ago
speedtest all: update copyright and license headers 3 years ago
ssh-auth-none-demo all: replace deprecated ioutil references 2 years ago
stunc all: update copyright and license headers 3 years ago
stund build(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#11410) 2 years ago
sync-containers all: adjust some build tags for plan9 2 years ago
tailscale cmd/tailscale/cli: don't start WatchIPNBus until after up's initial Start 2 years ago
tailscaled ipn/ipnlocal, net/tsdial: plumb routes into tsdial and use them in UserDial 2 years ago
testcontrol all: use Go 1.22 range-over-int 2 years ago
testwrapper cmd/testwrapper: apply results of all unit tests to coverage for all packages 2 years ago
tsconnect health, all: remove health.Global, finish plumbing health.Tracker 2 years ago
tsidp cmd/tsidp: add start of OIDC Tailscale IdP 2 years ago
tsshd all: update copyright and license headers 3 years ago
viewer all: use Go 1.22 range-over-int 2 years ago