You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/ipn/ipnlocal
Nick Khyl 5bc9fafab8 ipn/ipnlocal: always send auth URL notifications when a user requests interactive login
This PR changes how LocalBackend handles interactive (initiated via StartLoginInteractive) and non-interactive (e.g., due to key expiration) logins,
and when it sends the authURL to the connected clients.

Specifically,
 - When a user initiates an interactive login by clicking Log In in the GUI, the LocalAPI calls StartLoginInteractive.
   If an authURL is available and hasn't expired, we immediately send it to all connected clients, suggesting them to open that URL in a browser.
   Otherwise, we send a login request to the control plane and set a flag indicating that an interactive login is in progress.
 - When LocalBackend receives an authURL from the control plane, we check if it differs from the previous one and whether an interactive login
   is in progress. If either condition is true, we notify all connected clients with the new authURL and reset the interactive login flag.

We reset the auth URL and flags upon a successful authentication, when a different user logs in and when switching Tailscale login profiles.

Finally, we remove the redundant dedup logic added to WatchNotifications in #12096 and revert the tests to their original state to ensure that
calling StartLoginInteractive always produces BrowseToURL notifications, either immediately or when the authURL is received from the control plane.

Fixes #13296

Signed-off-by: Nick Khyl <nickk@tailscale.com>
2 months ago
..
testdata ipn/ipnlocal: fix the path for writing cert files (#7203) 2 years ago
autoupdate.go clientupdate: return true for CanAutoUpdate for macsys (#12746) 4 months ago
autoupdate_disabled.go ipn/ipnlocal: periodically run auto-updates when "offline" (#12118) 5 months ago
breaktcp_darwin.go cmd/tailscale: add debug commands to break connections 1 year ago
breaktcp_linux.go cmd/tailscale: add debug commands to break connections 1 year ago
c2n.go posture: add network hardware addresses to posture identity 4 months ago
c2n_pprof.go ipn/ipnlocal: add c2n /debug/pprof/allocs endpoint 7 months ago
c2n_test.go util/cmpx: delete now that we're using Go 1.22 9 months ago
cert.go cmd/tailscale: add --min-validity flag to the cert command (#12822) 3 months ago
cert_js.go ipn/ipnlocal: add c2n method to check on TLS cert fetch status 11 months ago
cert_test.go all: use Go 1.21 slices, maps instead of x/exp/{slices,maps} 1 year ago
dnsconfig_test.go util/cmpx: delete now that we're using Go 1.22 9 months ago
drive.go ipn/ipnlocal: refactor and cleanup profileManager 2 months ago
expiry.go ssh/tailssh: use control server time instead of local time 11 months ago
expiry_test.go types/netmap, all: make NetworkMap.SelfNode a tailcfg.NodeView 1 year ago
local.go ipn/ipnlocal: always send auth URL notifications when a user requests interactive login 2 months ago
local_test.go ipn/ipnlocal: refactor and cleanup profileManager 2 months ago
loglines_test.go ipn/ipnlocal, all: plumb health trackers in tests 6 months ago
network-lock.go ipn/ipnlocal: fix a nil pointer dereference when serving /localapi/v0/tka/status 2 months ago
network-lock_test.go ipn/ipnlocal: allow multiple signature chains from the same SigCredential 4 months ago
peerapi.go proxymap, various: distinguish between different protocols 4 months ago
peerapi_h2c.go all: update copyright and license headers 2 years ago
peerapi_macios_ext.go net/netmon, add: add netmon.State type alias of interfaces.State 6 months ago
peerapi_test.go ipn/ipnlocal, all: plumb health trackers in tests 6 months ago
profiles.go ipn/ipnlocal: refactor and cleanup profileManager 2 months ago
profiles_notwindows.go ipn/ipnlocal: refactor and cleanup profileManager 2 months ago
profiles_test.go ipn/ipnlocal: refactor and cleanup profileManager 2 months ago
profiles_windows.go ipn/ipnlocal: refactor and cleanup profileManager 2 months ago
serve.go ipn/ipnlocal: fix race condition that results in a panic sending on a closed channel 2 months ago
serve_test.go ipn/ipnlocal: fix race condition that results in a panic sending on a closed channel 2 months ago
ssh.go ipnlocal: log failure to get ssh host keys 9 months ago
ssh_stub.go ipnlocal: log failure to get ssh host keys 9 months ago
ssh_test.go ipn/ipnlocal: plumb health.Tracker into profileManager constructor 6 months ago
state_test.go ipn/ipnlocal: always send auth URL notifications when a user requests interactive login 2 months ago
taildrop.go ipn/localapi: add support for multipart POST to file-put 7 months ago
web_client.go all: remove LenIter, use Go 1.22 range-over-int instead 8 months ago
web_client_stub.go ipn/ipnlocal: add mutex to webClient struct 11 months ago