You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/net/nettest
Josh Bleecher Snyder e16cb523aa net/nettest: deflake TestPipeTimeout
The block-write and block-read tests are both flaky,
because each assumes it can get a normal read/write
completed within 10ms. This isn’t always true.

We can’t increase the timeouts, because that slows down the test.
However, we don’t need to issue a regular read/write for this test.
The immediately preceding tests already test this code,
using a far more generous timeout.

Remove the extraneous read/write.

This drops the failure rate from 1 per 20,000 to undetectable
on my machine.

While we’re here, fix a typo in a debug print statement.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
3 years ago
..
conn.go net/nettest: make nettest.NewConn pass x/net/nettest.TestConn. 4 years ago
conn_test.go net/nettest: make nettest.NewConn pass x/net/nettest.TestConn. 4 years ago
listener.go net/nettest: make nettest.NewConn pass x/net/nettest.TestConn. 4 years ago
listener_test.go net/nettest: make nettest.NewConn pass x/net/nettest.TestConn. 4 years ago
pipe.go net/nettest: deflake TestPipeTimeout 3 years ago
pipe_test.go net/nettest: deflake TestPipeTimeout 3 years ago