You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/util/syspolicy/source
Nick Khyl f0db47338e cmd/tailscaled,util/syspolicy/source,util/winutil/gp: disallow acquiring the GP lock during service startup
In v1.78, we started acquiring the GP lock when reading policy settings. This led to a deadlock during
Tailscale installation via Group Policy Software Installation because the GP engine holds the write lock
for the duration of policy processing, which in turn waits for the installation to complete, which in turn
waits for the service to enter the running state.

In this PR, we prevent the acquisition of GP locks (aka EnterCriticalPolicySection) during service startup
and update the Windows Registry-based util/syspolicy/source.PlatformPolicyStore to handle this failure
gracefully. The GP lock is somewhat optional; it’s safe to read policy settings without it, but acquiring
the lock is recommended when reading multiple values to prevent the Group Policy engine from modifying
settings mid-read and to avoid inconsistent results.

Fixes #14416

Signed-off-by: Nick Khyl <nickk@tailscale.com>
10 months ago
..
env_policy_store.go util/syspolicy/source: put EnvPolicyStore env keys in their own namespace 1 year ago
env_policy_store_test.go util/syspolicy/source: put EnvPolicyStore env keys in their own namespace 1 year ago
policy_reader.go util/syspolicy/source: add package for reading policy settings from external stores 1 year ago
policy_reader_test.go util/syspolicy/source: add package for reading policy settings from external stores 1 year ago
policy_source.go util/syspolicy/source: add package for reading policy settings from external stores 1 year ago
policy_store_windows.go cmd/tailscaled,util/syspolicy/source,util/winutil/gp: disallow acquiring the GP lock during service startup 10 months ago
policy_store_windows_test.go util/syspolicy/source: add package for reading policy settings from external stores 1 year ago
test_store.go util/slicesx: add MapKeys and MapValues from golang.org/x/exp/maps 11 months ago