You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Nick Khyl b48c8db69c ipn/ipnlocal: set WantRunning upon an interactive login, but not during a seamless renewal or a profile switch ... The LocalBackend's state machine starts in NoState and soon transitions to NeedsLogin if there's no auto-start profile, with the profileManager starting with a new empty profile. Notably, entering the NeedsLogin state blocks engine updates. We expect the user to transition out of this state by logging in interactively, and we set WantRunning to true when controlclient enters the StateAuthenticated state. While our intention is correct, and completing an interactive login should set WantRunning to true, our assumption that logging into the current Tailscale profile is the only way to transition out of the NeedsLogin state is not accurate. Another common transition path includes an explicit profile switch (via LocalBackend.SwitchProfile) or an implicit switch when a Windows user connects to the backend. This results in a bug where WantRunning is set to true even when it was previously set to false, and the user expressed no intention of changing it. A similar issue occurs when switching from (sic) a Tailnet that has seamlessRenewalEnabled, regardless of the current state of the LocalBackend's state machine, and also results in unexpectedly set WantRunning. While this behavior is generally undesired, it is also incorrect that it depends on the control knobs of the Tailnet we're switching from rather than the Tailnet we're switching to. However, this issue needs to be addressed separately. This PR updates LocalBackend.SetControlClientStatus to only set WantRunning to true in response to an interactive login as indicated by a non-empty authURL. Fixes #6668 Fixes #11280 Updates #12756 Signed-off-by: Nick Khyl <nickk@tailscale.com>		2 months ago
..
testdata	ipn/ipnlocal: fix the path for writing cert files (#7203)	2 years ago
autoupdate.go	clientupdate: return true for CanAutoUpdate for macsys (#12746)	4 months ago
autoupdate_disabled.go	ipn/ipnlocal: periodically run auto-updates when "offline" (#12118)	5 months ago
breaktcp_darwin.go	cmd/tailscale: add debug commands to break connections	1 year ago
breaktcp_linux.go	cmd/tailscale: add debug commands to break connections	1 year ago
c2n.go	posture: add network hardware addresses to posture identity	4 months ago
c2n_pprof.go	ipn/ipnlocal: add c2n /debug/pprof/allocs endpoint	7 months ago
c2n_test.go	util/cmpx: delete now that we're using Go 1.22	9 months ago
cert.go	cmd/tailscale: add --min-validity flag to the cert command (#12822)	3 months ago
cert_js.go	ipn/ipnlocal: add c2n method to check on TLS cert fetch status	11 months ago
cert_test.go	all: use Go 1.21 slices, maps instead of x/exp/{slices,maps}	1 year ago
dnsconfig_test.go	util/cmpx: delete now that we're using Go 1.22	9 months ago
drive.go	ipn/ipnlocal: refactor and cleanup profileManager	2 months ago
expiry.go	ssh/tailssh: use control server time instead of local time	11 months ago
expiry_test.go	types/netmap, all: make NetworkMap.SelfNode a tailcfg.NodeView	1 year ago
local.go	ipn/ipnlocal: set WantRunning upon an interactive login, but not during a seamless renewal or a profile switch	2 months ago
local_test.go	ipn/ipnlocal: refactor and cleanup profileManager	2 months ago
loglines_test.go	ipn/ipnlocal, all: plumb health trackers in tests	6 months ago
network-lock.go	cmd/tl-longchain: tool to re-sign nodes with long rotation signatures	2 months ago
network-lock_test.go	ipn/ipnlocal: allow multiple signature chains from the same SigCredential	4 months ago
peerapi.go	proxymap, various: distinguish between different protocols	4 months ago
peerapi_h2c.go	all: update copyright and license headers	2 years ago
peerapi_macios_ext.go	net/netmon, add: add netmon.State type alias of interfaces.State	6 months ago
peerapi_test.go	ipn/ipnlocal, all: plumb health trackers in tests	6 months ago
profiles.go	ipn/ipnlocal: refactor and cleanup profileManager	2 months ago
profiles_notwindows.go	ipn/ipnlocal: refactor and cleanup profileManager	2 months ago
profiles_test.go	ipn/ipnlocal: refactor and cleanup profileManager	2 months ago
profiles_windows.go	ipn/ipnlocal: refactor and cleanup profileManager	2 months ago
serve.go	cmd/tsidp: add funnel support (#12591)	3 months ago
serve_test.go	ipn/ipnlocal: fix data race in tests	4 months ago
ssh.go	ipnlocal: log failure to get ssh host keys	9 months ago
ssh_stub.go	ipnlocal: log failure to get ssh host keys	9 months ago
ssh_test.go	ipn/ipnlocal: plumb health.Tracker into profileManager constructor	6 months ago
state_test.go	ipn/ipnlocal: set WantRunning upon an interactive login, but not during a seamless renewal or a profile switch	2 months ago
taildrop.go	ipn/localapi: add support for multipart POST to file-put	7 months ago
web_client.go	all: remove LenIter, use Go 1.22 range-over-int instead	8 months ago
web_client_stub.go	ipn/ipnlocal: add mutex to webClient struct	11 months ago