You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/net
Joe Tsai 2e5d08ec4f
net/connstats: invert network logging data flow (#6272)
Previously, tstun.Wrapper and magicsock.Conn managed their
own statistics data structure and relied on an external call to
Extract to extract (and reset) the statistics.
This makes it difficult to ensure a maximum size on the statistics
as the caller has no introspection into whether the number
of unique connections is getting too large.

Invert the control flow such that a *connstats.Statistics
is registered with tstun.Wrapper and magicsock.Conn.
Methods on non-nil *connstats.Statistics are called for every packet.
This allows the implementation of connstats.Statistics (in the future)
to better control when it needs to flush to ensure
bounds on maximum sizes.

The value registered into tstun.Wrapper and magicsock.Conn could
be an interface, but that has two performance detriments:

1. Method calls on interface values are more expensive since
they must go through a virtual method dispatch.

2. The implementation would need a sync.Mutex to protect the
statistics value instead of using an atomic.Pointer.

Given that methods on constats.Statistics are called for every packet,
we want reduce the CPU cost on this hot path.

Signed-off-by: Joe Tsai <joetsai@digital-static.net>
2 years ago
..
connstats net/connstats: invert network logging data flow (#6272) 2 years ago
dns net/dns: retry overwriting hosts file on Windows 2 years ago
dnscache net/dnscache: Handle 4-in-6 addresses in DNS responses 2 years ago
dnsfallback all: remove old +build tags 2 years ago
flowtrack net/flowtrack: add json tags to Tuple (#5849) 2 years ago
interfaces ipn/ipnlocal: don't warn about serve listener failing on IPv6-less machines 2 years ago
netaddr all: migrate code from netaddr.FromStdAddr to Go 1.18 2 years ago
netcheck net/netcheck: don't use a space in the captive portal challenge 2 years ago
neterror net/{neterror,dns/resolver}: move PacketWasTruncated to neterror from DNS code 3 years ago
netknob all: disable TCP keep-alives on iOS/Android 3 years ago
netns all: remove old +build tags 2 years ago
netstat all: remove old +build tags 2 years ago
nettest ssh/tailssh: add TestSSHAuthFlow 2 years ago
netutil all: fix spelling mistakes 2 years ago
packet all: fix spelling mistakes 2 years ago
ping all: fix spelling mistakes 2 years ago
portmapper net/portmapper: add test for Huawei router 2 years ago
proxymux net/proxymux: add a listener mux that can run SOCKS and HTTP on a single socket. 3 years ago
routetable all: remove old +build tags 2 years ago
socks5 net/socks5: use new Go 1.19 binary.AppendByteOrder.AppendUintX 2 years ago
speedtest net/speedtest: retune to meet iperf on localhost in a VM 2 years ago
stun net/netcheck: deflake (maybe) magicsock's TestNewConn 2 years ago
tlsdial all: remove old +build tags 2 years ago
tsaddr ipn/ipnlocal: also accept service IP IPv6 literal in brackets for quad100 2 years ago
tsdial all: standardize on PeerAPI 2 years ago
tshttpproxy net/tshttpproxy: don't ignore env-based HTTP proxies after system lookups fail 2 years ago
tstun net/connstats: invert network logging data flow (#6272) 2 years ago
wsconn net/wsconn: add back custom wrapper for turning a websocket.Conn into a net.Conn 2 years ago