You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/ipn
Jonathan Nobels 2b7f8b6be7 net/netmon: remove ChangeDelta.Major and start the TODOs
updates tailscale/corp#33891

We've had some TODO's in netmon for ages related to asking
more pointed questions of ChangeDelta.  We're also seeing
a lot of ChangeDelta's being flagged as "Major" when they are
not interesting, triggering rebinds in wgengine that are not needed.

This removes the "Major" flag and replaces it with a set of
precomputed values that hint at what the ChangeDelta means.

 The dependencies are cleaned up a bit,
notably removing dependency on netmon itself for calculating
what is interesting, and what is not.  This includes letting
individual platforms set a bespoke global "IsInterestingInterface"
function.  This was only used on Darwin.

RebindRequired roughly flows from how "Major" was historically
calculated but includes some additional checks for various
uninteresting events such as changes in interface addresses that
shouldn't trigger a rebind to minimize thrashing.   The individual
values that we roll  into RebindRequired are also exposed so that
components consuming netmap.ChangeDelta can ask more
targeted questions.

Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>

wgengine/userspace: skip rebind and restun if all of our interfaces are down

updates tailscale/corp#33891

Skip rebind and restun if we have called SetNetworkUp with false.  Neither
cares about this state and it's just flappy to try to reStun and rebind if
there are no usable interfaces available.

Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>

Add viability flag and fix bug in state
4 days ago
..
auditlog syncs: add Mutex/RWMutex alias/wrappers for future mutex debugging 3 weeks ago
conffile cmd/tailscale/cli,ipn/conffile: add declarative config mode for Services (#17435) 2 months ago
desktop go.mod: bump golang.org/x/crypto (#17907) 3 weeks ago
ipnauth all: use buildfeature constants in a few more places 2 months ago
ipnext ipn/ipnlocal: remove all the weird locking (LockedOnEntry, UnlockEarly, etc) 4 weeks ago
ipnlocal net/netmon: remove ChangeDelta.Major and start the TODOs 4 days ago
ipnserver feature/featuretags, all: add build features, use existing ones in more places 2 months ago
ipnstate cmd/tailscale, ipn/ipnstate, wgengine/magicsock: update ping output for peer relay (#16515) 5 months ago
lapitest various: allow tailscaled shutdown via LocalAPI 3 months ago
localapi cmd/tailscaled,ipn: show a health warning when state store fails to open (#17883) 3 weeks ago
policy ipn,tailconfig: clean up unreleased and removed app connector service 2 years ago
store ipn/store, feature/condregister: permit callers to empty import optonal ipn stores 2 months ago
backend.go types/netmap: remove PrivateKey from NetworkMap 3 weeks ago
backend_test.go ipn: fix the string representation of an empty ipn.Notify 3 months ago
conf.go ipn: ensure that conffile is source of truth for advertised services. (#15361) 9 months ago
doc.go ipn: generate LoginProfileView and use it instead of *LoginProfile where appropriate 10 months ago
ipn_clone.go cmd/tailscale/cli,ipn,all: make peer relay server port a *uint16 2 weeks ago
ipn_test.go all: do not depend on the testing package 2 years ago
ipn_view.go cmd/tailscale/cli,ipn,all: make peer relay server port a *uint16 2 weeks ago
prefs.go cmd/tailscale/cli,ipn,all: make peer relay server port a *uint16 2 weeks ago
prefs_test.go cmd/tailscale/cli,ipn,all: make peer relay server port a *uint16 2 weeks ago
serve.go cmd/tailscale,ipn: add Unix socket support for serve 5 days ago
serve_expand_test.go cmd/tailscale,ipn: add Unix socket support for serve 5 days ago
serve_test.go ipn/serve: validate service paths in HasPathHandler 2 weeks ago
store.go cmd/tailscaled,ipn: show a health warning when state store fails to open (#17883) 3 weeks ago
store_test.go ipn/store: automatically migrate between plaintext and encrypted state (#16318) 6 months ago