You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/ipn/ipnlocal
Nick Khyl f33f5f99c0 ipn/{ipnlocal,ipnserver}: remove redundant (*LocalBackend).ResetForClientDisconnect
In this commit, we add a failing test to verify that ipn/ipnserver.Server correctly
sets and unsets the current user when two different users connect sequentially
(A connects, A disconnects, B connects, B disconnects).

We then fix the test by updating (*ipn/ipnserver.Server).addActiveHTTPRequest
to avoid calling (*LocalBackend).ResetForClientDisconnect again after a new user
has connected and been set as the current user with (*LocalBackend).SetCurrentUser().

Since ipn/ipnserver.Server does not allow simultaneous connections from different
Windows users and relies on the LocalBackend's current user, and since we already
reset the LocalBackend's state by calling ResetForClientDisconnect when the last
active request completes (indicating the server is idle and can accept connections
from any Windows user), it is unnecessary to track the last connected user on the
ipnserver.Server side or call ResetForClientDisconnect again when the user changes.

Additionally, the second call to ResetForClientDisconnect occurs after the new user
has been set as the current user, resetting the correct state for the new user
instead of the old state of the now-disconnected user, causing issues.

Updates tailscale/corp#25804

Signed-off-by: Nick Khyl <nickk@tailscale.com>
1 year ago
..
testdata ipn/ipnlocal: fix the path for writing cert files (#7203) 3 years ago
autoupdate.go clientupdate: return true for CanAutoUpdate for macsys (#12746) 2 years ago
autoupdate_disabled.go ipn/ipnlocal: periodically run auto-updates when "offline" (#12118) 2 years ago
breaktcp_darwin.go cmd/tailscale: add debug commands to break connections 2 years ago
breaktcp_linux.go cmd/tailscale: add debug commands to break connections 2 years ago
bus.go ipn/ipnlocal: fix build, remove another Notify.BackendLogID reference that crept in 1 year ago
bus_test.go ipn/ipnlocal: add IPN Bus NotifyRateLimit watch bit NotifyRateLimit 1 year ago
c2n.go ipn/ipnlocal: add VIPServices hash to return body of vip-services c2n endpoint 1 year ago
c2n_pprof.go ipn/ipnlocal: add c2n /debug/pprof/allocs endpoint 2 years ago
c2n_test.go util/cmpx: delete now that we're using Go 1.22 2 years ago
cert.go cmd/tailscale: add --min-validity flag to the cert command (#12822) 2 years ago
cert_js.go ipn/ipnlocal: add c2n method to check on TLS cert fetch status 2 years ago
cert_test.go all: use Go 1.21 slices, maps instead of x/exp/{slices,maps} 2 years ago
dnsconfig_test.go ipn/ipnlocal: don't program system DNS when node key is expired (#13370) 1 year ago
drive.go cmd/viewer,types/views,various: avoid allocations in pointer field getters whenever possible 1 year ago
expiry.go all: add Node.HomeDERP int, phase out "127.3.3.40:$region" hack [capver 111] 1 year ago
expiry_test.go cmd/viewer,types/views,various: avoid allocations in pointer field getters whenever possible 1 year ago
local.go ipn/{ipnlocal,ipnserver}: remove redundant (*LocalBackend).ResetForClientDisconnect 1 year ago
local_test.go all: add Node.HomeDERP int, phase out "127.3.3.40:$region" hack [capver 111] 1 year ago
loglines_test.go util/usermetrics: make usermetrics non-global 1 year ago
network-lock.go all: use iterators over slice views more 1 year ago
network-lock_test.go tka: truncate long rotation signature chains 1 year ago
peerapi.go ipn/ipnlocal: allow Peer API access via either V4MasqAddr or V6MasqAddr when both are set 1 year ago
peerapi_h2c.go all: update copyright and license headers 3 years ago
peerapi_macios_ext.go net/netmon, add: add netmon.State type alias of interfaces.State 2 years ago
peerapi_test.go util/usermetrics: make usermetrics non-global 1 year ago
profiles.go ipn/ipnlocal: refactor and cleanup profileManager 1 year ago
profiles_notwindows.go ipn/ipnlocal: refactor and cleanup profileManager 1 year ago
profiles_test.go ipn/ipnlocal: refactor and cleanup profileManager 1 year ago
profiles_windows.go ipn/ipnlocal: refactor and cleanup profileManager 1 year ago
serve.go all: use iterators in more places instead of Range funcs 1 year ago
serve_test.go util/usermetrics: make usermetrics non-global 1 year ago
ssh.go types/result, util/lineiter: add package for a result type, use it 1 year ago
ssh_stub.go ipnlocal: log failure to get ssh host keys 2 years ago
ssh_test.go ipn/ipnlocal: plumb health.Tracker into profileManager constructor 2 years ago
state_test.go ipn/{ipnlocal,localapi}, wgengine/netstack: call (*LocalBackend).Shutdown when tests that create them complete 1 year ago
taildrop.go ipn/localapi: add support for multipart POST to file-put 2 years ago
web_client.go all: use iterators over slice views more 1 year ago
web_client_stub.go ipn/ipnlocal: add mutex to webClient struct 2 years ago