You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/types
Brad Fitzpatrick 171ec9f8f4 control/{controlknobs,controlclient}: simplify knobs API, fix controlclient crash
From integration tests elsewhere:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x70 pc=0x845c9b]

goroutine 226 [running]:
tailscale.com/control/controlclient.(*Direct).sendMapRequest(0xc00053e1e0, 0x16670f0, 0xc000353780, 0xffffffffffffffff, 0xc0003e5f10, 0x0, 0x0)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:803 +0x19bb
tailscale.com/control/controlclient.(*Direct).PollNetMap(...)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:574
tailscale.com/control/controlclient.(*Auto).mapRoutine(0xc00052a1e0)
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:464 +0x571
created by tailscale.com/control/controlclient.(*Auto).Start
   /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:151 +0x65
exit status 2

Also remove types/opt.Bool API addition which is now unnecessary.

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
3 years ago
..
empty types/empty: add Message, stop using mysterious *struct{} 5 years ago
flagtype types/flagtype: fix bug showing the default port value (shown in --help) 4 years ago
ipproto net/packet, wgengine/filter: support SCTP 4 years ago
key staticcheck.conf: turn off noisy lint errors 3 years ago
logger types/logger: fix deadlock RateLimitedFn reentrancy 3 years ago
netmap all: adapt to opaque netaddr types 4 years ago
nettype wgengine/magicsock, tstest/natlab: start hooking up natlab to magicsock 4 years ago
opt control/{controlknobs,controlclient}: simplify knobs API, fix controlclient crash 3 years ago
pad32 net/portmapper: add NAT-PMP client, move port mapping service probing 4 years ago
persist types/persist: split controlclient.Persist into a small leaf package 4 years ago
preftype types/preftype: don't use iota for consts persisted to disk 4 years ago
structs types/structs: add structs.Incomparable annotation, use it where applicable 5 years ago
wgkey tailcfg, types/wgkey: add AppendTo methods on some types 4 years ago