You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Joe Tsai 2e5d08ec4f net/connstats: invert network logging data flow (#6272) ... Previously, tstun.Wrapper and magicsock.Conn managed their own statistics data structure and relied on an external call to Extract to extract (and reset) the statistics. This makes it difficult to ensure a maximum size on the statistics as the caller has no introspection into whether the number of unique connections is getting too large. Invert the control flow such that a *connstats.Statistics is registered with tstun.Wrapper and magicsock.Conn. Methods on non-nil *connstats.Statistics are called for every packet. This allows the implementation of connstats.Statistics (in the future) to better control when it needs to flush to ensure bounds on maximum sizes. The value registered into tstun.Wrapper and magicsock.Conn could be an interface, but that has two performance detriments: 1. Method calls on interface values are more expensive since they must go through a virtual method dispatch. 2. The implementation would need a sync.Mutex to protect the statistics value instead of using an atomic.Pointer. Given that methods on constats.Statistics are called for every packet, we want reduce the CPU cost on this hot path. Signed-off-by: Joe Tsai <joetsai@digital-static.net>		2 years ago
..
bench	all: fix more resource leaks found by staticmajor	2 years ago
filter	all: fix spelling mistakes	2 years ago
magicsock	net/connstats: invert network logging data flow (#6272)	2 years ago
monitor	util/set: add new set package for SetHandle type	2 years ago
netlog	net/connstats: invert network logging data flow (#6272)	2 years ago
netstack	ipn/ipnlocal: call checkPrefs in Start too	2 years ago
router	cmd/tailscaled, wgengine/router: use wingoes/com for COM initialization instead of go-ole	2 years ago
wgcfg	types/logid: move logtail ID types here (#6336)	2 years ago
wgint	go.mod, wgengine/wgint: bump wireguard-go	2 years ago
wglog	all: use syncs.AtomicValue	2 years ago
winnet	all: remove old +build tags	2 years ago
mem_ios.go	go.mod: upgrade wireguard-windows, de-fork wireguard-go	4 years ago
pendopen.go	wgengine: remove all peer status from open timeout diagnostics	2 years ago
userspace.go	wgengine: respect --no-logs-no-support flag for network logging (#6172)	2 years ago
userspace_ext_test.go	go.mod: upgrade wireguard-windows, de-fork wireguard-go	4 years ago
userspace_test.go	all: convert more code to use net/netip directly	2 years ago
watchdog.go	all: remove old +build tags	2 years ago
watchdog_js.go	wasm: drop pprof dependency	2 years ago
watchdog_test.go	wgengine: remove all peer status from open timeout diagnostics	2 years ago
wgengine.go	wgengine: fix typo in Engine.PeerForIP (#5912)	2 years ago