You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Nick Hill 17335d2104 net/dns/resolver: forward SERVFAIL responses over PeerDNS ... As per the docstring, (*forwarder).forwardWithDestChan should either send to responseChan and returns nil, or returns a non-nil error (without sending to the channel). However, this does not hold when all upstream DNS servers replied with an error. We've been handling this special error path in (*Resolver).Query but not in (*Resolver).HandlePeerDNSQuery. As a result, SERVFAIL responses from upstream servers were being converted into HTTP 503 responses, instead of being properly forwarded as SERVFAIL within a successful HTTP response, as per RFC 8484, section 4.2.1: A successful HTTP response with a 2xx status code (see Section 6.3 of [RFC7231]) is used for any valid DNS response, regardless of the DNS response code. For example, a successful 2xx HTTP status code is used even with a DNS message whose DNS response code indicates failure, such as SERVFAIL or NXDOMAIN. In this PR we fix (*forwarder).forwardWithDestChan to no longer return an error when it sends a response to responseChan, and remove the special handling in (*Resolver).Query, as it is no longer necessary. Updates #13571 Signed-off-by: Nick Hill <mykola.khyl@gmail.com>		3 weeks ago
..
art	…
captivedetection	…
connstats	…
dns	net/dns/resolver: forward SERVFAIL responses over PeerDNS	3 weeks ago
dnscache	…
dnsfallback	…
flowtrack	…
ipset	…
ktimeout	…
memnet	…
netaddr	…
netcheck	…
neterror	…
netkernelconf	…
netknob	…
netmon	…
netns	…
netstat	…
netutil	…
packet	…
ping	…
portmapper	…
proxymux	…
routetable	…
socks5	…
sockstats	…
speedtest	…
stun	…
stunserver	…
tcpinfo	…
tlsdial	…
tsaddr	…
tsdial	…
tshttpproxy	…
tstun	…
wsconn	…