You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/cmd
Nick Khyl 961ee321e8 ipn/{ipnauth,ipnlocal,ipnserver,localapi}: start baby step toward moving access checks from the localapi.Handler to the LocalBackend
Currently, we use PermitRead/PermitWrite/PermitCert permission flags to determine which operations are allowed for a LocalAPI client.
These checks are performed when localapi.Handler handles a request. Additionally, certain operations (e.g., changing the serve config)
requires the connected user to be a local admin. This approach is inherently racey and is subject to TOCTOU issues.
We consider it to be more critical on Windows environments, which are inherently multi-user, and therefore we prevent more than one
OS user from connecting and utilizing the LocalBackend at the same time. However, the same type of issues is also applicable to other
platforms when switching between profiles that have different OperatorUser values in ipn.Prefs.

We'd like to allow more than one Windows user to connect, but limit what they can see and do based on their access rights on the device
(e.g., an local admin or not) and to the currently active LoginProfile (e.g., owner/operator or not), while preventing TOCTOU issues on Windows
and other platforms. Therefore, we'd like to pass an actor from the LocalAPI to the LocalBackend to represent the user performing the operation.
The LocalBackend, or the profileManager down the line, will then check the actor's access rights to perform a given operation on the device
and against the current (and/or the target) profile.

This PR does not change the current permission model in any way, but it introduces the concept of an actor and includes some preparatory
work to pass it around. Temporarily, the ipnauth.Actor interface has methods like IsLocalSystem and IsLocalAdmin, which are only relevant
to the current permission model. It also lacks methods that will actually be used in the new model. We'll be adding these gradually in the next
PRs and removing the deprecated methods and the Permit* flags at the end of the transition.

Updates tailscale/corp#18342

Signed-off-by: Nick Khyl <nickk@tailscale.com>
2 months ago
..
addlicense all: update tools that manage copyright headers 2 years ago
build-webclient client/web: precompress assets 11 months ago
cloner cmd/cloner, cmd/viewer, util/codegen: add support for aliases of cloneable types 3 months ago
connector-gen cmd/connector-gen: add helper tool for wide app connector configurations 11 months ago
containerboot cmd/containerboot: optionally serve health check endpoint (#12899) 3 months ago
derper usermetric: add initial user-facing metrics 3 months ago
derpprobe cmd/derpprobe: use a status page from the prober library 3 months ago
dist release/dist/qnap: add qnap target builder 7 months ago
get-authkey util/cmpx: delete now that we're using Go 1.22 9 months ago
gitops-pusher cmd/gitops-pusher: ignore previous etag if local acls match control (#13068) 3 months ago
hello cmd/hello: link to the Hello KB article (#11022) 9 months ago
k8s-nameserver cmd/k8s-nameserver: fix AAAA record query response (#12412) 5 months ago
k8s-operator ipn/{ipnauth,ipnlocal,ipnserver,localapi}: start baby step toward moving access checks from the localapi.Handler to the LocalBackend 2 months ago
mkmanifest cmd/mkmanifest, cmd/tailscale, cmd/tailscaled: remove Windows arm32 resources from OSS 2 years ago
mkpkg go.mod: upgrade nfpm to v2 (#8786) 1 year ago
mkversion version/mkversion: open-source version generation logic 2 years ago
nardump all: update copyright and license headers 2 years ago
natc go.mod: bump bart 4 months ago
netlogfmt all: use Go 1.22 range-over-int 7 months ago
nginx-auth tailcfg,all: add and use Node.IsTagged() 2 years ago
pgproxy tsnet: split user facing and backend logging 6 months ago
printdep cmd/printdep: print correct toolchain URL 2 years ago
proxy-to-grafana cmd/proxy-to-grafana: add flag for alternative control server 5 months ago
sniproxy all: use math/rand/v2 more 5 months ago
speedtest all: update copyright and license headers 2 years ago
ssh-auth-none-demo all: replace deprecated ioutil references 1 year ago
stunc cmd/stunc: support user-specified port (#12469) 5 months ago
stund tsweb/varz: remove pprof 3 months ago
stunstamp cmd/stunstamp: refactor connection construction (#13110) 3 months ago
sync-containers all: adjust some build tags for plan9 1 year ago
systray cmd/systray: set ipn.NotifyNoPrivateKeys, permit non-operator use 3 months ago
tailscale usermetric: add initial user-facing metrics 3 months ago
tailscaled ipn/{ipnauth,ipnlocal,ipnserver,localapi}: start baby step toward moving access checks from the localapi.Handler to the LocalBackend 2 months ago
testcontrol all: use Go 1.22 range-over-int 7 months ago
testwrapper cmd/testwrapper: apply results of all unit tests to coverage for all packages 9 months ago
tl-longchain cmd/tl-longchain: tool to re-sign nodes with long rotation signatures 3 months ago
tsconnect all: use math/rand/v2 more 5 months ago
tsidp cmd/tsidp: add funnel support (#12591) 3 months ago
tsshd all: update copyright and license headers 2 years ago
tta cmd/tta: pull out test driver dialing into a type, fix bugs 3 months ago
viewer cmd/cloner, cmd/viewer, util/codegen: add support for aliases of cloneable types 3 months ago
vnet tstest/natlab/vnet: add start of IPv6 support 3 months ago
xdpderper all: add test for package comments, fix, add comments as needed 4 months ago