You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/net/captivedetection
Andrea Gottardo 949b15d858
net/captivedetection: call SetHealthy once connectivity restored (#12974)
Fixes tailscale/tailscale#12973
Updates tailscale/tailscale#1634

There was a logic issue in the captive detection code we shipped in https://github.com/tailscale/tailscale/pull/12707.

Assume a captive portal has been detected, and the user notified. Upon switching to another Wi-Fi that does *not* have a captive portal, we were issuing a signal to interrupt any pending captive detection attempt. However, we were not also setting the `captive-portal-detected` warnable to healthy. The result was that any "captive portal detected" alert would not be cleared from the UI.

Also fixes a broken log statement value.

Signed-off-by: Andrea Gottardo <andrea@gottardo.me>
4 months ago
..
captivedetection.go net/captivedetection: call SetHealthy once connectivity restored (#12974) 4 months ago
captivedetection_test.go health: introduce captive-portal-detected Warnable (#12707) 4 months ago
endpoints.go health: introduce captive-portal-detected Warnable (#12707) 4 months ago
rawconn.go health: introduce captive-portal-detected Warnable (#12707) 4 months ago
rawconn_apple.go health: introduce captive-portal-detected Warnable (#12707) 4 months ago