// Copyright (c) Tailscale Inc & AUTHORS // SPDX-License-Identifier: BSD-3-Clause package clientupdate import ( "fmt" "os" "path/filepath" "testing" ) func TestUpdateDebianAptSourcesListBytes(t *testing.T) { tests := []struct { name string toTrack string in string want string // empty means want no change wantErr string }{ { name: "stable-to-unstable", toTrack: UnstableTrack, in: "# Tailscale packages for debian buster\ndeb https://pkgs.tailscale.com/stable/debian bullseye main\n", want: "# Tailscale packages for debian buster\ndeb https://pkgs.tailscale.com/unstable/debian bullseye main\n", }, { name: "stable-unchanged", toTrack: StableTrack, in: "# Tailscale packages for debian buster\ndeb https://pkgs.tailscale.com/stable/debian bullseye main\n", }, { name: "if-both-stable-and-unstable-dont-change", toTrack: StableTrack, in: "# Tailscale packages for debian buster\n" + "deb https://pkgs.tailscale.com/stable/debian bullseye main\n" + "deb https://pkgs.tailscale.com/unstable/debian bullseye main\n", }, { name: "if-both-stable-and-unstable-dont-change-unstable", toTrack: UnstableTrack, in: "# Tailscale packages for debian buster\n" + "deb https://pkgs.tailscale.com/stable/debian bullseye main\n" + "deb https://pkgs.tailscale.com/unstable/debian bullseye main\n", }, { name: "signed-by-form", toTrack: UnstableTrack, in: "# Tailscale packages for ubuntu jammy\ndeb [signed-by=/usr/share/keyrings/tailscale-archive-keyring.gpg] https://pkgs.tailscale.com/stable/ubuntu jammy main\n", want: "# Tailscale packages for ubuntu jammy\ndeb [signed-by=/usr/share/keyrings/tailscale-archive-keyring.gpg] https://pkgs.tailscale.com/unstable/ubuntu jammy main\n", }, { name: "unsupported-lines", toTrack: UnstableTrack, in: "# Tailscale packages for ubuntu jammy\ndeb [signed-by=/usr/share/keyrings/tailscale-archive-keyring.gpg] https://pkgs.tailscale.com/foobar/ubuntu jammy main\n", wantErr: "unexpected/unsupported /etc/apt/sources.list.d/tailscale.list contents", }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { newContent, err := updateDebianAptSourcesListBytes([]byte(tt.in), tt.toTrack) if err != nil { if err.Error() != tt.wantErr { t.Fatalf("error = %v; want %q", err, tt.wantErr) } return } if tt.wantErr != "" { t.Fatalf("got no error; want %q", tt.wantErr) } var gotChange string if string(newContent) != tt.in { gotChange = string(newContent) } if gotChange != tt.want { t.Errorf("wrong result\n got: %q\nwant: %q", gotChange, tt.want) } }) } } func TestParseSoftwareupdateList(t *testing.T) { tests := []struct { name string input []byte want string }{ { name: "update-at-end-of-list", input: []byte(` Software Update Tool Finding available software Software Update found the following new or updated software: * Label: MacBookAirEFIUpdate2.4-2.4 Title: MacBook Air EFI Firmware Update, Version: 2.4, Size: 3817K, Recommended: YES, Action: restart, * Label: ProAppsQTCodecs-1.0 Title: ProApps QuickTime codecs, Version: 1.0, Size: 968K, Recommended: YES, * Label: Tailscale-1.23.4 Title: The Tailscale VPN, Version: 1.23.4, Size: 1023K, Recommended: YES, `), want: "Tailscale-1.23.4", }, { name: "update-in-middle-of-list", input: []byte(` Software Update Tool Finding available software Software Update found the following new or updated software: * Label: MacBookAirEFIUpdate2.4-2.4 Title: MacBook Air EFI Firmware Update, Version: 2.4, Size: 3817K, Recommended: YES, Action: restart, * Label: Tailscale-1.23.5000 Title: The Tailscale VPN, Version: 1.23.4, Size: 1023K, Recommended: YES, * Label: ProAppsQTCodecs-1.0 Title: ProApps QuickTime codecs, Version: 1.0, Size: 968K, Recommended: YES, `), want: "Tailscale-1.23.5000", }, { name: "update-not-in-list", input: []byte(` Software Update Tool Finding available software Software Update found the following new or updated software: * Label: MacBookAirEFIUpdate2.4-2.4 Title: MacBook Air EFI Firmware Update, Version: 2.4, Size: 3817K, Recommended: YES, Action: restart, * Label: ProAppsQTCodecs-1.0 Title: ProApps QuickTime codecs, Version: 1.0, Size: 968K, Recommended: YES, `), want: "", }, { name: "decoy-in-list", input: []byte(` Software Update Tool Finding available software Software Update found the following new or updated software: * Label: MacBookAirEFIUpdate2.4-2.4 Title: MacBook Air EFI Firmware Update, Version: 2.4, Size: 3817K, Recommended: YES, Action: restart, * Label: Malware-1.0 Title: * Label: Tailscale-0.99.0, Version: 1.0, Size: 968K, Recommended: NOT REALLY TBH, `), want: "", }, } for _, test := range tests { t.Run(test.name, func(t *testing.T) { got := parseSoftwareupdateList(test.input) if test.want != got { t.Fatalf("got %q, want %q", got, test.want) } }) } } func TestUpdateYUMRepoTrack(t *testing.T) { tests := []struct { desc string before string track string after string rewrote bool wantErr bool }{ { desc: "same track", before: ` [tailscale-stable] name=Tailscale stable baseurl=https://pkgs.tailscale.com/stable/fedora/$basearch enabled=1 type=rpm repo_gpgcheck=1 gpgcheck=0 gpgkey=https://pkgs.tailscale.com/stable/fedora/repo.gpg `, track: StableTrack, after: ` [tailscale-stable] name=Tailscale stable baseurl=https://pkgs.tailscale.com/stable/fedora/$basearch enabled=1 type=rpm repo_gpgcheck=1 gpgcheck=0 gpgkey=https://pkgs.tailscale.com/stable/fedora/repo.gpg `, }, { desc: "change track", before: ` [tailscale-stable] name=Tailscale stable baseurl=https://pkgs.tailscale.com/stable/fedora/$basearch enabled=1 type=rpm repo_gpgcheck=1 gpgcheck=0 gpgkey=https://pkgs.tailscale.com/stable/fedora/repo.gpg `, track: UnstableTrack, after: ` [tailscale-unstable] name=Tailscale unstable baseurl=https://pkgs.tailscale.com/unstable/fedora/$basearch enabled=1 type=rpm repo_gpgcheck=1 gpgcheck=0 gpgkey=https://pkgs.tailscale.com/unstable/fedora/repo.gpg `, rewrote: true, }, { desc: "non-tailscale repo file", before: ` [fedora] name=Fedora $releasever - $basearch #baseurl=http://download.example/pub/fedora/linux/releases/$releasever/Everything/$basearch/os/ metalink=https://mirrors.fedoraproject.org/metalink?repo=fedora-$releasever&arch=$basearch enabled=1 countme=1 metadata_expire=7d repo_gpgcheck=0 type=rpm gpgcheck=1 gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-$releasever-$basearch skip_if_unavailable=False `, track: StableTrack, wantErr: true, }, } for _, tt := range tests { t.Run(tt.desc, func(t *testing.T) { path := filepath.Join(t.TempDir(), "tailscale.repo") if err := os.WriteFile(path, []byte(tt.before), 0644); err != nil { t.Fatal(err) } rewrote, err := updateYUMRepoTrack(path, tt.track) if err == nil && tt.wantErr { t.Fatal("got nil error, want non-nil") } if err != nil && !tt.wantErr { t.Fatalf("got error %q, want nil", err) } if err != nil { return } if rewrote != tt.rewrote { t.Errorf("got rewrote flag %v, want %v", rewrote, tt.rewrote) } after, err := os.ReadFile(path) if err != nil { t.Fatal(err) } if string(after) != tt.after { t.Errorf("got repo file after update:\n%swant:\n%s", after, tt.after) } }) } } func TestParseAlpinePackageVersion(t *testing.T) { tests := []struct { desc string out string want string wantErr bool }{ { desc: "valid version", out: ` tailscale-1.44.2-r0 description: The easiest, most secure way to use WireGuard and 2FA tailscale-1.44.2-r0 webpage: https://tailscale.com/ tailscale-1.44.2-r0 installed size: 32 MiB `, want: "1.44.2", }, { desc: "wrong package output", out: ` busybox-1.36.1-r0 description: Size optimized toolbox of many common UNIX utilities busybox-1.36.1-r0 webpage: https://busybox.net/ busybox-1.36.1-r0 installed size: 924 KiB `, wantErr: true, }, { desc: "missing version", out: ` tailscale description: The easiest, most secure way to use WireGuard and 2FA tailscale webpage: https://tailscale.com/ tailscale installed size: 32 MiB `, wantErr: true, }, { desc: "empty output", out: "", wantErr: true, }, } for _, tt := range tests { t.Run(tt.desc, func(t *testing.T) { got, err := parseAlpinePackageVersion([]byte(tt.out)) if err == nil && tt.wantErr { t.Fatalf("got nil error and version %q, want non-nil error", got) } if err != nil && !tt.wantErr { t.Fatalf("got error: %q, want nil", err) } if got != tt.want { t.Fatalf("got version: %q, want %q", got, tt.want) } }) } } func TestSynoArch(t *testing.T) { tests := []struct { goarch string synoinfoUnique string want string wantErr bool }{ {goarch: "amd64", synoinfoUnique: "synology_x86_224", want: "x86_64"}, {goarch: "arm64", synoinfoUnique: "synology_armv8_124", want: "armv8"}, {goarch: "386", synoinfoUnique: "synology_i686_415play", want: "i686"}, {goarch: "arm", synoinfoUnique: "synology_88f6281_213air", want: "88f6281"}, {goarch: "arm", synoinfoUnique: "synology_88f6282_413j", want: "88f6282"}, {goarch: "arm", synoinfoUnique: "synology_hi3535_NVR1218", want: "hi3535"}, {goarch: "arm", synoinfoUnique: "synology_alpine_1517", want: "alpine"}, {goarch: "arm", synoinfoUnique: "synology_armada370_216se", want: "armada370"}, {goarch: "arm", synoinfoUnique: "synology_armada375_115", want: "armada375"}, {goarch: "arm", synoinfoUnique: "synology_armada38x_419slim", want: "armada38x"}, {goarch: "arm", synoinfoUnique: "synology_armadaxp_RS815", want: "armadaxp"}, {goarch: "arm", synoinfoUnique: "synology_comcerto2k_414j", want: "comcerto2k"}, {goarch: "arm", synoinfoUnique: "synology_monaco_216play", want: "monaco"}, {goarch: "ppc64", synoinfoUnique: "synology_qoriq_413", wantErr: true}, } for _, tt := range tests { t.Run(fmt.Sprintf("%s-%s", tt.goarch, tt.synoinfoUnique), func(t *testing.T) { synoinfoConfPath := filepath.Join(t.TempDir(), "synoinfo.conf") if err := os.WriteFile( synoinfoConfPath, []byte(fmt.Sprintf("unique=%q\n", tt.synoinfoUnique)), 0600, ); err != nil { t.Fatal(err) } got, err := synoArch(tt.goarch, synoinfoConfPath) if err != nil { if !tt.wantErr { t.Fatalf("got unexpected error %v", err) } return } if tt.wantErr { t.Fatalf("got %q, expected an error", got) } if got != tt.want { t.Errorf("got %q, want %q", got, tt.want) } }) } } func TestParseSynoinfo(t *testing.T) { tests := []struct { desc string content string want string wantErr bool }{ { desc: "double-quoted", content: ` company_title="Synology" unique="synology_88f6281_213air" `, want: "88f6281", }, { desc: "single-quoted", content: ` company_title="Synology" unique='synology_88f6281_213air' `, want: "88f6281", }, { desc: "unquoted", content: ` company_title="Synology" unique=synology_88f6281_213air `, want: "88f6281", }, { desc: "missing unique", content: ` company_title="Synology" `, wantErr: true, }, { desc: "empty unique", content: ` company_title="Synology" unique= `, wantErr: true, }, { desc: "empty unique double-quoted", content: ` company_title="Synology" unique="" `, wantErr: true, }, { desc: "empty unique single-quoted", content: ` company_title="Synology" unique='' `, wantErr: true, }, { desc: "malformed unique", content: ` company_title="Synology" unique="synology_88f6281" `, wantErr: true, }, { desc: "empty file", content: ``, wantErr: true, }, { desc: "empty lines and comments", content: ` # In a file named synoinfo? Shocking! company_title="Synology" # unique= is_a_field_that_follows unique="synology_88f6281_213air" `, want: "88f6281", }, } for _, tt := range tests { t.Run(tt.desc, func(t *testing.T) { synoinfoConfPath := filepath.Join(t.TempDir(), "synoinfo.conf") if err := os.WriteFile(synoinfoConfPath, []byte(tt.content), 0600); err != nil { t.Fatal(err) } got, err := parseSynoinfo(synoinfoConfPath) if err != nil { if !tt.wantErr { t.Fatalf("got unexpected error %v", err) } return } if tt.wantErr { t.Fatalf("got %q, expected an error", got) } if got != tt.want { t.Errorf("got %q, want %q", got, tt.want) } }) } }