4 Commits (edcbb5394e1de2d2653d7038621e73f210c7d850)

Author	SHA1	Message	Date
David Anderson	5a32f8e181	wgengine/router: also accept exit code 254 from `ip rule del`. ... iproute2 3.16.0-2 from Debian Jessie (oldoldstable) doesn't return exit code 2 when deleting a non-existent IP rule. Fixes #434 Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago
David Anderson	fff062b461	wgengine/router: make runner.go linux-only for now. ... Otherwise, staticcheck complains that these functions are unused and unexported on macOS. Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago
Avery Pennarun	a496cdc943	router_linux: remove need for iptables.ListChains(). ... Instead of retrieving the list of chains, or the list of rules in a chain, just try deleting the ones we don't want and then adding the ones we do want. An error in flushing/deleting still means the rule doesn't exist anymore, so there was no need to check for it first. This avoids the need to parse iptables output, which avoids the need to ever call iptables -S, which fixes #403, among other things. It's also much more future proof in case the iptables command line changes. Unfortunately the iptables go module doesn't properly pass the iptables command exit code back up when doing .Delete(), so we can't correctly check the exit code there. (exit code 1 really means the rule didn't exist, rather than some other weird problem). Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	8a6bd21baf	router_linux: extract process runner routines into runner.go. ... These will probably be useful across platforms. They're not really Linux-specific at all. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago