11 Commits (bf2d3cd07471cb0501343f694594b3e0b0e3db18)

Author	SHA1	Message	Date
Xe Iaso	3564fd61b5	cmd/gitops-pusher: standardize hujson before posting to validate (#5525) ... Apparently the validate route doesn't check content-types or handle hujson with comments correctly. This patch makes gitops-pusher convert the hujson to normal json. Signed-off-by: Xe <xe@tailscale.com> Signed-off-by: Xe <xe@tailscale.com>	2 years ago
Xe Iaso	122bd667dc	cmd/gitops-pusher: be less paranoid about external modifications (#5488) ... This makes a "modified externally" error turn into a "modified externally" warning. It means CI won't fail if someone does something manually in the admin console. Signed-off-by: Xe <xe@tailscale.com>	2 years ago
Xe Iaso	904723691b	cmd/gitops-pusher: things i forgot to push last PR (#5128) ... Signed-off-by: Xe <xe@tailscale.com>	2 years ago
Xe Iaso	898695e312	cmd/gitops-pusher: add etag cache file for the three version problem (#5124) ... This allows gitops-pusher to detect external ACL changes. I'm not sure what to call this problem, so I've been calling it the "three version problem" in my notes. The basic problem is that at any given time we only have two versions of the ACL file at any given point: the version in CONTROL and the one in the git repo. In order to check if there has been tampering of the ACL files in the admin panel, we need to have a _third_ version to compare against. In this case I am not storing the old ACL entirely (though that could be a reasonable thing to add in the future), but only its sha256sum. This allows us to detect if the shasum in control matches the shasum we expect, and if that expectation fails, then we can react accordingly. This will require additional configuration in CI, but I'm sure that can be done. Signed-off-by: Xe <xe@tailscale.com>	2 years ago
Xe Iaso	92357a54ec	cmd/gitops-pusher: fix minor bug with ACL tests (#5123) ... Signed-off-by: Xe <xe@tailscale.com>	2 years ago
Xe Iaso	90ccba6730	cmd/gitops-pusher: port to use ffcli (#5113) ... Signed-off-by: Xe <xe@tailscale.com>	2 years ago
Xe Iaso	41e60dae80	cmd/gitops-pusher: use fmt.Println for errors (#5112) ... Signed-off-by: Xe <xe@tailscale.com>	2 years ago
Xe Iaso	004f0ca3e0	cmd/gitops-pusher: format HuJSON, enabling exact ACL matches (#5061) ... Signed-off-by: Xe <xe@tailscale.com>	2 years ago
Xe Iaso	16c85d0dc5	cmd/gitops-pusher: support GitHub Actions error syntax (#5060) ... GitHub Actions lets you annotate lines in files as errors[1]. This syntax will only fire on syntax errors. Future improvements can extend this to properly annotate ACL tests too. [1]: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-error-message Signed-off-by: Xe <xe@tailscale.com>	2 years ago
Xe Iaso	5bb44a4a5c	cmd/gitops-pusher: correctly handle ACL tests failing (#5016) ... Apparently the API for running ACL tests returns a 200 if the ACL tests fail. This is weird, but we can handle it. Signed-off-by: Xe <xe@tailscale.com>	2 years ago
Xe Iaso	dee95d0894	cmd/gitops-pusher: add new GitOps assistant (#4893) ... This is for an upcoming blogpost on how to manage Tailscale ACLs using a GitOps flow. This tool is intended to be used in CI and will allow users to have a git repository be the ultimate source of truth for their ACL file. This enables ACL changes to be proposed, approved and discussed before they are applied. Signed-off-by: Xe <xe@tailscale.com>	2 years ago