313 Commits (b89c11336514d541ad25de564dcf0561c0b24e58)

Author	SHA1	Message	Date
Brad Fitzpatrick	01e159b610	ipn/ipnlocal: save prefs to disk on UpdatePrefs ... Regression from 6d10655dc3, which added UpdatePrefs but didn't write it out to disk. I'd planned on adding tests to state_test.go which is why I'd earlier added 46896a9311 to prepare for making such persistence tests easier to write, but turns out state_test.go didn't even test UpdatePrefs, so I'm staying out of there. Instead, this is tested using integration tests. Fixes #2321 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	5b845631ce	tstest/integration/vms: delete a log file i was using to debug the tests (#2416) ... Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	ede8ec1e20	tstest/integration/vms: split up test framework into files (#2396) ... My spatial memory functions poorly with large files and the vms_test.go file recently surpassed the point where it functions adequately. This patch splits up vms_test.go into more files to make my spatial memory function like I need it to. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	1f2a877c61	tstest/integration/testcontrol: add ipv6 support (#2394) ... Split from https://github.com/tailscale/tailscale/pull/2376. This adds IPv6 support to testcontrol so each member of the tailscale network gets an IPv6 address too. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	1b1c85d069	Revert "Revert "tstest/integration/vms: end-to-end UDP test (#2361)" (#2364)" (#2365) ... This reverts commit 254fc7885b. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Simeng He	3d049a9d71	tstest/integration: change return type of AwaitIP from string to netaddr.IP ... Signed-off-by: Simeng He <simeng@tailscale.com>	3 years ago
Brad Fitzpatrick	7e7c4c1bbe	tailcfg: break DERPNode.DERPTestPort into DERPPort & InsecureForTests ... The DERPTestPort int meant two things before: which port to use, and whether to disable TLS verification. Users would like to set the port without disabling TLS, so break it into two options. Updates #1264 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	afbd35482d	tstest/integration/vms: add NixOS unstable back (#2330) ... The upstream NixOS issue was fixed. https://github.com/NixOS/nixpkgs/issues/128783 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	33cacb5284	tstest/integration/vms: unbreak nixos builds (#2372) ... To avoid the generated nixos disk images from becoming immune from the GC, I delete the symlink to the nix store at the end of tests. `t.Cleanup` runs at the end of a test. I changed this part of the code to have a separate timer for how long it takes to run NixOS builds, but I did that by using a subtest. This means that it was creating the NixOS image, deleting its symlink and then trying to use that symlink to find the resulting disk image, making the whole thing ineffectual. This was a mistake. I am reverting this change made in https://github.com/tailscale/tailscale/pull/2360 to remove this layer of subtesting. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	254fc7885b	Revert "tstest/integration/vms: end-to-end UDP test (#2361)" (#2364) ... This reverts commit dc78be12c5.	3 years ago
Christine Dodrill	dc78be12c5	tstest/integration/vms: end-to-end UDP test (#2361) ... This tests incoming and outgoing UDP traffic. It would test incoming UDP traffic however our socks server doesn't seem to allow for connecting to destinations over UDP. When the socks server gets that support the incoming test should pass without issue. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	a19eea965f	tstest/integration/vms: use an in-process logcatcher (#2360) ... This adapts the existing in-process logcatcher from tstest/integration into a public type and uses it on the side of testcontrol. This also fixes a bug in the Alpine Linux OpenRC unit that makes every value in `/etc/default/tailscaled` exported into tailscaled's environment, a-la systemd [Service].EnviromentFile. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	1e83b97498	tstest/integration/vms: outgoing SSH test (#2349) ... This does a few things: 1. Rewrites the tests so that we get a log of what individual tests failed at the end of a test run. 2. Adds a test that runs an HTTP server via the tester tailscale node and then has the VMs connect to that over Tailscale. 3. Dials the VM over Tailscale and ensures it answers SSH requests. 4. Other minor framework refactoring. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	97279a0fe0	tstest/integration/vms: add Oracle Linux image (#2328) ... Oracle Linux[1] is a CentOS fork. It is not very special. I am adding it to the integration jungle because I am adding it to pkgs and the website directions. [1]: https://www.oracle.com/linux/ Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Brad Fitzpatrick	7d417586a8	tstest/integration: help bust cmd/go's test caching ... It was caching too aggressively, as it didn't see our deps due to our running "go install tailscaled" as a child process. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	a8360050e7	tstest/integration/vms: make first end to end test (#2332) ... This makes sure `tailscale status` and `tailscale ping` works. It also switches goexpect to use a batch instead of manually banging out each line, which makes the tests so much easier to read. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	5813da885c	tstest/integration/vms: verbosify nixos logs to fs, disable unstable (#2294) ... This puts nix build logs on the filesystem so that we can debug them later. This also disables nixos unstable until https://github.com/NixOS/nixpkgs/issues/128783 is fixed. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
julianknodt	506c2fe8e2	cmd/tailscale: make netcheck use active DERP map, delete static copy ... After allowing for custom DERP maps, it's convenient to be able to see their latency in netcheck. This adds a query to the local tailscaled for the current DERPMap. Updates #1264 Signed-off-by: julianknodt <julianknodt@gmail.com>	3 years ago
Brad Fitzpatrick	5e19ac7adc	tstest/integration: always run SOCK5 server, parse out its listening address ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	b131a74f99	tstest/integration/vms: build and run NixOS (#2190) ... Okay, so, at a high level testing NixOS is a lot different than other distros due to NixOS' determinism. Normally NixOS wants packages to be defined in either an overlay, a custom packageOverrides or even yolo-inline as a part of the system configuration. This is going to have us take a different approach compared to other distributions. The overall plan here is as following: 1. make the binaries as normal 2. template in their paths as raw strings to the nixos system module 3. run `nixos-generators -f qcow -o $CACHE_DIR/tailscale/nixos/version -c generated-config.nix` 4. pass that to the steps that make the virtual machine It doesn't really make sense for us to use a premade virtual machine image for this as that will make it harder to deterministically create the image. Nix commands generate a lot of output, so their output is hidden behind the `-verbose-nix-output` flag. This unfortunately makes this test suite have a hard dependency on Nix/NixOS, however the test suite has only ever been run on NixOS (and I am not sure if it runs on other distros at all), so this probably isn't too big of an issue. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	194d5b8412	tstest/integration/vms: add in-process DERP server (#2108) ... Previously this test would reach out to the public DERP servers in order to help machines connect with eachother. This is not ideal given our plans to run these tests completely disconnected from the internet. This patch introduces an in-process DERP server running on its own randomly assigned HTTP port. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	6b234323a0	tstest/integration/vms: fix flake when testing (#2145) ... Occasionally the test framework would fail with a timeout due to a virtual machine not phoning home in time. This seems to be happen whenever qemu can't bind the VNC or SSH ports for a virtual machine. This was fixed by taking the following actions: 1. Don't listen on VNC unless the `-use-vnc` flag is passed, this removes the need to listen on VNC at all in most cases. The option to use VNC is still left in for debugging virtual machines, but removing this makes it easier to deal with (VNC uses this odd system of "displays" that are mapped to ports above 5900, and qemu doesn't offer a decent way to use a normal port number, so we just disable VNC by default as a compromise). 2. Use a (hopefully) inactive port for SSH. In an ideal world I'd just have the VM's SSH port be exposed via a Unix socket, however the QEMU documentation doesn't really say if you can do this or not. While I do more research, this stopgap will have to make do. 3. Strictly tie more VM resource lifetimes to the tests themselves. Previously the disk image layers for virtual machines were only cleaned up at the end of the test and existed in the parent test-scoped temporary folder. This can make your tmpfs run out of space, which is not ideal. This should minimize the use of temporary storage as much as I know how to. 4. Strictly tie the qemu process lifetime to the lifetime of the test using testing.T#Cleanup. Previously it used a defer statement to clean up the qemu process, however if the tests timed out this defer was not run. This left around an orphaned qemu process that had to be killed manually. This change ensures that all qemu processes exit when their relevant tests finish. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Brad Fitzpatrick	45e64f2e1a	net/dns{,/resolver}: refactor DNS forwarder, send out of right link on macOS/iOS ... Fixes #2224 Fixes tailscale/corp#2045 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	a0c632f6b5	tstest/integration: fix a race ... Noticed on a CI failure. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
David Crawshaw	297b3d6fa4	staticcheck.conf: turn off noisy lint errors ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
Brad Fitzpatrick	2f4817fe20	tstest/integration: fix race flake ... Fixes #2172 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	e0f0d10672	tstest/integration/vms: log to t.Logf directly (#2147) ... Previously we used t.Logf indirectly via package log. This worked, but it was not ideal for our needs. It could cause the streams of output to get crossed. This change uses a logger.FuncWriter every place log.Output was previously used, which will more correctly write log information to the right test output stream. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Brad Fitzpatrick	082cc1b0a7	tstest/integration: reenable TestAddPingRequest ... Failure understood now; see: https://github.com/tailscale/tailscale/pull/2088#issuecomment-859896598 As of 333e9e75d4, PingRequest is now safe for the server to send multiple times, without fear of the client handling it multiple times. Fixes #2079 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Denton Gentry	c61d777705	tstest/integration: disable TestAddPingRequest ... Failing often now, we don't want people to get used to routinely ignoring test failures. Can be re-enabled when https://github.com/tailscale/tailscale/issues/2079 is resolved. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	3 years ago
Christine Dodrill	8b2b899989	tstest/integration: test Alpine Linux (#2098) ... Alpine Linux[1] is a minimal Linux distribution built around musl libc. It boots very quickly, requires very little ram and is as close as you can get to an ideal citizen for testing Tailscale on musl. Alpine has a Tailscale package already[2], but this patch also makes it easier for us to provide an Alpine Linux package off of pkgs in the future. Alpine only offers Tailscale on the rolling-release edge branch. [1]: https://alpinelinux.org/ [2]: https://pkgs.alpinelinux.org/packages?name=tailscale&branch=edge Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Brad Fitzpatrick	0affcd4e12	tstest/integration: add some debugging for TestAddPingRequest flakes ... This fails pretty reliably with a lot of output now showing what's happening: TS_DEBUG_MAP=1 go test --failfast -v -run=Ping -race -count=20 ./tstest/integration --verbose-tailscaled I haven't dug into the details yet, though. Updates #2079	4 years ago
Brad Fitzpatrick	ee3df2f720	tstest/integration: rename ambiguous --verbose test flag ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Christine Dodrill	b402e76185	.github/workflows: add integration test with a custom runner (#2044) ... This runner is in my homelab while we muse about a better, more permanent home for these tests. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	622dc7b093	tstest/integration/vms: download images from s3 (#2035) ... This makes integration tests pull pristine VM images from Amazon S3 if they don't exist on disk. If the S3 fetch fails, it will fall back to grabbing the image from the public internet. The VM images on the public internet are known to be updated without warning and thusly change their SHA256 checksum. This is not ideal for a test that we want to be able to fire and forget, then run reliably for a very long time. This requires an AWS profile to be configured at the default path. The S3 bucket is rigged so that the requester pays. The VM images are currently about 6.9 gigabytes. Please keep this in mind when running these tests on your machine. Documentation was added to the integration test folder to aid others in running these tests on their machine. Some wording in the logs of the tests was altered. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	3f1405fa2a	tstest/integration/vms: bump images, fix caching bug (#2052) ... Before this redownloaded the image every time. Now it only redownloads it when it needs to. Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Simeng He	0141390365	tstest/integration/testcontrol: add Server.AddPingRequest ... Signed-off-by: Simeng He <simeng@tailscale.com>	4 years ago
Christine Dodrill	adaecd83c8	tstest/integration/vms: add DownloadImages test to download images (#2039) ... The image downloads can take a significant amount of time for the tests. This creates a new test that will download every distro image into the local cache in parallel, optionally matching the distribution regex. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	607b7ab692	tstest/integration/vms: aggressively re-verify shasums (#2050) ... I've run into a couple issues where the tests time out while a VM image is being downloaded, making the cache poisoned for the next run. This moves the hash checking into its own function and calls it much sooner in the testing chain. If the hash check fails, the OS is redownloaded. Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	6ce77b8eca	tstest/integration/vms: log qemu output (#2047) ... Most of the time qemu will output nothing when it is running. This is expected behavior. However when qemu is unable to start due to some problem, it prints that to either stdout or stderr. Previously this output wasn't being captured. This patch captures that output to aid in debugging qemu issues. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Brad Fitzpatrick	58cc2cc921	tstest/integration/testcontrol: add Server.nodeLocked	4 years ago
Christine Dodrill	0a655309c6	tstest/integration/vms: only build binaries once (#2042) ... Previously this built the binaries for every distro. This is a bit overkill given we are using static binaries. This patch makes us only build once. There was also a weird issue with how processes were being managed. Previously we just killed qemu with Process.Kill(), however that was leaving behind zombies. This has been mended to not only kill qemu but also waitpid() the process so it doesn't become a zombie. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	a282819026	tstest/integration/vms: fix OpenSUSE Leap 15.1 (#2038) ... The OpenSUSE 15.1 image we are using (and conseqentially the only one that is really available easily given it is EOL) has cloud-init hardcoded to use the OpenStack metadata thingy. Other OpenSUSE Leap images function fine with the NoCloud backend, but this one seems to just not work with it. No bother, we can just pretend to be OpenStack. Thanks to Okami for giving me an example OpenStack configuration seed image. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	4da5e79c39	tstest/integration/vms: test on Arch Linux (#2040) ... Arch is a bit of a weirder distro, however as a side effect it is much more of a systemd purist experience. Adding it to our test suite will make sure that we are working in the systemd happy path. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	ca96357d4b	tstest/integration/vms: add OpenSUSE Leap 15.3 (#2026) ... This distro is about to be released. OpenSUSE has historically had the least coverage for functional testing, so this may prove useful in the future. Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	2802a01b81	tstest/integration/vms: test vms as they are ready (#2022) ... Instead of testing all the VMs at once when they are all ready, this patch changes the testing logic so that the vms are tested as soon as they register with testcontrol. Also limit the amount of VM ram used at once with the `-ram-limit` flag. That uses a semaphore to guard resource use. Also document CentOS' sins. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	36cb69002a	tstest/integration/vms: regex-match distros using a flag (#2021) ... If you set `-distro-regex` to match a subset of distros, only those distros will be tested. Ex: $ go test -run-vm-tests -distro-regex='opensuse' Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	e1b994f7ed	tstest/integration/vms: maintain distro info (#2020) ... This lets us see the names of distros in our tests. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Brad Fitzpatrick	fa548c5b96	tstest/integration/vms: fix bindhost lookup (#2012) ... Don't try to do heuristics on the name. Use the net/interfaces package which we already have to do this sort of stuff. Fixes #2011 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Christine Dodrill	14c1113d2b	tstest/integration/vms: copy locally built binaries (#2006) ... Instead of pulling packages from pkgs.tailscale.com, we should use the tailscale binaries that are local to this git commit. This exposes a bit of the integration testing stack in order to copy the binaries correctly. This commit also bumps our version of github.com/pkg/sftp to the latest commit. If you run into trouble with yaml, be sure to check out the commented-out alpine linux image complete with instructions on how to use it. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Brad Fitzpatrick	f21982f854	tstest/integration/vms: skip a test for now ... Updates #2011 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Christine Dodrill	4cfaf489ac	tstest/integration/vms: t.Log for VM output (#2007) ... Previously we spewed a lot of output to stdout and stderr, even when `-v` wasn't set. This is sub-optimal for various reasons. This patch shunts that output to test logs so it only shows up when `-v` is set. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	1f72b6f812	tstest/integration/vms: use dynamically discovered bindhost (#1992) ... Instead of relying on a libvirtd bridge address that you probably won't have on your system. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	35749ec297	tstest/integration/vms: small cleanups (#1989) ... Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	ba59c0391b	tstest/integration: add experimental integration test (#1966) ... This will spin up a few vms and then try and make them connect to a testcontrol server. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
simenghe	dd0b690e7b	Added new Addresses / AllowedIPs fields to testcontrol when creating tailcfg.Node (#1948) ... * Added new Addresses / AllowedIPs fields to testcontrol when creating new &tailcfg.Node Signed-off-by: Simeng He <simeng@tailscale.com> * Added single node test to check Addresses and AllowedIPs Signed-off-by: Simeng He <simeng@tailscale.com> Co-authored-by: Simeng He <simeng@tailscale.com>	4 years ago
Josh Bleecher Snyder	25df067dd0	all: adapt to opaque netaddr types ... This commit is a mishmash of automated edits using gofmt: gofmt -r 'netaddr.IPPort{IP: a, Port: b} -> netaddr.IPPortFrom(a, b)' -w . gofmt -r 'netaddr.IPPrefix{IP: a, Port: b} -> netaddr.IPPrefixFrom(a, b)' -w . gofmt -r 'a.IP.Is4 -> a.IP().Is4' -w . gofmt -r 'a.IP.As16 -> a.IP().As16' -w . gofmt -r 'a.IP.Is6 -> a.IP().Is6' -w . gofmt -r 'a.IP.As4 -> a.IP().As4' -w . gofmt -r 'a.IP.String -> a.IP().String' -w . And regexps: \w*(.*)\.Port = (.*) -> $1 = $1.WithPort($2) \w*(.*)\.IP = (.*) -> $1 = $1.WithIP($2) And lots of manual fixups. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	5a7c6f1678	tstest/integration{,/testcontrol}: add node update support, two node test ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	d32667011d	tstest/integration: build test binaries with -race if test itself is ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	ed9d825552	tstest/integration: fix integration test on linux/386 ... Apparently can't use GOBIN with GOARCH. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	c0158bcd0b	tstest/integration{,/testcontrol}: add testcontrol.RequireAuth mode, new test ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Josh Bleecher Snyder	78d4c561b5	types/logger: add key grinder stats lines to rate-limiting exemption list ... Updates #1749 Co-authored-by: Brad Fitzpatrick <bradfitz@tailscale.com> Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	68fb51b833	tstest/integration: misc cleanups ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	3237e140c4	tstest/integration: add testNode.AwaitListening, DERP+STUN, improve proxy trap ... Updates #1840	4 years ago
Brad Fitzpatrick	98d7c28faa	tstest/integration: start factoring test types out to clean things up ... To enable easy multi-node testing (including inter-node traffic) later. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	5e9e11a77d	tstest/integration/testcontrol: add start of test control server ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	a07a504b16	tstest/integration: use go binary from runtime.GOROOT ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	f342d10dc5	tstest/integration: set an HTTP_PROXY to catch bogus requests ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	80429b97e5	testing: add start of an integration test ... Only minimal tailscale + tailscaled for now. And a super minimal in-memory logcatcher. No control ... yet. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	08782b92f7	tstest: add WaitFor helper ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Josh Bleecher Snyder	d31eff8473	tstest/natlab: use net.ErrClosed ... We are now on 1.16. And wgconn.NetErrClosed has been removed upstream. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Filippo Valsorda	39f7a61e9c	tstest/staticcheck: import the main package to fix "go mod tidy" ... Importing the non-main package was missing some dependencies that "go mod tidy" would then cleanup. Also added a non-ignore build tag to avoid other tools getting upset about importing a main package. Signed-off-by: Filippo Valsorda <hi@filippo.io>	4 years ago
Josh Bleecher Snyder	138055dd70	tstest/natlab: use net.ErrClosed instead of a new error ... Upstream wireguard-go decided to use errors.Is(err, net.ErrClosed) instead of checking the error string. It also provided an unsafe linknamed version of net.ErrClosed for clients running Go 1.15. Switch to that. This reduces the time required for the wgengine/magicsock tests on my machine from ~35s back to the ~13s it was before 456cf8a376. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	e8cd7bb66f	tstest: simplify goroutine leak tests ... Use tb.Cleanup to simplify both the API and the implementation. One behavior change: When the number of goroutines shrinks, don't log. I've never found these logs to be useful, and they frequently add noise. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	18471a8792	ipn: close logger at the end of TestLocalLogLines ... If any goroutine continues to use the logger in TestLocalLogLines after the test finishes, the test panics. The culprit for this was wireguard-go; the previous commit fixed that. This commit adds suspenders: When the test is done, make logging calls into no-ops. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	fd2a30cd32	wgengine/magicsock: make test pass on Windows and without firewall dialog box ... Updates #50	4 years ago
Josh Bleecher Snyder	e1596d655a	tstest: skip resource check when test has failed ... Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	2e40c4b564	tstest: don't log on success ... This is particularly important for benchmarks, where stray output disrupts tooling. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	7fddc33481	tstest: make LogLineTracker pass variadic format args through ... Omitting the "..." passed a literal []interface{} to the underlying logger always.	4 years ago
Brad Fitzpatrick	68c42530e9	tstest: rename LogListener to LogLineTracker ... But mostly to rename tstest.ListenFor which has no mention of log lines in it. It sounded like a net.Listener or something.	4 years ago
David Crawshaw	3baa084548	tstest: take testing.TB in helper for benchmarks ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	4 years ago
Wendi Yu	a3fb422a39	ipn: tag and test for grinder log lines (#711) ... Signed-off-by: Wendi <wendi.yu@yahoo.ca>	4 years ago
David Anderson	f794493b4f	wgengine/magicsock: explicitly check path discovery, add a firewall test. ... The test proves that active discovery can traverse two facing firewalls. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	5a370d545a	tstest/natlab: drop packets that can't be routed in a LAN. ... LANs are authoritative for their prefixes, so we should not bounce packets back and forth to the default gateway in that case. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	45578b47f3	tstest/natlab: refactor PacketHandler into a larger interface. ... The new interface lets implementors more precisely distinguish local traffic from forwarded traffic, and applies different forwarding logic within Machines for each type. This allows Machines to be packet forwarders, which didn't quite work with the implementation of Inject. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	23123907c0	tstest/natlab: add a configurable SNAT44 translator. ... This lets us implement the most common kinds of NAT in the wild. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	39ecb37fd6	tstest/natlab: support different firewall selectivities. ... Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	88e8456e9b	wgengine/magicsock: add a connectivity test for facing firewalls. ... The test demonstrates that magicsock can traverse two stateful firewalls facing each other, that each require localhost to initiate connections. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	b3d65ba943	tstest/natlab: refactor, expose a Packet type. ... HandlePacket and Inject now receive/take Packets. This is a handy container for the packet, and the attached Trace method can be used to print traces from custom packet handlers that integrate nicely with natlab's internal traces. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	5eedbcedd1	tstest/natlab: add a stateful firewall. ... The firewall provides a ProcessPacket handler, and implements an address-and-port endpoint dependent firewall that allows all traffic to egress from the trusted interface, and only allows inbound traffic if corresponding outbound traffic was previously seen. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	0ed9f62ed0	tstest/natlab: provide inbound interface to HandlePacket. ... Requires a bunch of refactoring so that Networks only ever refer to Interfaces that have been attached to them, and Interfaces know about both their Network and Machine. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	6c74065053	wgengine/magicsock, tstest/natlab: start hooking up natlab to magicsock ... Also adds ephemeral port support to natlab. Work in progress. Pairing with @danderson.	4 years ago
Brad Fitzpatrick	7883e5c5e7	go.mod: restore staticcheck module, make it stick around, go mod tidy ... It kept coming & going as different people ran go mod tidy and others ran staticcheck. Make it stop going away with go mod tidy by adding a dep to it.	4 years ago
David Anderson	0aea087766	tstest/natlab: add PacketHandler and Inject. ... Together, they can be used to plug custom packet processors into Machines. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	73db7e99ab	tstest/natlab: make Machine constructible directly. ... This is a prelude to adding more fields, which would otherwise become more unnamed function params. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	d94593e884	tstest/natlab: unregister conn4 if registration of conn6 fails. ... Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	d7bc4ec029	tstest/natlab: use common helper for conn registration. ... Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	80a14c49c6	tstest/natlab: add comments to conns4/conns6. ... Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	c53b154171	tstest/natlab: use &Network in test. ... Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	622c0d0cb3	tstest/natlab: print trace data when NATLAB_TRACE is set. ... Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	1d4f9852a7	tstest/natlab: correctly handle dual-stacked PacketConns. ... Adds a test with multiple networks, one of which is v4-only. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	771eb05bcb	tstest/natlab: first network attached becomes the default route. ... Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	f2e5da916a	tstest/natlab: allow sensible default construction of networks. ... Add a test for LAN->LAN traffic. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	97910ce712	tstest/natlab: remove unused PacketConner type	4 years ago
Brad Fitzpatrick	14b4213c17	tstest/natlab: add missing tests from earlier commits ... Now you can actually see that packet delivery works. Pairing with @danderson	4 years ago
Brad Fitzpatrick	3f4f1cfe66	tstest/natlab: basic NAT-free packet delivery works ... Pairing with @danderson	4 years ago
Brad Fitzpatrick	a477e70632	tstest/natlab: network address allocation ... Pairing with @danderson	4 years ago
Brad Fitzpatrick	bb1a9e4700	tstest/natlab: bit more of in-memory network testing package ... Pairing with @danderson	4 years ago
Brad Fitzpatrick	23c93da942	tstest/natlab: start of in-memory network testing package ... Pairing with @danderson	4 years ago
Brad Fitzpatrick	5ec7ac1d02	tstest: document PanicOnLog	5 years ago
Avery Pennarun	4f128745d8	magicsock/test: oops, fix a data race in nested-test logf hack. ... Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	08acb502e5	Add tstest.PanicOnLog(), and fix various problems detected by this. ... If a test calls log.Printf, 'go test' horrifyingly rearranges the output to no longer be in chronological order, which makes debugging virtually impossible. Let's stop that from happening by making log.Printf panic if called from any module, no matter how deep, during tests. This required us to change the default error handler in at least one http.Server, as well as plumbing a bunch of logf functions around, especially in magicsock and wgengine, but also in logtail and backoff. To add insult to injury, 'go test' also rearranges the output when a parent test has multiple sub-tests (all the sub-test's t.Logf is always printed after all the parent tests t.Logf), so we need to screw around with a special Logf that can point at the "current" t (current_t.Logf) in some places. Probably our entire way of using subtests is wrong, since 'go test' would probably like to run them all in parallel if you called t.Parallel(), but it definitely can't because the're all manipulating the shared state created by the parent test. They should probably all be separate toplevel tests instead, with common setup/teardown logic. But that's a job for another time. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	e0b666c5d2	tstest.ResourceCheck: clarify success message. ... Inclusion of the word "assert" made it seem like a failure, even though it was supposed to be identifying the name of the function (Assert()). Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
David Anderson	0038223632	tstest: rename from testy. ... Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago