tailscale

Commit Graph

Author	SHA1	Message	Date
Josh Bleecher Snyder	758c37b83d	net/netns: thread logf into control functions So that darwin can log there without panicking during tests. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Josh Bleecher Snyder	85184a58ed	wgengine/wgcfg: recover from mismatched PublicKey/Endpoints In rare circumstances (tailscale/corp#3016), the PublicKey and Endpoints can diverge. This by itself doesn't cause any harm, but our early exit in response did, because it prevented us from recovering from it. Remove the early exit. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Denton Gentry	9fc4e876e3	VERSION.txt: this is v1.19.0 Signed-off-by: Denton Gentry <dgentry@tailscale.com>	3 years ago
Brad Fitzpatrick	8ec44d0d5f	wgengine/magicsock: remove some log spam Fixes tailscale/corp#3070 Change-Id: Ie50031800ec8669e0596ad6d59d1e329a5c88516 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	61d0435ed9	wgengine/monitor: reduce Windows log spam Fixes #3345 Change-Id: Icde9c92f88f98bb3b030d39b0424a7d389bceb88 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	0653efb092	cmd/tailscaled: remove a redundant date prefix on Windows logs Change-Id: I28e122d4384697f51a748d67829409276c00b11e Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	49a3fcae78	log/filelogger: make filelogger remove redundant date before adding a date At some point since filelogger was added on Windows, the log hierarchy above it changed such that a log.Printf writes to filelogger and includes the log package's own date. But then filelogger adds another. Rather than debug everything above and risk removing the prefix when run by tailscaled, instead just remove the log package's prefix very late right before we go to add the filelogger's own. Change-Id: I9db518f42c603ef83017f74827270f124fdf5c14 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	4a59a2781a	ipn/ipnlocal: export client metrics over peerapi to owner Updates #3307 Change-Id: I41b1f3c16af5f385575e8d6cea70ae8386504dd8 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	d24ed3f68e	wgengine/router: add debug knob to resort to Linux "ip" command usage Tailscale 1.18 uses netlink instead of the "ip" command to program the Linux kernel. The old way was kept primarily for tests, but this also adds a TS_DEBUG_USE_IP_COMMAND environment knob to force the old way temporarily for debugging anybody who might have problems with the new way in 1.18. Updates #391 Change-Id: I0236fbfda6c9c05dcb3554fcc27ec0c86456efd9 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Josh Bleecher Snyder	b3d6704aa3	wgengine/magicsock: fix data race on endpoint.discoKey endpoint.discoKey is protected by endpoint.mu. endpoint.sendDiscoMessage was reading it without holding the lock. This showed up in a CI failure and is readily reproducible locally. The fix is in two parts. First, for Conn.enqueueCallMeMaybe, eliminate the one-line helper method endpoint.sendDiscoMessage; call Conn.sendDiscoMessage directly. This makes it more natural to read endpoint.discoKey in a context in which endpoint.mu is already held. Second, for endpoint.sendDiscoPing, explicitly pass the disco key as an argument. Again, this makes it easier to read endpoint.discoKey in a context in which endpoint.mu is already held. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Brad Fitzpatrick	cf06f9df37	net/tstun, wgengine: add packet-level and drop metrics Primarily tstun work, but some MagicDNS stuff spread into wgengine. No wireguard reconfig metrics (yet). Updates #3307 Change-Id: Ide768848d7b7d0591e558f118b553013d1ec94ad Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	ec036b3561	logpolicy: use bootstrap DNS for logtail dialer Fixes #3332 Change-Id: Ie45efb448e5508c3ece48dd1d8d7e9a39e2e9dc1 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	7901289578	wgengine/magicsock: add a stress test And add a peerMap validate method that checks its internal invariants. Updates tailscale/corp#3016 Change-Id: I23708e68ed44d81986d9e2be82029d4555547592 Co-authored-by: Brad Fitzpatrick <bradfitz@tailscale.com> Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Josh Bleecher Snyder	5a60781919	wgengine/magicsock: increase TestDiscokeyChange connection timeout I believe that this should eliminate the flakiness. If GitHub CI manages to be even slower that can be believed (and I can believe a lot at this point), then we should roll this back and make some more invasive changes. Updates #654 Fixes #3247 (I hope) Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Brad Fitzpatrick	5b5f032c9a	util/clientmetric: optimize memory layout for finding updates Updates #3307 Change-Id: I2840b190583467cc3f00688b96ce3d170df46a46 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Josh Bleecher Snyder	773af7292b	wgengine/magicsock: simplify peerMap.upsertEndpoint We can do the "maybe delete" check unilaterally: In the case of an insert, both oldDiscoKey and ep.discoKey will be the zero value. And since we don't use pi again, we can skip giving it a name, which makes scoping clearer. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Josh Bleecher Snyder	9da22dac3d	wgengine/magicsock: fix bug in peerMap.upsertEndpoint Found by inspection by David Crawshaw while investigating tailscale/corp#3016. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Josh Bleecher Snyder	16870cb754	wgengine/magicsock: fix typo in comment Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Brad Fitzpatrick	36b1df1241	cmd/tailscale/cli: add --watch flag to "debug metrics" subcommand This adds a new --watch flag that prints out a block of metric changes every second, if anything changed. Example output: magicsock_disco_recv_ping +1 => 254 magicsock_disco_recv_pong +1 => 218 magicsock_disco_recv_udp +2 => 472 magicsock_disco_send_udp +2 => 536 magicsock_disco_sent_udp +2 => 536 magicsock_recv_data_ipv6 +1 => 82 magicsock_send_data +1 => 86 magicsock_send_udp +3 => 620 magicsock_recv_data_ipv6 +1 => 83 magicsock_send_data +1 => 87 magicsock_send_udp +1 => 621 magicsock_disco_recv_ping +1 => 255 magicsock_disco_recv_pong +1 => 219 magicsock_disco_recv_udp +2 => 474 magicsock_disco_send_udp +2 => 538 magicsock_disco_sent_udp +2 => 538 magicsock_recv_data_ipv6 +1 => 84 magicsock_send_data +1 => 88 magicsock_send_udp +3 => 624 magicsock_recv_data_ipv6 +1 => 85 magicsock_send_data +1 => 89 magicsock_send_udp +1 => 625 controlclient_map_response_map +1 => 207 controlclient_map_response_map_delta +1 => 204 controlclient_map_response_message +1 => 275 magicsock_disco_recv_ping +3 => 258 magicsock_disco_recv_pong +2 => 221 magicsock_disco_recv_udp +5 => 479 magicsock_disco_send_derp +1 => 6 magicsock_disco_send_udp +7 => 545 magicsock_disco_sent_derp +1 => 6 magicsock_disco_sent_udp +7 => 545 magicsock_recv_data_ipv6 +1 => 86 magicsock_send_data +1 => 90 magicsock_send_derp +1 => 12 magicsock_send_derp_queued +1 => 12 magicsock_send_udp +8 => 633 Updates #3307 Change-Id: I5ac2511e3ad24fa1e6ea958c3946fecebe4f79a7 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
David Anderson	41da7620af	go.mod: update wireguard-go to pick up roaming toggle wgengine/wgcfg: introduce wgcfg.NewDevice helper to disable roaming at all call sites (one real plus several tests). Fixes tailscale/corp#3016. Signed-off-by: David Anderson <danderson@tailscale.com> Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Brad Fitzpatrick	400ed799e6	net/dns: work around old systemd-resolved setLinkDomain length limit Don't set all the *.arpa. reverse DNS lookup domains if systemd-resolved is old and can't handle them. Fixes #3188 Change-Id: I283f8ce174daa8f0a972ac7bfafb6ff393dde41d Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brian Fallik	9fa6cdf7bf	fix minor typo Signed-off-by: Brian Fallik <bfallik@gmail.com>	3 years ago
Brad Fitzpatrick	24ea365d48	netcheck, controlclient, magicsock: add more metrics Updates #3307 Change-Id: Ibb33425764a75bde49230632f1b472f923551126 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	3b541c833e	util/clientmetric, logtail: log metric changes Updates #3307 Change-Id: I1399ebd786f6ff7defe6e11c0eb651144c071574 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	68917fdb5d	cmd/tailscale/cli: add "debug metrics" subcommand To let users inspect the tailscaled metrics easily. Updates #3307 Change-Id: I922126ca0626659948c57de74c6ef62f40ef5f5f Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	945290cc3f	cmd/tailscale/cli: migrate hidden debug subcommand to use subcomands It was a mess of flags. Use subcommands under "debug" instead. And document loudly that it's not a stable interface. Change-Id: Idcc58f6a6cff51f72cb5565aa977ac0cc30c3a03 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	57b039c51d	util/clientmetrics: add new package to add metrics to the client And annotate magicsock as a start. And add localapi and debug handlers with the Prometheus-format exporter. Updates #3307 Change-Id: I47c5d535fe54424741df143d052760387248f8d3 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
David Anderson	c5d572f371	net/dns: correctly handle NetworkManager-managed DNS that points to resolved. Fixes #3304 Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
Brad Fitzpatrick	f7da8c77bd	tstest/integration/testcontrol: fix data race Fix race from `1ec99e99f4` Fixes #3289 Change-Id: I58158d3f82339ac171fb14827c5f158d602327f4 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
David Anderson	5b94f67956	control/noise: make Conn.readNLocked less surprising. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	a34350ffda	control/noise: factor out nonce checking and incrementing into a type. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	d3acd35a90	control/noise: make message headers match the specification. Only the initiation message should carry a protocol version, all others are just type+len. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	a63c4ab378	control/noise: don't panic when handling ciphertext. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	4004b22fe5	control/noise: stop using poly1305 package constants. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	293431aaea	control/noise: use key.Machine{Public,Private} as appropriate. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	edb33d65c3	control/noise: don't cache mixer, just rebuild a BLAKE2s each time. This should optimize out fine, and readability is preferable to performance here. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	7e9e72887c	control/noise: add singleUseCHP, use it to simplify nonce/key tracking in handshake. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	cf90392174	control/noise: review fixups Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	0b392dbaf7	control/noise: adjust implementation to match revised spec. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	89a68a4c22	control/noise: include the protocol version in the Noise prologue. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	5e005a658f	control/noise: fix typo in docstring. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	eabca699ec	control/noise: remove allocations in the encrypt and decrypt paths. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	da7544bcc5	control/noise: implement the base transport for the 2021 control protocol. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
Brad Fitzpatrick	3e1daab704	hostinfo, control/controlclient: tell control when Ubuntu has disabled Tailscale's sources Fixes #3177 Updates #2500 Change-Id: Iff2a8e27ec7d36a1c210263d6218f20ebed37924 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	d2ef73ed82	control/controlclient: rename a variable to not shadow a package name Change-Id: I1bcb577cb2c47e936d545ad57f308e57399de323 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Maisem Ali	d6dde5a1ac	ipn/ipnlocal: handle key extensions after key has already expired Signed-off-by: Maisem Ali <maisem@tailscale.com>	3 years ago
Maisem Ali	eccc2ac6ee	net/interfaces/windows: update Tailscale interface detection logic to account for new wintun naming. Signed-off-by: Maisem Ali <maisem@tailscale.com>	3 years ago
Brad Fitzpatrick	ad63fc0510	control/controlclient: make js/wasm work with Go 1.18+ Updates #3157 Change-Id: I2d67e582842ab3638d720bb5db4701b878ad4473 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	87137405e5	ipn/ipnserver: grant js/wasm all localapi permissions Updates #3157 Change-Id: I3b63762583a4d655eac33ce3dfda37a1f5135a57 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	40e13c316c	paths: add missing js/wasm stub Change-Id: Iae4838f5fa1dc0cd491d5a3ac906fd3cdacb173c Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago

1 2 3 4 5 ...

3422 Commits (a54d13294f9a995f860099430d56acf05377a9e3) All Branches Search

3422 Commits (a54d13294f9a995f860099430d56acf05377a9e3)

All Branches