tailscale

Commit Graph

Author	SHA1	Message	Date
Brad Fitzpatrick	58cc2cc921	tstest/integration/testcontrol: add Server.nodeLocked	4 years ago
Christine Dodrill	0a655309c6	tstest/integration/vms: only build binaries once (#2042 ) Previously this built the binaries for every distro. This is a bit overkill given we are using static binaries. This patch makes us only build once. There was also a weird issue with how processes were being managed. Previously we just killed qemu with Process.Kill(), however that was leaving behind zombies. This has been mended to not only kill qemu but also waitpid() the process so it doesn't become a zombie. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	a282819026	tstest/integration/vms: fix OpenSUSE Leap 15.1 (#2038 ) The OpenSUSE 15.1 image we are using (and conseqentially the only one that is really available easily given it is EOL) has cloud-init hardcoded to use the OpenStack metadata thingy. Other OpenSUSE Leap images function fine with the NoCloud backend, but this one seems to just not work with it. No bother, we can just pretend to be OpenStack. Thanks to Okami for giving me an example OpenStack configuration seed image. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	4da5e79c39	tstest/integration/vms: test on Arch Linux (#2040 ) Arch is a bit of a weirder distro, however as a side effect it is much more of a systemd purist experience. Adding it to our test suite will make sure that we are working in the systemd happy path. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	ca96357d4b	tstest/integration/vms: add OpenSUSE Leap 15.3 (#2026 ) This distro is about to be released. OpenSUSE has historically had the least coverage for functional testing, so this may prove useful in the future. Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	2802a01b81	tstest/integration/vms: test vms as they are ready (#2022 ) Instead of testing all the VMs at once when they are all ready, this patch changes the testing logic so that the vms are tested as soon as they register with testcontrol. Also limit the amount of VM ram used at once with the `-ram-limit` flag. That uses a semaphore to guard resource use. Also document CentOS' sins. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	36cb69002a	tstest/integration/vms: regex-match distros using a flag (#2021 ) If you set `-distro-regex` to match a subset of distros, only those distros will be tested. Ex: $ go test -run-vm-tests -distro-regex='opensuse' Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	e1b994f7ed	tstest/integration/vms: maintain distro info (#2020 ) This lets us see the names of distros in our tests. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Brad Fitzpatrick	fa548c5b96	tstest/integration/vms: fix bindhost lookup (#2012 ) Don't try to do heuristics on the name. Use the net/interfaces package which we already have to do this sort of stuff. Fixes #2011 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Christine Dodrill	14c1113d2b	tstest/integration/vms: copy locally built binaries (#2006 ) Instead of pulling packages from pkgs.tailscale.com, we should use the tailscale binaries that are local to this git commit. This exposes a bit of the integration testing stack in order to copy the binaries correctly. This commit also bumps our version of github.com/pkg/sftp to the latest commit. If you run into trouble with yaml, be sure to check out the commented-out alpine linux image complete with instructions on how to use it. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Brad Fitzpatrick	f21982f854	tstest/integration/vms: skip a test for now Updates #2011 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Christine Dodrill	4cfaf489ac	tstest/integration/vms: t.Log for VM output (#2007 ) Previously we spewed a lot of output to stdout and stderr, even when `-v` wasn't set. This is sub-optimal for various reasons. This patch shunts that output to test logs so it only shows up when `-v` is set. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	1f72b6f812	tstest/integration/vms: use dynamically discovered bindhost (#1992 ) Instead of relying on a libvirtd bridge address that you probably won't have on your system. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	35749ec297	tstest/integration/vms: small cleanups (#1989 ) Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
Christine Dodrill	ba59c0391b	tstest/integration: add experimental integration test (#1966 ) This will spin up a few vms and then try and make them connect to a testcontrol server. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	4 years ago
simenghe	dd0b690e7b	Added new Addresses / AllowedIPs fields to testcontrol when creating tailcfg.Node (#1948 ) * Added new Addresses / AllowedIPs fields to testcontrol when creating new &tailcfg.Node Signed-off-by: Simeng He <simeng@tailscale.com> * Added single node test to check Addresses and AllowedIPs Signed-off-by: Simeng He <simeng@tailscale.com> Co-authored-by: Simeng He <simeng@tailscale.com>	4 years ago
Josh Bleecher Snyder	25df067dd0	all: adapt to opaque netaddr types This commit is a mishmash of automated edits using gofmt: gofmt -r 'netaddr.IPPort{IP: a, Port: b} -> netaddr.IPPortFrom(a, b)' -w . gofmt -r 'netaddr.IPPrefix{IP: a, Port: b} -> netaddr.IPPrefixFrom(a, b)' -w . gofmt -r 'a.IP.Is4 -> a.IP().Is4' -w . gofmt -r 'a.IP.As16 -> a.IP().As16' -w . gofmt -r 'a.IP.Is6 -> a.IP().Is6' -w . gofmt -r 'a.IP.As4 -> a.IP().As4' -w . gofmt -r 'a.IP.String -> a.IP().String' -w . And regexps: \w(.)\.Port = (.) -> $1 = $1.WithPort($2) \w(.)\.IP = (.) -> $1 = $1.WithIP($2) And lots of manual fixups. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	5a7c6f1678	tstest/integration{,/testcontrol}: add node update support, two node test Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	d32667011d	tstest/integration: build test binaries with -race if test itself is Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	ed9d825552	tstest/integration: fix integration test on linux/386 Apparently can't use GOBIN with GOARCH. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	c0158bcd0b	tstest/integration{,/testcontrol}: add testcontrol.RequireAuth mode, new test Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Josh Bleecher Snyder	78d4c561b5	types/logger: add key grinder stats lines to rate-limiting exemption list Updates #1749 Co-authored-by: Brad Fitzpatrick <bradfitz@tailscale.com> Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	68fb51b833	tstest/integration: misc cleanups Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	3237e140c4	tstest/integration: add testNode.AwaitListening, DERP+STUN, improve proxy trap Updates #1840	4 years ago
Brad Fitzpatrick	98d7c28faa	tstest/integration: start factoring test types out to clean things up To enable easy multi-node testing (including inter-node traffic) later. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	5e9e11a77d	tstest/integration/testcontrol: add start of test control server Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	a07a504b16	tstest/integration: use go binary from runtime.GOROOT Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	f342d10dc5	tstest/integration: set an HTTP_PROXY to catch bogus requests Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	80429b97e5	testing: add start of an integration test Only minimal tailscale + tailscaled for now. And a super minimal in-memory logcatcher. No control ... yet. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	08782b92f7	tstest: add WaitFor helper Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Josh Bleecher Snyder	d31eff8473	tstest/natlab: use net.ErrClosed We are now on 1.16. And wgconn.NetErrClosed has been removed upstream. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Filippo Valsorda	39f7a61e9c	tstest/staticcheck: import the main package to fix "go mod tidy" Importing the non-main package was missing some dependencies that "go mod tidy" would then cleanup. Also added a non-ignore build tag to avoid other tools getting upset about importing a main package. Signed-off-by: Filippo Valsorda <hi@filippo.io>	4 years ago
Josh Bleecher Snyder	138055dd70	tstest/natlab: use net.ErrClosed instead of a new error Upstream wireguard-go decided to use errors.Is(err, net.ErrClosed) instead of checking the error string. It also provided an unsafe linknamed version of net.ErrClosed for clients running Go 1.15. Switch to that. This reduces the time required for the wgengine/magicsock tests on my machine from ~35s back to the ~13s it was before `456cf8a376`. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	e8cd7bb66f	tstest: simplify goroutine leak tests Use tb.Cleanup to simplify both the API and the implementation. One behavior change: When the number of goroutines shrinks, don't log. I've never found these logs to be useful, and they frequently add noise. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	18471a8792	ipn: close logger at the end of TestLocalLogLines If any goroutine continues to use the logger in TestLocalLogLines after the test finishes, the test panics. The culprit for this was wireguard-go; the previous commit fixed that. This commit adds suspenders: When the test is done, make logging calls into no-ops. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	fd2a30cd32	wgengine/magicsock: make test pass on Windows and without firewall dialog box Updates #50	4 years ago
Josh Bleecher Snyder	e1596d655a	tstest: skip resource check when test has failed Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	2e40c4b564	tstest: don't log on success This is particularly important for benchmarks, where stray output disrupts tooling. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	7fddc33481	tstest: make LogLineTracker pass variadic format args through Omitting the "..." passed a literal []interface{} to the underlying logger always.	4 years ago
Brad Fitzpatrick	68c42530e9	tstest: rename LogListener to LogLineTracker But mostly to rename tstest.ListenFor which has no mention of log lines in it. It sounded like a net.Listener or something.	4 years ago
David Crawshaw	3baa084548	tstest: take testing.TB in helper for benchmarks Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	4 years ago
Wendi Yu	a3fb422a39	ipn: tag and test for grinder log lines (#711 ) Signed-off-by: Wendi <wendi.yu@yahoo.ca>	4 years ago
David Anderson	f794493b4f	wgengine/magicsock: explicitly check path discovery, add a firewall test. The test proves that active discovery can traverse two facing firewalls. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	5a370d545a	tstest/natlab: drop packets that can't be routed in a LAN. LANs are authoritative for their prefixes, so we should not bounce packets back and forth to the default gateway in that case. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	45578b47f3	tstest/natlab: refactor PacketHandler into a larger interface. The new interface lets implementors more precisely distinguish local traffic from forwarded traffic, and applies different forwarding logic within Machines for each type. This allows Machines to be packet forwarders, which didn't quite work with the implementation of Inject. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	23123907c0	tstest/natlab: add a configurable SNAT44 translator. This lets us implement the most common kinds of NAT in the wild. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	39ecb37fd6	tstest/natlab: support different firewall selectivities. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	88e8456e9b	wgengine/magicsock: add a connectivity test for facing firewalls. The test demonstrates that magicsock can traverse two stateful firewalls facing each other, that each require localhost to initiate connections. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	b3d65ba943	tstest/natlab: refactor, expose a Packet type. HandlePacket and Inject now receive/take Packets. This is a handy container for the packet, and the attached Trace method can be used to print traces from custom packet handlers that integrate nicely with natlab's internal traces. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	5eedbcedd1	tstest/natlab: add a stateful firewall. The firewall provides a ProcessPacket handler, and implements an address-and-port endpoint dependent firewall that allows all traffic to egress from the trusted interface, and only allows inbound traffic if corresponding outbound traffic was previously seen. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	0ed9f62ed0	tstest/natlab: provide inbound interface to HandlePacket. Requires a bunch of refactoring so that Networks only ever refer to Interfaces that have been attached to them, and Interfaces know about both their Network and Machine. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	6c74065053	wgengine/magicsock, tstest/natlab: start hooking up natlab to magicsock Also adds ephemeral port support to natlab. Work in progress. Pairing with @danderson.	4 years ago
Brad Fitzpatrick	7883e5c5e7	go.mod: restore staticcheck module, make it stick around, go mod tidy It kept coming & going as different people ran go mod tidy and others ran staticcheck. Make it stop going away with go mod tidy by adding a dep to it.	4 years ago
David Anderson	0aea087766	tstest/natlab: add PacketHandler and Inject. Together, they can be used to plug custom packet processors into Machines. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	73db7e99ab	tstest/natlab: make Machine constructible directly. This is a prelude to adding more fields, which would otherwise become more unnamed function params. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	d94593e884	tstest/natlab: unregister conn4 if registration of conn6 fails. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	d7bc4ec029	tstest/natlab: use common helper for conn registration. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	80a14c49c6	tstest/natlab: add comments to conns4/conns6. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	c53b154171	tstest/natlab: use &Network in test. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	622c0d0cb3	tstest/natlab: print trace data when NATLAB_TRACE is set. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	1d4f9852a7	tstest/natlab: correctly handle dual-stacked PacketConns. Adds a test with multiple networks, one of which is v4-only. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	771eb05bcb	tstest/natlab: first network attached becomes the default route. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	f2e5da916a	tstest/natlab: allow sensible default construction of networks. Add a test for LAN->LAN traffic. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	97910ce712	tstest/natlab: remove unused PacketConner type	4 years ago
Brad Fitzpatrick	14b4213c17	tstest/natlab: add missing tests from earlier commits Now you can actually see that packet delivery works. Pairing with @danderson	4 years ago
Brad Fitzpatrick	3f4f1cfe66	tstest/natlab: basic NAT-free packet delivery works Pairing with @danderson	4 years ago
Brad Fitzpatrick	a477e70632	tstest/natlab: network address allocation Pairing with @danderson	4 years ago
Brad Fitzpatrick	bb1a9e4700	tstest/natlab: bit more of in-memory network testing package Pairing with @danderson	4 years ago
Brad Fitzpatrick	23c93da942	tstest/natlab: start of in-memory network testing package Pairing with @danderson	4 years ago
Brad Fitzpatrick	5ec7ac1d02	tstest: document PanicOnLog	5 years ago
Avery Pennarun	4f128745d8	magicsock/test: oops, fix a data race in nested-test logf hack. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	08acb502e5	Add tstest.PanicOnLog(), and fix various problems detected by this. If a test calls log.Printf, 'go test' horrifyingly rearranges the output to no longer be in chronological order, which makes debugging virtually impossible. Let's stop that from happening by making log.Printf panic if called from any module, no matter how deep, during tests. This required us to change the default error handler in at least one http.Server, as well as plumbing a bunch of logf functions around, especially in magicsock and wgengine, but also in logtail and backoff. To add insult to injury, 'go test' also rearranges the output when a parent test has multiple sub-tests (all the sub-test's t.Logf is always printed after all the parent tests t.Logf), so we need to screw around with a special Logf that can point at the "current" t (current_t.Logf) in some places. Probably our entire way of using subtests is wrong, since 'go test' would probably like to run them all in parallel if you called t.Parallel(), but it definitely can't because the're all manipulating the shared state created by the parent test. They should probably all be separate toplevel tests instead, with common setup/teardown logic. But that's a job for another time. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	e0b666c5d2	tstest.ResourceCheck: clarify success message. Inclusion of the word "assert" made it seem like a failure, even though it was supposed to be identifying the name of the function (Assert()). Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
David Anderson	0038223632	tstest: rename from testy. Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago

... 3 4 5 6 7

324 Commits (787f8c08ec6a7b760ddc9ef09fe6aaf8ba196362)