tailscale

Commit Graph

Author	SHA1	Message	Date
Christine Dodrill	1b1c85d069	Revert "Revert "tstest/integration/vms: end-to-end UDP test (#2361 )" (#2364 )" (#2365 ) This reverts commit `254fc7885b`. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Simeng He	3d049a9d71	tstest/integration: change return type of AwaitIP from string to netaddr.IP Signed-off-by: Simeng He <simeng@tailscale.com>	3 years ago
Brad Fitzpatrick	7e7c4c1bbe	tailcfg: break DERPNode.DERPTestPort into DERPPort & InsecureForTests The DERPTestPort int meant two things before: which port to use, and whether to disable TLS verification. Users would like to set the port without disabling TLS, so break it into two options. Updates #1264 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	afbd35482d	tstest/integration/vms: add NixOS unstable back (#2330 ) The upstream NixOS issue was fixed. https://github.com/NixOS/nixpkgs/issues/128783 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	33cacb5284	tstest/integration/vms: unbreak nixos builds (#2372 ) To avoid the generated nixos disk images from becoming immune from the GC, I delete the symlink to the nix store at the end of tests. `t.Cleanup` runs at the end of a test. I changed this part of the code to have a separate timer for how long it takes to run NixOS builds, but I did that by using a subtest. This means that it was creating the NixOS image, deleting its symlink and then trying to use that symlink to find the resulting disk image, making the whole thing ineffectual. This was a mistake. I am reverting this change made in https://github.com/tailscale/tailscale/pull/2360 to remove this layer of subtesting. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	254fc7885b	Revert "tstest/integration/vms: end-to-end UDP test (#2361 )" (#2364 ) This reverts commit `dc78be12c5`.	3 years ago
Christine Dodrill	dc78be12c5	tstest/integration/vms: end-to-end UDP test (#2361 ) This tests incoming and outgoing UDP traffic. It would test incoming UDP traffic however our socks server doesn't seem to allow for connecting to destinations over UDP. When the socks server gets that support the incoming test should pass without issue. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	a19eea965f	tstest/integration/vms: use an in-process logcatcher (#2360 ) This adapts the existing in-process logcatcher from tstest/integration into a public type and uses it on the side of testcontrol. This also fixes a bug in the Alpine Linux OpenRC unit that makes every value in `/etc/default/tailscaled` exported into tailscaled's environment, a-la systemd [Service].EnviromentFile. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	1e83b97498	tstest/integration/vms: outgoing SSH test (#2349 ) This does a few things: 1. Rewrites the tests so that we get a log of what individual tests failed at the end of a test run. 2. Adds a test that runs an HTTP server via the tester tailscale node and then has the VMs connect to that over Tailscale. 3. Dials the VM over Tailscale and ensures it answers SSH requests. 4. Other minor framework refactoring. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	97279a0fe0	tstest/integration/vms: add Oracle Linux image (#2328 ) Oracle Linux[1] is a CentOS fork. It is not very special. I am adding it to the integration jungle because I am adding it to pkgs and the website directions. [1]: https://www.oracle.com/linux/ Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Brad Fitzpatrick	7d417586a8	tstest/integration: help bust cmd/go's test caching It was caching too aggressively, as it didn't see our deps due to our running "go install tailscaled" as a child process. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	a8360050e7	tstest/integration/vms: make first end to end test (#2332 ) This makes sure `tailscale status` and `tailscale ping` works. It also switches goexpect to use a batch instead of manually banging out each line, which makes the tests so much easier to read. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	5813da885c	tstest/integration/vms: verbosify nixos logs to fs, disable unstable (#2294 ) This puts nix build logs on the filesystem so that we can debug them later. This also disables nixos unstable until https://github.com/NixOS/nixpkgs/issues/128783 is fixed. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
julianknodt	506c2fe8e2	cmd/tailscale: make netcheck use active DERP map, delete static copy After allowing for custom DERP maps, it's convenient to be able to see their latency in netcheck. This adds a query to the local tailscaled for the current DERPMap. Updates #1264 Signed-off-by: julianknodt <julianknodt@gmail.com>	3 years ago
Brad Fitzpatrick	5e19ac7adc	tstest/integration: always run SOCK5 server, parse out its listening address Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	b131a74f99	tstest/integration/vms: build and run NixOS (#2190 ) Okay, so, at a high level testing NixOS is a lot different than other distros due to NixOS' determinism. Normally NixOS wants packages to be defined in either an overlay, a custom packageOverrides or even yolo-inline as a part of the system configuration. This is going to have us take a different approach compared to other distributions. The overall plan here is as following: 1. make the binaries as normal 2. template in their paths as raw strings to the nixos system module 3. run `nixos-generators -f qcow -o $CACHE_DIR/tailscale/nixos/version -c generated-config.nix` 4. pass that to the steps that make the virtual machine It doesn't really make sense for us to use a premade virtual machine image for this as that will make it harder to deterministically create the image. Nix commands generate a lot of output, so their output is hidden behind the `-verbose-nix-output` flag. This unfortunately makes this test suite have a hard dependency on Nix/NixOS, however the test suite has only ever been run on NixOS (and I am not sure if it runs on other distros at all), so this probably isn't too big of an issue. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	194d5b8412	tstest/integration/vms: add in-process DERP server (#2108 ) Previously this test would reach out to the public DERP servers in order to help machines connect with eachother. This is not ideal given our plans to run these tests completely disconnected from the internet. This patch introduces an in-process DERP server running on its own randomly assigned HTTP port. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	6b234323a0	tstest/integration/vms: fix flake when testing (#2145 ) Occasionally the test framework would fail with a timeout due to a virtual machine not phoning home in time. This seems to be happen whenever qemu can't bind the VNC or SSH ports for a virtual machine. This was fixed by taking the following actions: 1. Don't listen on VNC unless the `-use-vnc` flag is passed, this removes the need to listen on VNC at all in most cases. The option to use VNC is still left in for debugging virtual machines, but removing this makes it easier to deal with (VNC uses this odd system of "displays" that are mapped to ports above 5900, and qemu doesn't offer a decent way to use a normal port number, so we just disable VNC by default as a compromise). 2. Use a (hopefully) inactive port for SSH. In an ideal world I'd just have the VM's SSH port be exposed via a Unix socket, however the QEMU documentation doesn't really say if you can do this or not. While I do more research, this stopgap will have to make do. 3. Strictly tie more VM resource lifetimes to the tests themselves. Previously the disk image layers for virtual machines were only cleaned up at the end of the test and existed in the parent test-scoped temporary folder. This can make your tmpfs run out of space, which is not ideal. This should minimize the use of temporary storage as much as I know how to. 4. Strictly tie the qemu process lifetime to the lifetime of the test using testing.T#Cleanup. Previously it used a defer statement to clean up the qemu process, however if the tests timed out this defer was not run. This left around an orphaned qemu process that had to be killed manually. This change ensures that all qemu processes exit when their relevant tests finish. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Brad Fitzpatrick	45e64f2e1a	net/dns{,/resolver}: refactor DNS forwarder, send out of right link on macOS/iOS Fixes #2224 Fixes tailscale/corp#2045 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	a0c632f6b5	tstest/integration: fix a race Noticed on a CI failure. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
David Crawshaw	297b3d6fa4	staticcheck.conf: turn off noisy lint errors Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
Brad Fitzpatrick	2f4817fe20	tstest/integration: fix race flake Fixes #2172 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	e0f0d10672	tstest/integration/vms: log to t.Logf directly (#2147 ) Previously we used t.Logf indirectly via package log. This worked, but it was not ideal for our needs. It could cause the streams of output to get crossed. This change uses a logger.FuncWriter every place log.Output was previously used, which will more correctly write log information to the right test output stream. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Brad Fitzpatrick	082cc1b0a7	tstest/integration: reenable TestAddPingRequest Failure understood now; see: https://github.com/tailscale/tailscale/pull/2088#issuecomment-859896598 As of `333e9e75d4`, PingRequest is now safe for the server to send multiple times, without fear of the client handling it multiple times. Fixes #2079 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Denton Gentry	c61d777705	tstest/integration: disable TestAddPingRequest Failing often now, we don't want people to get used to routinely ignoring test failures. Can be re-enabled when https://github.com/tailscale/tailscale/issues/2079 is resolved. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	3 years ago
Christine Dodrill	8b2b899989	tstest/integration: test Alpine Linux (#2098 ) Alpine Linux[1] is a minimal Linux distribution built around musl libc. It boots very quickly, requires very little ram and is as close as you can get to an ideal citizen for testing Tailscale on musl. Alpine has a Tailscale package already[2], but this patch also makes it easier for us to provide an Alpine Linux package off of pkgs in the future. Alpine only offers Tailscale on the rolling-release edge branch. [1]: https://alpinelinux.org/ [2]: https://pkgs.alpinelinux.org/packages?name=tailscale&branch=edge Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Brad Fitzpatrick	0affcd4e12	tstest/integration: add some debugging for TestAddPingRequest flakes This fails pretty reliably with a lot of output now showing what's happening: TS_DEBUG_MAP=1 go test --failfast -v -run=Ping -race -count=20 ./tstest/integration --verbose-tailscaled I haven't dug into the details yet, though. Updates #2079	3 years ago
Brad Fitzpatrick	ee3df2f720	tstest/integration: rename ambiguous --verbose test flag Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	b402e76185	.github/workflows: add integration test with a custom runner (#2044 ) This runner is in my homelab while we muse about a better, more permanent home for these tests. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	622dc7b093	tstest/integration/vms: download images from s3 (#2035 ) This makes integration tests pull pristine VM images from Amazon S3 if they don't exist on disk. If the S3 fetch fails, it will fall back to grabbing the image from the public internet. The VM images on the public internet are known to be updated without warning and thusly change their SHA256 checksum. This is not ideal for a test that we want to be able to fire and forget, then run reliably for a very long time. This requires an AWS profile to be configured at the default path. The S3 bucket is rigged so that the requester pays. The VM images are currently about 6.9 gigabytes. Please keep this in mind when running these tests on your machine. Documentation was added to the integration test folder to aid others in running these tests on their machine. Some wording in the logs of the tests was altered. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	3f1405fa2a	tstest/integration/vms: bump images, fix caching bug (#2052 ) Before this redownloaded the image every time. Now it only redownloads it when it needs to. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Simeng He	0141390365	tstest/integration/testcontrol: add Server.AddPingRequest Signed-off-by: Simeng He <simeng@tailscale.com>	3 years ago
Christine Dodrill	adaecd83c8	tstest/integration/vms: add DownloadImages test to download images (#2039 ) The image downloads can take a significant amount of time for the tests. This creates a new test that will download every distro image into the local cache in parallel, optionally matching the distribution regex. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	607b7ab692	tstest/integration/vms: aggressively re-verify shasums (#2050 ) I've run into a couple issues where the tests time out while a VM image is being downloaded, making the cache poisoned for the next run. This moves the hash checking into its own function and calls it much sooner in the testing chain. If the hash check fails, the OS is redownloaded. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	6ce77b8eca	tstest/integration/vms: log qemu output (#2047 ) Most of the time qemu will output nothing when it is running. This is expected behavior. However when qemu is unable to start due to some problem, it prints that to either stdout or stderr. Previously this output wasn't being captured. This patch captures that output to aid in debugging qemu issues. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Brad Fitzpatrick	58cc2cc921	tstest/integration/testcontrol: add Server.nodeLocked	3 years ago
Christine Dodrill	0a655309c6	tstest/integration/vms: only build binaries once (#2042 ) Previously this built the binaries for every distro. This is a bit overkill given we are using static binaries. This patch makes us only build once. There was also a weird issue with how processes were being managed. Previously we just killed qemu with Process.Kill(), however that was leaving behind zombies. This has been mended to not only kill qemu but also waitpid() the process so it doesn't become a zombie. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	a282819026	tstest/integration/vms: fix OpenSUSE Leap 15.1 (#2038 ) The OpenSUSE 15.1 image we are using (and conseqentially the only one that is really available easily given it is EOL) has cloud-init hardcoded to use the OpenStack metadata thingy. Other OpenSUSE Leap images function fine with the NoCloud backend, but this one seems to just not work with it. No bother, we can just pretend to be OpenStack. Thanks to Okami for giving me an example OpenStack configuration seed image. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	4da5e79c39	tstest/integration/vms: test on Arch Linux (#2040 ) Arch is a bit of a weirder distro, however as a side effect it is much more of a systemd purist experience. Adding it to our test suite will make sure that we are working in the systemd happy path. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	ca96357d4b	tstest/integration/vms: add OpenSUSE Leap 15.3 (#2026 ) This distro is about to be released. OpenSUSE has historically had the least coverage for functional testing, so this may prove useful in the future. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	2802a01b81	tstest/integration/vms: test vms as they are ready (#2022 ) Instead of testing all the VMs at once when they are all ready, this patch changes the testing logic so that the vms are tested as soon as they register with testcontrol. Also limit the amount of VM ram used at once with the `-ram-limit` flag. That uses a semaphore to guard resource use. Also document CentOS' sins. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	36cb69002a	tstest/integration/vms: regex-match distros using a flag (#2021 ) If you set `-distro-regex` to match a subset of distros, only those distros will be tested. Ex: $ go test -run-vm-tests -distro-regex='opensuse' Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	e1b994f7ed	tstest/integration/vms: maintain distro info (#2020 ) This lets us see the names of distros in our tests. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Brad Fitzpatrick	fa548c5b96	tstest/integration/vms: fix bindhost lookup (#2012 ) Don't try to do heuristics on the name. Use the net/interfaces package which we already have to do this sort of stuff. Fixes #2011 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	14c1113d2b	tstest/integration/vms: copy locally built binaries (#2006 ) Instead of pulling packages from pkgs.tailscale.com, we should use the tailscale binaries that are local to this git commit. This exposes a bit of the integration testing stack in order to copy the binaries correctly. This commit also bumps our version of github.com/pkg/sftp to the latest commit. If you run into trouble with yaml, be sure to check out the commented-out alpine linux image complete with instructions on how to use it. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Brad Fitzpatrick	f21982f854	tstest/integration/vms: skip a test for now Updates #2011 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	4cfaf489ac	tstest/integration/vms: t.Log for VM output (#2007 ) Previously we spewed a lot of output to stdout and stderr, even when `-v` wasn't set. This is sub-optimal for various reasons. This patch shunts that output to test logs so it only shows up when `-v` is set. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	1f72b6f812	tstest/integration/vms: use dynamically discovered bindhost (#1992 ) Instead of relying on a libvirtd bridge address that you probably won't have on your system. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	35749ec297	tstest/integration/vms: small cleanups (#1989 ) Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	ba59c0391b	tstest/integration: add experimental integration test (#1966 ) This will spin up a few vms and then try and make them connect to a testcontrol server. Updates #1988 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago

1 2 3

109 Commits (61e8fd46984bcb0f701ab5beeaff68c2b01de39a)