tailscale

Commit Graph

Author	SHA1	Message	Date
Denton Gentry	ce058c8280	Revert "Add logtail tests (#1114 )" (#1116 ) This reverts commit `e4f53e9b6f`. At least two of these tests are flakey, reverting until they can be made more robust. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	e4f53e9b6f	Add logtail tests (#1114 ) * logtail: test parseAndRemoveLogLevel() Signed-off-by: Denton Gentry <dgentry@tailscale.com> * logtail: test JSON log encoding. Expand TestUploadMessages to also exercise the encoding functions in logtail, like JSON logging and timestamps. Other tests frequently send logs but a) don't check the result and b) do so by happenstance, such that the lines in encode() were not consistently being exercised and leading to spurious changes in code coverage. Signed-off-by: Denton Gentry <dgentry@tailscale.com> * logtail: add a test for drainPendingMessages Make the client buffer some messages before the upload server becomes available. Signed-off-by: Denton Gentry <dgentry@tailscale.com> * logtail: use %q, raw strings, and io.WriteString %q escapes binary characters for us. raw strings avoid so much backslash escaping Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	b771a1363b	logtail: start a local server for TestFastShutdown Right now TestFastShutdown tries to upload logs to localhost:1234, which will most likely respond with an error. However if one has an actual service running on port 1234, it would receive a connection attempting to POST every time the unit test runs. Start a local server and direct the upload there instead. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	2c328da094	logtail: add a test to upload logs to local server Start an HTTP server to accept POST requests, and upload some logs to it. Check that uploaded logs were received. Code in logtail:drainPending was not being reliably exercised by other tests. This shows up in code coverage reports, as lines of code in drainPending are alternately added and subtracted from code coverage. This test will reliably exercise and verify this code. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Brad Fitzpatrick	d6e9fb1df0	all: adjust Unix permissions for those without umasks Fixes tailscale/corp#1165 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	57dd247376	cmd/tailscaled, logpolicy, logtail: support log levels Log levels can now be specified with "[v1] " or "[v2] " substrings that are then stripped and filtered at the final logger. This follows our existing "[unexpected]" etc convention and doesn't require a wholesale reworking of our logging at the moment. cmd/tailscaled then gets a new --verbose=N flag to take a log level that controls what gets logged to stderr (and thus systemd, syslog, etc). Logtail is unaffected by --verbose. This commit doesn't add annotations to any existing log prints. That is in the next commit. Updates #924 Updates #282 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	d97ee12179	logtail, logpolicy: remove an unidiomatic use of an interface	4 years ago
Josh Bleecher Snyder	3a7402aa2d	logtail: help the server be more efficient Add content length hints to headers. The server can use these hints to more efficiently select buffers. Stop attempting to compress tiny requests. The bandwidth savings are negligible (and sometimes negative!), and it makes extra work for the server. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	883a11f2a8	logtail: fix typo in comment Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	7a2a3955d3	logtail/filch: skip a broken test on Windows Add a TODO with some notes about why it's skipped for now. Updates #50	4 years ago
Josh Bleecher Snyder	585a0d8997	all: use testing.T.TempDir Bit of Friday cleanup. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	dd97111d06	backoff: update to Go style, document a bit, make 30s explicit Also, bit of behavior change: on non-nil err but expired context, don't reset the consecutive failure count. I don't think the old behavior was intentional. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Elias Naur	bca9fe35ba	logtail: return correct write size from logger.Write Signed-off-by: Elias Naur <mail@eliasnaur.com>	4 years ago
Avery Pennarun	6f590f5b52	logtail: we missed a case for the backoff timer. We want to run bo.Backoff() after every upload, regardless. If upload==true but err!=nil, we weren't backing off, which caused some very-high-throughput log upload retries in bad network conditions. Updates #282. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	5eb09c8f5e	filch_test: clarify the use of os.RemoveAll(). Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	4f128745d8	magicsock/test: oops, fix a data race in nested-test logf hack. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	08acb502e5	Add tstest.PanicOnLog(), and fix various problems detected by this. If a test calls log.Printf, 'go test' horrifyingly rearranges the output to no longer be in chronological order, which makes debugging virtually impossible. Let's stop that from happening by making log.Printf panic if called from any module, no matter how deep, during tests. This required us to change the default error handler in at least one http.Server, as well as plumbing a bunch of logf functions around, especially in magicsock and wgengine, but also in logtail and backoff. To add insult to injury, 'go test' also rearranges the output when a parent test has multiple sub-tests (all the sub-test's t.Logf is always printed after all the parent tests t.Logf), so we need to screw around with a special Logf that can point at the "current" t (current_t.Logf) in some places. Probably our entire way of using subtests is wrong, since 'go test' would probably like to run them all in parallel if you called t.Parallel(), but it definitely can't because the're all manipulating the shared state created by the parent test. They should probably all be separate toplevel tests instead, with common setup/teardown logic. But that's a job for another time. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	64db026c8b	backoff: add a LogLongerThan configuration. Some programs use frequent short-duration backoffs even under non-error conditions. They can set this to avoid logging short backoffs when things are operating normally, but still get messages when longer backoffs kick in. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
David Crawshaw	2372530964	logtail/backoff: only log backoffs > 2sec Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	5d67365cc9	logtail: add PrivateID.IsZero method	5 years ago
Brad Fitzpatrick	c726c1eec9	logtail: add const DefaultHost with default server name	5 years ago
Brad Fitzpatrick	3464114b88	logtail: add ParsePublicID that doesn't allocate	5 years ago
Brad Fitzpatrick	996bf9cae7	logtail: don't send a User-Agent Just useless bytes on the wire. Especially with HTTP/1. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	bdc55d7091	logtail: add ParsePrivateID	5 years ago
Brad Fitzpatrick	e71a7c7a2c	logtail: read to EOF on chunked response We'll be fixing the server so this won't trigger in practice, but it demos the connection reuse problem. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	fcb6a34f4b	logtail: reduce allocations encoding text Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Crawshaw	6ddbcab71e	logtail: rename the unused CheckLogs to DrainLogs Its semantics has changed slightly, this will let us use it to drive batched logging in special circumstances. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	51a12d1307	filch: a few minor comments Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	8f9fa6a842	logtail: minor style/simplification changes	5 years ago
David Anderson	de0239375a	logtail/filch: use x/sys/unix instead of syscall. In particular, the Dup2 syscall is not defined in the syscall package on arm64, but is defined in x/sys/unix. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
David Anderson	8380d8575a	logtail: remove unused code from old sentinel logic. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
David Anderson	be6bcd59cd	logtail: don't pass in nil contexts. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
David Anderson	250dfc9016	logtail: remove unused struct fields. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
David Anderson	80ecb8342f	logtail/filch: use io's seek constants. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
Earl Lee	a8d8b8719a	Move Linux client & common packages into a public repo.	5 years ago

35 Commits (5611f290eb118eddc256560eaaa69f509347b4de)