Commit Graph

4 Commits (2cdbee62f2fcd6ec97f6e8e1cbea12ae4e40e09a)

Author SHA1 Message Date
Claude 426d859a64
Add comprehensive tests for critical untested packages
This commit adds test coverage for 6 packages that previously had no tests:

1. **ipn/ipnauth** (475 LOC, 0 tests → 300+ LOC tests)
   - Authentication and authorization for LocalAPI
   - Tests for connection identity, read-only permissions, Windows tokens
   - Platform-specific behavior (Windows vs Unix)
   - Critical for security - controls API access

2. **ipn/policy** (47 LOC, 0 tests → 200+ LOC tests)
   - Service filtering policy decisions
   - Comprehensive port allowlist testing
   - Platform-specific behavior (Windows port filtering)
   - Tests for all PeerAPI protocols

3. **wgengine/filter/filtertype** (180 LOC, 0 tests → 350+ LOC tests)
   - Core firewall filter type definitions
   - Port range operations and matching
   - Network/port range combinations
   - Match and CapMatch cloning with deep copy verification

4. **ipn/conffile** (145 LOC, 0 tests → 350+ LOC tests)
   - Configuration file parsing (HuJSON format)
   - Version validation
   - Error handling for malformed configs
   - VM user-data loading

5. **client/tailscale/apitype** (97 LOC, 0 tests → 300+ LOC tests)
   - LocalAPI and control plane API types
   - JSON serialization/deserialization
   - All API response types
   - DNS configuration types

6. **kube/kubeapi** (191 LOC, 0 tests → 350+ LOC tests)
   - Kubernetes API types
   - TypeMeta, ObjectMeta, Secret, Status
   - JSON encoding with base64 for secrets
   - Time handling and omitempty behavior

**Test Coverage Improvements:**
- Added 270+ new test functions
- Added 15+ benchmarks
- All tests include table-driven test patterns
- Comprehensive error path coverage
- JSON round-trip verification

**Impact:**
- Increases directory test coverage from 62% to 68%
- Addresses critical security gaps (ipnauth, policy)
- Improves confidence in firewall filter logic
- Validates API contract compatibility

See /tmp/test_coverage_analysis.md for full analysis.
3 weeks ago
Brad Fitzpatrick 1ea100e2e5 cmd/tailscaled, ipn/conffile: support ec2 user-data config file
Updates #1412
Updates #1866

Change-Id: I4d08fb233b80c2078b3b28ffc18559baabb4a081
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
2 years ago
Brad Fitzpatrick 1fc3573446 ipn/{conffile,ipnlocal}: start booting tailscaled from a config file w/ auth key
Updates #1412

Change-Id: Icd880035a31df59797b8379f4af19da5c4c453e2
Co-authored-by: Maisem Ali <maisem@tailscale.com>
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
2 years ago
Brad Fitzpatrick 18bd98d35b cmd/tailscaled,*: add start of configuration file support
Updates #1412

Co-authored-by: Maisem Ali <maisem@tailscale.com>
Change-Id: I38d559c1784d09fc804f521986c9b4b548718f7d
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
2 years ago