tailscale

Commit Graph

Author	SHA1	Message	Date
Brad Fitzpatrick	382b349c54	cmd/tailscaled: disable netns in userspace-networking mode Updates #2827 Updates #2822 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
David Crawshaw	b2a3d1da13	tstest/integration/vms: use fork of goexpect to avoid proto/grpc dep Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
Dave Anderson	980acc38ba	types/key: add a special key with custom serialization for control private keys (#2792 ) * Revert "Revert "types/key: add MachinePrivate and MachinePublic."" This reverts commit `61c3b98a24`. Signed-off-by: David Anderson <danderson@tailscale.com> * types/key: add ControlPrivate, with custom serialization. ControlPrivate is just a MachinePrivate that serializes differently in JSON, to be compatible with how the Tailscale control plane historically serialized its private key. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	61c3b98a24	Revert "types/key: add MachinePrivate and MachinePublic." Broke the tailscale control plane due to surprise different serialization. This reverts commit `4fdb88efe1`.	3 years ago
David Anderson	4fdb88efe1	types/key: add MachinePrivate and MachinePublic. Plumb throughout the codebase as a replacement for the mixed use of tailcfg.MachineKey and wgkey.Private/Public. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Crawshaw	4e18cca62e	testcontrol: replace panic with error I have seen this once in the VM test (caused by an EOF, I believe on shutdown) that didn't need to cause the test to fail. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
David Crawshaw	f53792026e	tstest/integration/vms: move build tags from linux to !windows The tests build fine on other Unix's, they just can't run there. But there is already a t.Skip by default, so `go test` ends up working fine elsewhere and checks the code compiles. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
Christine Dodrill	0b9e938152	tstest/integration/vms: test DNS configuration This uses a neat little tool to dump the output of DNS queries to standard out. This is the first end-to-end test of DNS that runs against actual linux systems. The /etc/resolv.conf test may look superflous, however this will help for correlating system state if one of the DNS tests fails. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
David Crawshaw	9b7fc2ed1f	.github: add Ubuntu VM test Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
David Crawshaw	debaaebf3b	tstest/integration/vms: turn on logcatcher logging by default Absolutely vital to debugging failures. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
David Crawshaw	a1f1020042	tstest/integration/vms: avoid log after test completion Avoids a panic in the Go testing package if a late log comes in. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
David Crawshaw	583af7c1a6	tstest/integration/vms: give guest multiple cores and use generic machine Speeds up tests. Allows the use of more version of qemu. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
David Crawshaw	8668103f06	tstest/integration/vms: print qemu console output, fix printing issues Fix a few test printing issues when tests fail. Qemu console output is super useful when something is wrong in the harness and we cannot even bring up the tests. Also useful for figuring out where all the time goes in tests. A little noisy, but not too noisy as long as you're only running one VM as part of the tests, which is my plan. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
David Crawshaw	1a9fba5b04	tstest/integration/vms: fix ubuntu URLs Also remove extra distros for now. We can bring them back later if useful. Though our most important distros are these two Ubuntu, debian stable, and Raspbian (not currently supported). And before doing more Linux, we should do Windows. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
David Crawshaw	bb47feca44	tstest/integration: prefix logs with logid The VM test has two tailscaled instances running and interleaves the logs. Without a prefix it is impossible to figure out what is going on. It might be even better to include the [ABCD] node prefix here as well. Unfortunately lots of interesting logs happen before tailscaled has a node key, so it wouldn't be a replacement for a short ID. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
Maisem Ali	fd4838dc57	wgengine/userspace: add support to automatically enable/disable the tailscale protocol in BIRD, when the node is a primary subnet router as determined by control. Signed-off-by: Maisem Ali <maisem@tailscale.com>	3 years ago
David Crawshaw	0b962567fa	vms: make ssh-keygen quiet by default Always succeeds. Its output clutters the log. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
David Crawshaw	4fcce70df5	tstest/integration: listen on the specified IP By default httptest listens only on the loopback adapter. Instead, listen on the IP the user asked for. The VM test needs this, as it wants to start DERP and STUN servers on the host that can be reached by guest VMs. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
David Crawshaw	0b2761ca92	testcontrol: plumb through DERP Without this tailscaled does not know the DERP of a peer. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
Josh Bleecher Snyder	4ff0757d44	cmd/testcontrol: add test control server This is useful for manual performance testing of networks with many nodes. I imagine it'll grow more knobs over time. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Josh Bleecher Snyder	fcca374fa7	tstest/integration/testcontrol: sort peers in map response This is part of the control protocol. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Josh Bleecher Snyder	a5da4ed981	all: gofmt with Go 1.17 This adds "//go:build" lines and tidies up existing "// +build" lines. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Brad Fitzpatrick	0858673f1f	tstest/integration: regenerate test deps Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	24ee0ed3c3	tstest/integration: update test deps Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
David Crawshaw	3e039daf95	logpolicy: actually collect panics (Written with Josh) For #2544 Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
Christine Dodrill	60f34c70a2	tstest/integration/vms: disable rDNS for sshd on centos (#2492 ) This prevents centos tests from timing out because sshd does reverse dns lookups on every session being established instead of doing it once on the acutal ssh connection being established. This is odd. Appending this to the sshd config and restarting it seems to fix it though. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	8db26a2261	tstest/integration/vms: disable nixos unstable (#2491 ) cloud-init broke with the upgrade to python 3.9: https://github.com/NixOS/nixpkgs/issues/131098 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Josh Bleecher Snyder	0aa77ba80f	tstest/integration: fix filch test flake Filch doesn't like having multiple processes competing for the same log files (#937). Parallel integration tests were all using the same log files. Add a TS_LOGS_DIR env var that the integration test can use to use separate log files per test. Fixes #2269 Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Josh Bleecher Snyder	f80193fa4c	tstest/integration: shorten test names The maximum unix domain socket path length on darwin is 104 bytes, including the trailing NUL. On my machine, the path created by some newly added tests (`6eecf3c9`) was too long, resulting in cryptic test failures. Shorten the names of the tests, and add a check to make the diagnosis easier next time. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Brad Fitzpatrick	b6d70203d3	ipn/ipnlocal: fix 'tailscale up' on Windows without GUI With this, I can now: * install Tailscale * stop the GUI * net stop Tailscale * net start Tailscale * tailscale up --unattended (where the middle three steps simulate what would happen on a Windows Server Core machine without a GUI) Fixes #2137 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Josh Bleecher Snyder	4b1f2ae382	tstest/integration: generate deps for all platforms in deps generator We have different deps depending on the platform. If we pick a privileged platform, we'll miss some deps. If we use the union of all platforms, the integration test won't compile on some platforms, because it'll import packages that don't compile on that platform. Give in to the madness and give each platform its own deps file. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Brad Fitzpatrick	6eecf3c9d1	ipn/ipnlocal: stay out of map poll when down Fixes #2434 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	798b0da470	tstest/integration/vms: codegen for top level tests (#2441 ) This moves the distribution definitions into a maintainable hujson file instead of just existing as constants in `distros.go`. Comments are maintained from the inline definitions. This uses jennifer[1] for hygenic source tree creation. This allows us to generate a unique top-level test for each VM run. This should hopefully help make the output of `go test` easier to read. This also separates each test out into its own top-level test so that we can better track the time that each distro takes. I really wish there was a way to have the `test_codegen.go` file _always_ run as a part of the compile process instead of having to rely on people remembering to run `go generate`, but I am limited by my tools. This will let us remove the `-distro-regex` flag and use `go test -run` to pick which distros are run. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	391207bbcf	tstest/integration/vms: use one testcontrol instance per VM (#2437 ) This paves the way for future MagicDNS tests. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
julianknodt	1bb6abc604	net/portmapper: add upnp port mapping Add in UPnP portmapping, using goupnp library in order to get the UPnP client and run the portmapping functions. This rips out anywhere where UPnP used to be in portmapping, and has a flow separate from PMP and PCP. RELNOTE=portmapper now supports UPnP mappings Fixes #682 Updates #2109 Signed-off-by: julianknodt <julianknodt@gmail.com>	3 years ago
Christine Dodrill	3ebe16558c	tstest/integration/vms: attempt to send more UDP packets (#2433 ) Apparently this test was flaking because I critically misunderstood how the kernel buffers UDP packets for senders. I'm trying to send more UDP packets and will see if that helps. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	09e81b8ba1	tstest/integration/vms: deflake the tailscale_status test (#2427 ) This test used to try to run this only once, but this variant of the test attempts to run `tailscale status` up to 6 times in a loop with exponential backoff. This fixes the flakiness found in previous instances of this test. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Brad Fitzpatrick	01e159b610	ipn/ipnlocal: save prefs to disk on UpdatePrefs Regression from `6d10655dc3`, which added UpdatePrefs but didn't write it out to disk. I'd planned on adding tests to state_test.go which is why I'd earlier added `46896a9311` to prepare for making such persistence tests easier to write, but turns out state_test.go didn't even test UpdatePrefs, so I'm staying out of there. Instead, this is tested using integration tests. Fixes #2321 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	5b845631ce	tstest/integration/vms: delete a log file i was using to debug the tests (#2416 ) Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	ede8ec1e20	tstest/integration/vms: split up test framework into files (#2396 ) My spatial memory functions poorly with large files and the vms_test.go file recently surpassed the point where it functions adequately. This patch splits up vms_test.go into more files to make my spatial memory function like I need it to. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	1f2a877c61	tstest/integration/testcontrol: add ipv6 support (#2394 ) Split from https://github.com/tailscale/tailscale/pull/2376. This adds IPv6 support to testcontrol so each member of the tailscale network gets an IPv6 address too. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	1b1c85d069	Revert "Revert "tstest/integration/vms: end-to-end UDP test (#2361 )" (#2364 )" (#2365 ) This reverts commit `254fc7885b`. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Simeng He	3d049a9d71	tstest/integration: change return type of AwaitIP from string to netaddr.IP Signed-off-by: Simeng He <simeng@tailscale.com>	3 years ago
Brad Fitzpatrick	7e7c4c1bbe	tailcfg: break DERPNode.DERPTestPort into DERPPort & InsecureForTests The DERPTestPort int meant two things before: which port to use, and whether to disable TLS verification. Users would like to set the port without disabling TLS, so break it into two options. Updates #1264 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Christine Dodrill	afbd35482d	tstest/integration/vms: add NixOS unstable back (#2330 ) The upstream NixOS issue was fixed. https://github.com/NixOS/nixpkgs/issues/128783 Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	33cacb5284	tstest/integration/vms: unbreak nixos builds (#2372 ) To avoid the generated nixos disk images from becoming immune from the GC, I delete the symlink to the nix store at the end of tests. `t.Cleanup` runs at the end of a test. I changed this part of the code to have a separate timer for how long it takes to run NixOS builds, but I did that by using a subtest. This means that it was creating the NixOS image, deleting its symlink and then trying to use that symlink to find the resulting disk image, making the whole thing ineffectual. This was a mistake. I am reverting this change made in https://github.com/tailscale/tailscale/pull/2360 to remove this layer of subtesting. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	254fc7885b	Revert "tstest/integration/vms: end-to-end UDP test (#2361 )" (#2364 ) This reverts commit `dc78be12c5`.	3 years ago
Christine Dodrill	dc78be12c5	tstest/integration/vms: end-to-end UDP test (#2361 ) This tests incoming and outgoing UDP traffic. It would test incoming UDP traffic however our socks server doesn't seem to allow for connecting to destinations over UDP. When the socks server gets that support the incoming test should pass without issue. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	a19eea965f	tstest/integration/vms: use an in-process logcatcher (#2360 ) This adapts the existing in-process logcatcher from tstest/integration into a public type and uses it on the side of testcontrol. This also fixes a bug in the Alpine Linux OpenRC unit that makes every value in `/etc/default/tailscaled` exported into tailscaled's environment, a-la systemd [Service].EnviromentFile. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago
Christine Dodrill	1e83b97498	tstest/integration/vms: outgoing SSH test (#2349 ) This does a few things: 1. Rewrites the tests so that we get a log of what individual tests failed at the end of a test run. 2. Adds a test that runs an HTTP server via the tester tailscale node and then has the VMs connect to that over Tailscale. 3. Dials the VM over Tailscale and ensures it answers SSH requests. 4. Other minor framework refactoring. Signed-off-by: Christine Dodrill <xe@tailscale.com>	3 years ago

1 2 3

103 Commits (2bb915dd0a102a09b1f997cf49951ffb6d15818c)