tailscale

Commit Graph

Author	SHA1	Message	Date
David Anderson	e1c1d47991	tsweb: memoize the string forms of HTTP response codes. Saves 1-2 allocs per HTTP request after warmup, thanks to avoiding strconv and fmt. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	c48513b2be	tsweb: support recording unabridged HTTP status codes as well. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
Brad Fitzpatrick	2d1849a7b9	tsweb: remove JSONHandlerFunc It's unused and we've decided it's not what we want. Change-Id: I425a0104e8869630b498a0adfd0f455876d6f92b Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
David Anderson	7b4960316b	tsweb: add PrometheusVar, for vars that want to output varz themselves. This enables the infrequent use of more complex Prometheus types, such as timeseries with high/irregular label cardinality, without needing to discover and implement generic abstracted type like LabelMap for each one. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
Maisem Ali	309c0a13a5	tsweb: add FQDN to Port80Handler to allow HTTPS redirects When the request comes in say over http://mon, the current implementation would rewrite it https://mon which causes the cert validation to fail. This PR keeps the existing behavior intact but also allows passing in a FQDN to the handler to reroute to the correct hostname. Related to https://github.com/tailscale/tailscale/pull/4208#pullrequestreview-913832340 Signed-off-by: Maisem Ali <maisem@tailscale.com>	3 years ago
Josh Bleecher Snyder	0868329936	all: use any instead of interface{} My favorite part of generics. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Brad Fitzpatrick	61ee72940c	all: use Go 1.18's strings.Cut More remain. Change-Id: I6ec562cc1f687600758deae1c9d7dbd0d04004cb Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	41fd4eab5c	envknob: add new package for all the strconv.ParseBool(os.Getenv(..)) A new package can also later record/report which knobs are checked and set. It also makes the code cleaner & easier to grep for env knobs. Change-Id: Id8a123ab7539f1fadbd27e0cbeac79c2e4f09751 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
slowy07	ac0353e982	fix: typo spelling grammar Signed-off-by: slowy07 <slowy.arfy@gmail.com>	3 years ago
Brad Fitzpatrick	51976ab3a2	tsweb: add vars for unix process start time and version To be scraped in the Go expvar JSON format, as a string is involved. For a future tool to record when processes restarted exactly, and at what version. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	c6740da624	tsweb: make VarzHandler support untyped expvar.Maps for compatibility Updates #2635 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	7c7eb8094b	tsweb: make VarzHandler support expvar.Funcs returning ints/floats Updates #2635	3 years ago
Brad Fitzpatrick	5aba620fb9	tsweb: make VarzHandler capable of walking structs with reflect To be used by control, per linked bug's plan. Updates #2635 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	3700cf9ea4	tsweb: also support LabelMaps from expvar.Map, without metrics We want to use tsweb to format Prometheus-style metrics from our temporary golang.org/x/net/http2 fork, but we don't want http2 to depend on the tailscale.com module to use the concrete type tailscale.com/metrics.LabelMap. Instead, let a expvar.Map be used instead of it's annotated sufficiently in its name. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	5f45d8f8e6	tsweb: add VarzHandler tests Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
julianknodt	3377089583	tsweb: add float64 to logged metrics A previously added metric which was float64 was being ignored in tsweb, because it previously only accepted int64 and ints. It can be handled in the same way as ints. Signed-off-by: julianknodt <julianknodt@gmail.com>	3 years ago
David Anderson	0022c3d2e2	tsweb: replace NewMux with a more flexible DebugHandler. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	48c25fa36f	tsweb: fold StdHandlerOpts and StdHandler200s with StdHandler. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	72343fbbec	tsweb: register expvars once at startup. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Josh Bleecher Snyder	516e8a4838	tsweb: add num_goroutines expvar Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
David Anderson	692a011b54	net/interfaces: remove IsTailscaleIP, make callers use tsaddr. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	017dcd520f	tsweb: export VarzHandler	4 years ago
David Anderson	57cd7738c2	tsweb: add an endpoint to manually trigger a GC. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Josh Bleecher Snyder	3b46655dbb	tsweb: add StatusCodeCounters to HandlerOptions This lets servers using tsweb register expvars that will track the number of requests ending in 200s/300s/400s/500s. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	e98f2c57d6	tsweb: add StdHandlerOpts that accepts an options struct I'm about to add yet another StdHandler option. Time to refactor. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
David Crawshaw	815bf017fc	tsweb: when unwrapping HTTPError, record the user-facing message also in the log There's often some useful piece of information in there not already repeated in the internal error. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	4 years ago
David Anderson	eccae0cd0c	tsweb: add ReturnHandlerFunc. Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago
Brad Fitzpatrick	64334143a1	tsweb: rename Handler to ReturnHandler The name's been bugging me for a long time. I liked neither the overlap between tsweb.Handler and http.Handler, nor the name "ServeHTTPErr" which sounds like it's an error being returned, like it's an error handler and not sometimes a happy path. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Anderson	af3a9dfad6	tsweb: add a StdHandler that doesn't log 200 responses. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
Brad Fitzpatrick	2863e49db9	tsweb: don't flush, treat no-op Handler as 200, like Go Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Anderson	2c2dff9559	tsweb: don't panic if we get a tsweb.Error with no embedded error. It's technically weird to return a tsweb.Error with no child err, but it's a sensible thing to want to do, and we shouldn't panic if it happens. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
David Anderson	12a6626a94	tsweb: use a ResponseWriter wrapper to log more accurately. Also adds tests, because the logging handler is acquiring a fair number of branches. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
Brad Fitzpatrick	6de37f4cc0	tsweb: move some comments, add a TODO	5 years ago
David Anderson	df4636567f	tsweb: adjust names and docs of the "handler with errors" functions. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
David Anderson	98eceae55e	tsweb: add a Handler type. Handler is like http.Handler, but returns errors. ErrHandler converts back to an http.Handler, with added error handling and logging. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
Brad Fitzpatrick	5c1e443d34	wgengine/monitor: don't call LinkChange when interfaces look unchanged Basically, don't trust the OS-level link monitor to only tell you interesting things. Sanity check it. Also, move the interfaces package into the net directory now that we have it.	5 years ago
Brad Fitzpatrick	a9cd8f31de	tsweb: don't double import expvar; appease staticcheck	5 years ago
Brad Fitzpatrick	890f5dff40	tsweb: export runtime.MemStats var in Prometheus format	5 years ago
Brad Fitzpatrick	61f3fda405	tsweb: let expvar.Ints be gauges too	5 years ago
Brad Fitzpatrick	57de94c7aa	tsweb: add /debug/ access via &debugkey + TS_DEBUG_KEY_PATH	5 years ago
David Anderson	d580157921	tsweb: quote label values to comply with Prometheus format.	5 years ago
David Anderson	f192c05413	metrics: add a LabelMap type for variables with 1 label dimension. This lets us publish sets of vars that are breakdowns along one dimension in a format that Prometheus and Grafana natively know how to do useful things with. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
Brad Fitzpatrick	e371520cc5	tsweb, derp: add expvar http.Handler for Prometheus's format And add some opinions. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	824f825552	tsweb, cmd/derper: move common web/debug stuff from derper to new tsweb Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago

44 Commits (2903d42921404777feb3b573487e66a5211dd87d)